D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > It is still impossible to detect (un)installation of such tool. > "More Search Tools" menu currently recreates the menu from > KMoreToolsMenuFactory when it is shown. > It is still impossible to

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > > So, the URL does not have any impact on the search tool chosen? I thought > > that was the main reason for using the URL and updating it all the time. > > This depends on KMoreToolsMenuFactory.

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > pdabrowski wrote in dolphinmainwindow.cpp:2289 > It was added to handle this action as a button in toolbar (can be added by > user, and this was requested in #384798). > > I didn't notice this causes such a problem with remote connections,

D22594: [Dolphin] Open Preferred Search Tool action

broulik added inline comments. INLINE COMMENTS > dolphinmainwindow.cpp:943 > KJobWidgets::setWindow(statJob, this); > statJob->exec(); > QUrl url = statJob->mostLocalUrl(); `exec()` on a job is generally bad, but looks like it was like this already? > dolphinmainwindow.cpp:2289

[plasma-desktop] doc/kcontrol: Remove old notifications docbook

Git commit c995119c12c6d690ab889d73ba2564c5b1d31ca6 by Kai Uwe Broulik. Committed on 16/01/2020 at 09:28. Pushed by broulik into branch 'master'. Remove old notifications docbook M +1-1doc/kcontrol/CMakeLists.txt D +0-2doc/kcontrol/kcmnotify/CMakeLists.txt D +0-117 doc

[plasma-desktop] doc/kcontrol/notifications: [Notifications KCM] Add docbook for new KCM

Git commit 75481705c68e38b21e357fd4df0540f1442759ff by Kai Uwe Broulik. Committed on 16/01/2020 at 09:27. Pushed by broulik into branch 'master'. [Notifications KCM] Add docbook for new KCM BUG: 415250 FIXED-IN: 5.18.0 Differential Revision: https://phabricator.kde.org/D26684 A +2-0

D26684: [Notifications KCM] Add docbook for new KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:75481705c68e: [Notifications KCM] Add docbook for new KCM (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26684?vs=73618=73681#toc REPOSITORY R119 Plasma Desktop

D26684: [Notifications KCM] Add docbook for new KCM

broulik marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26684 To: broulik, #documentation Cc: yurchor, plasma-devel, kde-doc-english, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, gennad, fbampaloukas, GB_2, ragreen, ZrenBot,

D26684: [Notifications KCM] Add docbook for new KCM

broulik updated this revision to Diff 73618. broulik added a comment. - Fix wording REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26684?vs=73600=73618 REVISION DETAIL https://phabricator.kde.org/D26684 AFFECTED FILES

D26684: [Notifications KCM] Add docbook for new KCM

broulik created this revision. broulik added a reviewer: Documentation. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415250 FIXED-IN: 5.18.0 TEST PLAN - Clicked "Help"

D23415: Improve comprehensibility and consistency of window placement mode names

broulik added a comment. In D23415#521420 , @hein wrote: > "Smart" is a non-label to me and pretty lazy; it's like someone did a attempt at branding an option as cool instead of putting effort into finding a succinct description of what it

D22444: Add Reset Zoom Level action inside View menu

broulik added inline comments. INLINE COMMENTS > dolphinui.rc:2 > > - > + > Careful, this clashes with the recent toolbar shuffling > dolphinview.cpp:1351 > +default:mode = ViewModeSettings::IconsMode; > +Q_ASSERT(false); > +

D19557: Update css

broulik added a comment. Can't we just go SVG with the icon? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D17482: Upload new screenshots in the documentation and uncomment a section

broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor, broulik Cc: broulik, yurchor, plasma-devel, kde-doc-english,

D17482: Upload new screenshots in the documentation and uncomment a section

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Breaks build of plasma-desktoop: index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article ^ index.docbook:118:

D16504: [KCMs] Use consistent text for GHNS buttons

broulik added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16504 To: ngraham, #plasma, #vdg Cc: broulik, Codezela, abetts, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, sebas,

[docs] [Bug 385569] KDE Plasma - no info page for plasma-5.11.php

https://bugs.kde.org/show_bug.cgi?id=385569 Kai Uwe Broulik <k...@privat.broulik.de> changed: What|Removed |Added CC|

[plasmashell] [Bug 382570] Right-click to menu item in global menu not forwarded

https://bugs.kde.org/show_bug.cgi?id=382570 Kai Uwe Broulik <k...@privat.broulik.de> changed: What|Removed |Added Version|5.7.2 |5.10.4

[Differential] [Commented On] D3276: Proofread/update kfind docbooks

broulik added a comment. Yeah, can you please file a bug report. I'll have a look when I find time, not that I ever used this, though. There were quite a few porting errors in KFind (missing tilde expansion, unable to deal with URLs without file:// etc) so doesn't surprise me there's more

[Differential] [Accepted] D3276: Proofread/update kfind docbooks

broulik accepted this revision. broulik added a comment. Sorry, I totally missed that review. Looks like a QUrl porting error/oversight - not that I ever used this although I knew it must have existed. REPOSITORY R228 KFind REVISION DETAIL https://phabricator.kde.org/D3276 EMAIL

[kde-doc-english] [kdelibs] kio/kfile: GUI: Make Edit File Type button an actual button and make it more obvious.

Git commit 131fabf76ec4688561892ba87e2aa86ad828ca70 by Kai Uwe Broulik. Committed on 22/07/2011 at 17:04. Pushed by broulik into branch 'master'. GUI: Make Edit File Type button an actual button and make it more obvious. REVIEW: 101800 M +8-11 kio/kfile/kpropertiesdialog.cpp http