D15580: New annotation toolbar

simgunz added a comment. When you create the merge request: - set the title to `WIP: title of merge request` to mark it as work in progress - push the commits as you work so you have a backup, can see the results of the CI tests and possibly receive feedbacks REPOSITORY R223 Okular

D15580: New annotation toolbar

simgunz abandoned this revision. simgunz added a comment. Moved to KDE invent. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidh

D15580: New annotation toolbar

simgunz added a comment. In D15580#605913 , @davidhurka wrote: > In D15580#605611 , @simgunz wrote: > > > aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll m

D15580: New annotation toolbar

simgunz added a comment. aacid requested to write some autotest for the ToggleActionMenu before merging this. I'll merge master in this review and work on the autotests soon. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.

D15580: New annotation toolbar

simgunz updated this revision to Diff 69406. simgunz added a comment. - Apply KDE Frameworks astyle REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=69405&id=69406 BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricato

D15580: New annotation toolbar

simgunz updated this revision to Diff 69405. simgunz added a comment. - Minor refactor REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=69380&id=69405 BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15

D15580: New annotation toolbar

simgunz added a comment. > Might it be a hint that there are too many toolbars? I think only the part should have the annotation toolbar, so it is clear which is affected by the hide action. Not defining the annotation toolbar also in `shell.rc` makes the implementation of the action to

D15580: New annotation toolbar

simgunz marked 2 inline comments as done. REPOSITORY R223 Okular BRANCH new-annotation-toolbar_ToggleActionMenu REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg, ngraham Cc: kde-doc-english, andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aaci

D15580: New annotation toolbar

simgunz updated this revision to Diff 69380. simgunz added a comment. - Merge remote-tracking branch 'origin/master' into new-annotation-toolbar_ToggleActionMenu REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15580?vs=69379&id=69380 BRANCH new-annotation

D15580: New annotation toolbar

simgunz updated this revision to Diff 69379. simgunz added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Add setToolBarVisible method - Fix annotation toolbar only hidden in first main window REPOSITORY R223 Okular CHANGES SINCE LAST UPDAT

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a comment. In D21156#486870 , @kfunk wrote: > Oh, I usually squash my changes into the original commit before uploading the change (i.e. via `arc diff`). I do not use an extra branch either. > > Phew. Anyhow. Let me sum this all

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a comment. In D21156#486838 , @kfunk wrote: > Huh? It's easier than that: > > - If you do not have the commit yet locally: > > ``` arc patch --nobranch git push ``` Or probably a simpler approach is to run these tw

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a comment. > - If you do have the commit and it is the latest one in your history: ``` arc amend git push ``` Sorry but it is still not clear if this would work. In this diff I have three commits (modification_1, modification_2, revert modifications_2) in a feature branch

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a comment. >> Wouldn't make more sense to do `arc land --onto 5.3` (and then merge 5.3 into master)? In this way the Differential Revision would be closed automatically. > > I suggest to do a `arc amend` (to basically update the commit message with current reviewers, "Diff

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a comment. In D21156#486717 , @aacid wrote: > If you're not using arc you should have included the "Differential Revision" line in the commit so it would close automatically as stated in https://community.kde.org/Policies/Commit_Po

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a comment. I have pushed to 5.3 and then merged to master manually, as specified in the Phabricator page guide. How do I close the revision now? REPOSITORY R32 KDevelop BRANCH fix-browse-by-key REVISION DETAIL https://phabricator.kde.org/D21156 To: simgunz, #kdevelop, r

D21156: Fix browse mode not disabled after Ctrl is released

simgunz added a commit: R32:5c5495929fcf: Fix browse mode not disabled after Ctrl is released. REPOSITORY R32 KDevelop BRANCH fix-browse-by-key REVISION DETAIL https://phabricator.kde.org/D21156 To: simgunz, #kdevelop, rjvbb, mwolff Cc: kde-doc-english, mwolff, rjvbb, kdevelop-devel, hmi

[kdevelop] /: Merge remote-tracking branch 'origin/5.3'

Git commit 1100938098d6478b7be7d2ad0249d0ab966537f2 by Simone Gaiarin. Committed on 25/06/2019 at 17:28. Pushed by gaiarin into branch 'master'. Merge remote-tracking branch 'origin/5.3' # Conflicts: # plugins/contextbrowser/browsemanager.cpp M +2-0doc/kdev

[kdevelop/5.3] /: Fix browse mode not disabled after Ctrl is released

Git commit 5c5495929fcfa0dd9d75ae76bbbf190cdac3e428 by Simone Gaiarin. Committed on 25/06/2019 at 17:23. Pushed by gaiarin into branch '5.3'. Fix browse mode not disabled after Ctrl is released M +2-0doc/kdevelop/index.docbook M +1-1plugins/contextbrowser/browsem

D21156: Fix browse mode not disabled after Ctrl is released

simgunz updated this revision to Diff 60099. simgunz added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Document feature REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21156?vs=60096&id=60099 BRANCH fix-