D17403: Copy root value or (x,y) pair to clipboard

This revision was automatically updated to reflect the committed changes. Closed by commit R334:4ec38cf969af: Copy root value or (x,y) pair to clipboard (authored by yurchor). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17403?vs=48134=49463#toc REPOSITORY R334 KmPlot CHANGES SINCE

D17403: Copy root value or (x,y) pair to clipboard

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R334 KmPlot REVISION DETAIL https://phabricator.kde.org/D17403 To: yurchor, #kde_edu, tcanabrava Cc: tcanabrava, aacid, kde-doc-english, kde-edu, skadinna, narvaez, apol

D17403: Copy root value or (x,y) pair to clipboard

yurchor updated this revision to Diff 48134. yurchor added a comment. Move "const" to the place where it should be. REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17403?vs=48128=48134 REVISION DETAIL https://phabricator.kde.org/D17403 AFFECTED FILES

D17403: Copy root value or (x,y) pair to clipboard

tcanabrava requested changes to this revision. tcanabrava added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > tcanabrava wrote in view.h:215 > this should be const. please take a look on const correctness >

D17403: Copy root value or (x,y) pair to clipboard

yurchor updated this revision to Diff 48128. yurchor added a comment. Add "const". REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17403?vs=47588=48128 REVISION DETAIL https://phabricator.kde.org/D17403 AFFECTED FILES doc/index.docbook

D17403: Copy root value or (x,y) pair to clipboard

yurchor marked an inline comment as done. REPOSITORY R334 KmPlot REVISION DETAIL https://phabricator.kde.org/D17403 To: yurchor, #kde_edu, tcanabrava Cc: tcanabrava, aacid, kde-doc-english, kde-edu, skadinna, narvaez, apol

D17403: Copy root value or (x,y) pair to clipboard

yurchor updated this revision to Diff 47588. yurchor added a comment. Fix indentation. Sorry. REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17403?vs=47470=47588 REVISION DETAIL https://phabricator.kde.org/D17403 AFFECTED FILES doc/index.docbook

D17403: Copy root value or (x,y) pair to clipboard

yurchor updated this revision to Diff 47470. yurchor added a comment. Get rid of unrelated changes, more locale-friendly result formatting for "Copy (x, y)". REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17403?vs=47236=47470 REVISION DETAIL

D17403: Copy root value or (x,y) pair to clipboard

yurchor updated this revision to Diff 47236. yurchor added a comment. Fix getter, indentation and signal name. REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17403?vs=47180=47236 REVISION DETAIL https://phabricator.kde.org/D17403 AFFECTED FILES

D17403: Copy root value or (x,y) pair to clipboard

yurchor marked 4 inline comments as done. yurchor added a comment. All issues should be fixed now. Thanks. REPOSITORY R334 KmPlot REVISION DETAIL https://phabricator.kde.org/D17403 To: yurchor, #kde_edu Cc: aacid, kde-doc-english, kde-edu, skadinna, narvaez, apol

D17403: Copy root value or (x,y) pair to clipboard

yurchor added a comment. In D17403#373971 , @aacid wrote: > Why do i get a "copy root value" option on f(x) = x that doesn't really have a root? Because technically it has a root (x=0) and exactly this value will be copied. To be

D17403: Copy root value or (x,y) pair to clipboard

aacid added a comment. Why do i get a "copy root value" option on f(x) = x that doesn't really have a root? REPOSITORY R334 KmPlot REVISION DETAIL https://phabricator.kde.org/D17403 To: yurchor, #kde_edu Cc: aacid, kde-doc-english, kde-edu, skadinna, narvaez, apol

D17403: Copy root value or (x,y) pair to clipboard

yurchor updated this revision to Diff 47180. yurchor added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Add some documentation. REPOSITORY R334 KmPlot CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17403?vs=47030=47180 REVISION