D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-19 Thread Carl Schwan
ognarb abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor, broulik Cc: broulik, yurchor, plasma-devel, kde-doc-english, GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai,

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Yuri Chornoivan
yurchor added a comment. In D17482#375270 , @ognarb wrote: > In D17482#375191 , @broulik wrote: > > > Breaks build of plasma-desktoop: > > > > index.docbook:104: parser error : Opening and

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Carl Schwan
ognarb added a comment. In D17482#375191 , @broulik wrote: > Breaks build of plasma-desktoop: > > index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article > > ^ >

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Yuri Chornoivan
yurchor added a comment. Fixed. Thanks. Sorry for been negligent when reviewing this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor, broulik Cc: broulik, yurchor, plasma-devel, kde-doc-english,

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Kai Uwe Broulik
broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor, broulik Cc: broulik, yurchor, plasma-devel, kde-doc-english,

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Kai Uwe Broulik
broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Breaks build of plasma-desktoop: index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article ^ index.docbook:118:

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R119:86bc4bb1f806: Upload new screenshots in the documentation and uncomment a section (authored by ognarb). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Carl Schwan
ognarb added a comment. In D17482#375170 , @yurchor wrote: > Oops... Sorry. No problems :) Thanks for the review. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb,

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Yuri Chornoivan
yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Oops... Sorry. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor Cc: yurchor,

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > yurchor wrote in index.docbook:103 > To keep the result valid this line should be removed as well. Look line 78, I just moved the beginning of the comment. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread Yuri Chornoivan
yurchor requested changes to this revision. yurchor added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > index.docbook:103 > > --> > To keep the result valid this line should be removed as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-11 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot,

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-10 Thread Carl Schwan
ognarb added a reviewer: Documentation. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17482: Upload new screenshots in the documentation and uncomment a section

2018-12-10 Thread Carl Schwan
ognarb created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ognarb requested review of this revision. REVISION SUMMARY New screenshots that reflect current version of system settings. I also uncommented a section in the