D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham added a comment. In D19186#423597 , @aspotashev wrote: > Hi Nate, > > You missed this one at daemon/actions/bundled/suspendsessionconfig.cpp:88: > > m_comboBox->addItem(QIcon::fromTheme("system-suspend-hybrid"), i18n("Hybrid

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

aspotashev added a comment. Hi Nate, You missed this one at daemon/actions/bundled/suspendsessionconfig.cpp:88: m_comboBox->addItem(QIcon::fromTheme("system-suspend-hybrid"), i18n("Hybrid suspend"), (uint)SuspendSession::SuspendHybridMode); REPOSITORY R122 Powerdevil REVISION

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

This revision was automatically updated to reflect the committed changes. Closed by commit R122:7ba43d4767f6: [KCM UI] Use the word Sleep instead of Suspend (authored by ngraham). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52242=52732

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

mart accepted this revision. REPOSITORY R122 Powerdevil BRANCH use-the-word-sleep (branched from master) REVISION DETAIL https://phabricator.kde.org/D19186 To: ngraham, #vdg, #plasma, broulik, filipf, mart Cc: filipf, mart, ltoscano, abetts, aacid, plasma-devel, kde-doc-english,

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 for the reasons listed in the commit message REPOSITORY R122 Powerdevil BRANCH use-the-word-sleep (branched from master) REVISION DETAIL https://phabricator.kde.org/D19186 To:

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

mart added a comment. +1, sleep is the common word used colloquially in english (note that indeed varies a lot with translations, for instance in italian windows 10 calls it "sospensione" so is actually suspend there) REPOSITORY R122 Powerdevil REVISION DETAIL

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52242. ngraham marked an inline comment as done. ngraham added a comment. Correct awkward string REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52156=52242 BRANCH use-the-word-sleep (branched from

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ltoscano added inline comments. INLINE COMMENTS > index.docbook:152 > > -If this option is chosen, a special behavior for activity can be chosen. If > this is a presentation activity, you can check the Never shutdown > the screen and Never suspend or shutdown the > computer boxes. It is

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham added a comment. In D19186#416850 , @aacid wrote: > -0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

abetts added a comment. +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D19186 To: ngraham, #vdg, #plasma, broulik Cc: abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed,

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

aacid added a comment. -0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only confuse the users. REPOSITORY R122 Powerdevil REVISION DETAIL

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52156. ngraham added a comment. Add context REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52149=52156 BRANCH use-the-word-sleep (branched from master) REVISION DETAIL

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ngraham requested review of this revision. REVISION SUMMARY [copy-pasted from T10500