dvratil updated this revision to Diff 82928.
dvratil added a comment.
Herald added a project: Documentation.
Herald added a subscriber: kde-doc-english.
- Address review comments
REPOSITORY
R206 KMail
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29724?vs=82769&id=82928
BRANCH
dvratil updated this revision to Diff 82929.
dvratil added a comment.
- Fix arc going crazy
REPOSITORY
R206 KMail
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29724?vs=82928&id=82929
BRANCH
arcpatch-D29724
REVISION DETAIL
https://phabricator.kde.org/D29724
AFFECTED FILES
mlaurent added inline comments.
INLINE COMMENTS
> mlaurent wrote in sendlaterutil_p.h:23
> not necessary no ?
I think that we can remove this include no ?
REPOSITORY
R206 KMail
REVISION DETAIL
https://phabricator.kde.org/D29724
To: dvratil, mlaurent
Cc: kde-doc-english, kde-pim, gennad, f
dvratil updated this revision to Diff 83039.
dvratil added a comment.
- Remove useless include
REPOSITORY
R206 KMail
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29724?vs=82929&id=83039
BRANCH
arcpatch-D29724
REVISION DETAIL
https://phabricator.kde.org/D29724
AFFECTED FIL
dvratil marked 3 inline comments as done.
dvratil added inline comments.
INLINE COMMENTS
> mlaurent wrote in sendlaterutil.cpp:32
> #include "sendlaterinfo.h"
Done on line 24.
REPOSITORY
R206 KMail
REVISION DETAIL
https://phabricator.kde.org/D29724
To: dvratil, mlaurent
Cc: kde-doc-englis
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R206 KMail
BRANCH
arcpatch-D29724
REVISION DETAIL
https://phabricator.kde.org/D29724
To: dvratil, mlaurent
Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin,
rodsevich, winterz
dvratil closed this revision.
REPOSITORY
R206 KMail
REVISION DETAIL
https://phabricator.kde.org/D29724
To: dvratil, mlaurent
Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin,
rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
dvratil added a task: T13172: kdepim-apps-libs cleanup.
REPOSITORY
R206 KMail
REVISION DETAIL
https://phabricator.kde.org/D29724
To: dvratil, mlaurent
Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin,
rodsevich, winterz, vkrause, mlaurent, knauss, dvratil