D29724: SendLaterAgent: merge libKF5SendLater library into the agent

dvratil updated this revision to Diff 82928. dvratil added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Address review comments REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82769&id=82928 BRANCH

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

dvratil updated this revision to Diff 82929. dvratil added a comment. - Fix arc going crazy REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82928&id=82929 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FILES

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

mlaurent added inline comments. INLINE COMMENTS > mlaurent wrote in sendlaterutil_p.h:23 > not necessary no ? I think that we can remove this include no ? REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, f

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

dvratil updated this revision to Diff 83039. dvratil added a comment. - Remove useless include REPOSITORY R206 KMail CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29724?vs=82929&id=83039 BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 AFFECTED FIL

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

dvratil marked 3 inline comments as done. dvratil added inline comments. INLINE COMMENTS > mlaurent wrote in sendlaterutil.cpp:32 > #include "sendlaterinfo.h" Done on line 24. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-englis

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R206 KMail BRANCH arcpatch-D29724 REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

dvratil closed this revision. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil

D29724: SendLaterAgent: merge libKF5SendLater library into the agent

dvratil added a task: T13172: kdepim-apps-libs cleanup. REPOSITORY R206 KMail REVISION DETAIL https://phabricator.kde.org/D29724 To: dvratil, mlaurent Cc: kde-doc-english, kde-pim, gennad, fbampaloukas, skadinna, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil