This revision was automatically updated to reflect the committed changes.
Closed by commit R238:b308f0cdb338: Workaround for MSVC and catalog loading
(authored by ltoscano).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5725?vs=14182=14198
REVISION DETAIL
bcooksley accepted this revision.
bcooksley added a comment.
This revision is now accepted and ready to land.
Code looks fine from my perspective, let's confirm this fixes things.
REPOSITORY
R238 KDocTools
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5725
To: ltoscano,
bcooksley added a comment.
Unfortunately our Jenkins Jobs aren't configured to apply patches, so there
isn't a way of testing this as such other than through:
1. Some manual handling
2. Committing it and seeing what happens.
REPOSITORY
R238 KDocTools
REVISION DETAIL
ltoscano added a subscriber: bcooksley.
ltoscano added a comment.
@bcooksley , is there a way to test this properly in the new CI (aka: without
me manually applying some patches), to see if I didn't do something weird that
made it work by accident?
REPOSITORY
R238 KDocTools
REVISION
ltoscano updated this revision to Diff 14182.
ltoscano added a comment.
Readd docs
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5725?vs=14181=14182
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5725
AFFECTED FILES
CMakeLists.txt
ltoscano created this revision.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: Documentation, Frameworks.
REVISION SUMMARY
Apparently setting XML_CATALOG_FILES has no effects on Windows
at least with MSVC (2017). The variable seems
