Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-11-11 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100794 --- Ship it! I think it's safe enough to import it. There is

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-11-11 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/ --- (Updated Nov. 11, 2016, 3:38 nachm.) Review request for Documentation,

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-11-11 Thread Burkhard Lück
> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote: > > If I understand it correctly, the review include two separate change > > (import + fixes), is it correct? Then it's fine by me (pending confirmation > > for the shipit), the changes are fine and we can refine it later (better > > than

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-11-11 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100777 --- If I understand it correctly, the review include two

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-11-11 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/ --- (Updated Nov. 11, 2016, 9:02 vorm.) Review request for Documentation,

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-10-16 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review100053 --- Maybe plasma people would be more confortable if the "Todo

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-09-15 Thread Burkhard Lück
> On Sept. 15, 2016, 11:07 vorm., Marco Martin wrote: > > doc/kcontrol/filetypes/index.docbook, line 19 > > > > > > kde 4.12? see my description the docbook is imported as it was splitted from kde-runtime, any

Re: Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-09-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/#review99204 --- doc/kcontrol/filetypes/index.docbook (line 19)

Review Request 128914: Import filetypes kcm docbook from kde-runtime master to kde-cli-tools with the code

2016-09-15 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128914/ --- Review request for Documentation, Localization and Translation (l10n) and