Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-07 Thread Patrick Spendrin
Am 07.08.2012 22:42, schrieb Alexander Neundorf: > On Tuesday 07 August 2012, Patrick Spendrin wrote: > >> Am 06.08.2012 21:35, schrieb Alexander Neundorf: > >> >> I added a KDEWinConfig.cmake as a first step > >> > > >> > Can you post a link to it here ? > >> > >> > https://projects.kde.org/

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-07 Thread Alexander Neundorf
On Tuesday 07 August 2012, Patrick Spendrin wrote: > Am 06.08.2012 21:35, schrieb Alexander Neundorf: > >> I added a KDEWinConfig.cmake as a first step > > > > Can you post a link to it here ? > > https://projects.kde.org/projects/kdesupport/kdewin/repository/revisions/70 > fec467fecfde722b1da55a

Re: Definition of done - warning

2012-08-07 Thread Albert Astals Cid
El Dimarts, 7 d'agost de 2012, a les 16:56:01, Kevin Ottens va escriure: > Hello, > > Looks like it got overlooked. ;-) > > On Saturday 07 July 2012 12:20:01 Benjamin Port wrote: > > Currently when we build kdelibs there are lots of warnings. That's why I > > suggest to add a remove all warnings

Re: Definition of done - warning

2012-08-07 Thread Kevin Ottens
Hello, Looks like it got overlooked. ;-) On Saturday 07 July 2012 12:20:01 Benjamin Port wrote: > Currently when we build kdelibs there are lots of warnings. That's why I > suggest to add a remove all warnings in the definition of done. > > But we can't remove all warnings, indeed some warnings c

Re: Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

2012-08-07 Thread Stephen Kelly
Jeremy Paul Whiting wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105897/ > --- > > (Updated Aug. 6, 2012, 6:53 p.m.) >

Re: Review Request: Make kcodecs framework build standalone

2012-08-07 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/#review17017 --- tier1/kcodecs/src/kcharsets.cpp

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-07 Thread Patrick Spendrin
Am 06.08.2012 21:35, schrieb Alexander Neundorf: > >> I added a KDEWinConfig.cmake as a first step > > Can you post a link to it here ? https://projects.kde.org/projects/kdesupport/kdewin/repository/revisions/70fec467fecfde722b1da55a1f805e852c20bf47 and the following patch. regards, Patrick >