Re: Review Request: Port some uses of KProcess to QProcess

2012-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106500/#review19173 --- Thanks for looking at this! Looks mostly good, apart from two

Re: Review Request: Port some uses of KProcess to QProcess

2012-09-19 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106500/#review19174 --- every single change of this patch is a regression - Oswald

Re: Review Request: Port some uses of KUrl to QUrl

2012-09-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106501/#review19175 --- Looks ok. Might break krununittest on systems with 'sh'

Re: Review Request: Port some uses of KUrl to QUrl

2012-09-19 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106501/ --- (Updated Sept. 19, 2012, 10:19 p.m.) Review request for KDE Frameworks.