Re: Review Request: Port some uses of KProcess to QProcess

2012-09-20 Thread Oswald Buddenhagen
On Sept. 19, 2012, 5:11 p.m., Oswald Buddenhagen wrote: every single change of this patch is a regression David Faure wrote: Very encouraging, as always. Care to give us more details? the reasons for kprocess' existence didn't go away, so every change away from it is by definition a

Re: Review Request: Port some uses of KUrl to QUrl

2012-09-20 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106501/#review19241 --- kio/tests/krununittest.cpp

Re: Review Request: KF5 - Q_OS_* not defined

2012-09-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105868/#review19247 --- Ship it! Please commit, the current stuff (Q_OS in

Re: Review Request: remove FindLibLZMA.cmake from karchive framework

2012-09-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105866/#review19248 --- Ship it! cmake 2.8.9 has been released now, please commit. -

Re: Review Request: Port some uses of KProcess to QProcess

2012-09-20 Thread Oswald Buddenhagen
On Sept. 19, 2012, 5:11 p.m., Oswald Buddenhagen wrote: every single change of this patch is a regression David Faure wrote: Very encouraging, as always. Care to give us more details? Oswald Buddenhagen wrote: the reasons for kprocess' existence didn't go away, so every change

Re: Notifications-future, a recap

2012-09-20 Thread Dario Freddi
2012/9/20 Sune Vuorela nos...@vuorela.dk: On 2012-09-17, Dario Freddi drf54...@gmail.com wrote: It really depends on what you want to achieve. If your goal is just cleaning up the API and implementing the existing standard it might work out, but for sure it won't just cut it for what I