Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Aaron J. Seigo
On Thursday, January 10, 2013 19:37:39 you wrote: > >> Is there another > >> dirmodel fork somewhere that does that? Link please :) > > > > well, what we ought to do is do a threaded version and then put it > > somewhere we can all share it properly :) i'll discuss with Marco what he > > thinks an

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Mark
On Thu, Jan 10, 2013 at 7:24 PM, Aaron J. Seigo wrote: > On Thursday, January 10, 2013 16:49:15 you wrote: >> On Thu, Jan 10, 2013 at 3:53 PM, Aaron J. Seigo wrote: >> > * DirModel::updatePreview calls setData for each preview that it gets >> > back. >> > that causes dataChanged to be emitted. ag

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Aaron J. Seigo
On Thursday, January 10, 2013 18:41:04 Frank Reininghaus wrote: > before considering such a thing, one would need to check if that is > really a significant bottleneck. if it means having to calculate by iterating over every single item in a listing, then it will eventually become a bottleneck.

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Frank Reininghaus
Hi, 2013/1/10 Aaron J. Seigo: > in the case of dolphin, i can imagine a goal that could lead to over- > calculating: wanting even spacing between all icons, which in turn means > knowing how much space each and every icon will require (thumbnail? how much > text? etc.) The number of text lines re

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Alexander Neundorf
On Thursday 10 January 2013, Mark wrote: ... > > * DirModel::updatePreview calls setData for each preview that it gets > > back. that causes dataChanged to be emitted. again, for each index. this > > needs to be batched up and/or DirModel should override data() itself to > > return Qt::DecorationRo

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Mark
On Thu, Jan 10, 2013 at 3:53 PM, Aaron J. Seigo wrote: > On Thursday, January 10, 2013 14:12:30 you wrote: >> part very rapidly. No issue thus far. But when i start scrolling >> _while_ the data is dripping in it's ... not very responsive. > > after a quick look: > > the DirModel is doing all the

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Aaron J. Seigo
On Thursday, January 10, 2013 14:12:30 you wrote: > part very rapidly. No issue thus far. But when i start scrolling > _while_ the data is dripping in it's ... not very responsive. after a quick look: the DirModel is doing all the data retrieval in the main thread as well as instantly on demand

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Mark
On Thu, Jan 10, 2013 at 12:20 PM, Aaron J. Seigo wrote: > On Thursday, January 10, 2013 11:30:35 Mark wrote: >> very rapidly, the actual view is still barely usable as long as files >> are dripping in. This is the same in QML (ListView) as in QWidgets >> The issue here is that the view - even thou

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Aaron J. Seigo
On Thursday, January 10, 2013 11:30:35 Mark wrote: > very rapidly, the actual view is still barely usable as long as files > are dripping in. This is the same in QML (ListView) as in QWidgets > The issue here is that the view - even though it's not > showing the items - is doing all the calculation

Re: Patch: Remove kDebug includes from kio/kio

2013-01-10 Thread David Faure
On Thursday 10 January 2013 15:35:29 Jignesh Kakadiya wrote: > Hi David, > > I have removed all the kdebug.h includes from kio/kio. Please review it. Go for it :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Mark
On Thu, Jan 10, 2013 at 9:23 AM, Frank Reininghaus wrote: > Hi, > > 2013/1/9 Mark: >> On Wed, Jan 9, 2013 at 2:51 PM, David Faure wrote: >>> On Wednesday 09 January 2013 11:15:20 Mark wrote: A little more in depth questions for KDirLister and KFileItem. In my profiling KFileItem ends up

Patch: Remove kDebug includes from kio/kio

2013-01-10 Thread Jignesh Kakadiya
Hi David, I have removed all the kdebug.h includes from kio/kio. Please review it. Thanks, Jignesh remove_kdebug_includes.patch Description: Binary data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/li

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

2013-01-10 Thread Frank Reininghaus
Hi, 2013/1/9 Mark: > On Wed, Jan 9, 2013 at 2:51 PM, David Faure wrote: >> On Wednesday 09 January 2013 11:15:20 Mark wrote: >>> A little more in depth questions for KDirLister and KFileItem. In my >>> profiling KFileItem ends up high due to various reasons, but >>> KDirLister is also a bit of a h

Re: Patch: port kError to qError and kFatal to qFatal

2013-01-10 Thread David Faure
On Thursday 10 January 2013 10:49:10 Jignesh Kakadiya wrote: > Here cmd is int so I haven't made any changes. for listit I used qWarning() > followed by abort(). Please review it. Ah. Well, if cmd is int, you have to use %d rather than %s. -- David Faure, fa...@kde.org, http://www.davidfaure.fr