Re: KF5 Update Meeting Minutes 2013-w24

2013-06-12 Thread Kevin Ottens
Hello, On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: 2013/6/11 Kevin Ottens: [...] * ItemViews will be tier 2 until we contribute the natural compare to Qt; I thought that Qt 5.1 will have the QCollator class, which can perform natural comparison of strings if you use

Re: KF5 Update Meeting Minutes 2013-w24

2013-06-12 Thread Frank Reininghaus
Hi, thanks for the explanation! 2013/6/12 Kevin Ottens: Hello, On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: 2013/6/11 Kevin Ottens: [...] * ItemViews will be tier 2 until we contribute the natural compare to Qt; I thought that Qt 5.1 will have the QCollator class, which

Re: Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

2013-06-12 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110876/#review34204 --- khtml/misc/loader.h

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-12 Thread Aleix Pol Gonzalez
On June 11, 2013, 9:07 a.m., Kevin Ottens wrote: This change go in. Note that I disagree with the aim though: KWidgets should *not* depend on KIconThemes. Now having KIconThemes not use KGlobalSettings is completely welcome (aim being to have KGlobalSettings in kde4support at some

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-12 Thread Kevin Ottens
On June 11, 2013, 9:07 a.m., Kevin Ottens wrote: This change go in. Note that I disagree with the aim though: KWidgets should *not* depend on KIconThemes. Now having KIconThemes not use KGlobalSettings is completely welcome (aim being to have KGlobalSettings in kde4support at some

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/ --- (Updated June 12, 2013, 2:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review34224 --- Ship it! Looks ok to me - David Faure On June 12, 2013,

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/#review34225 --- This review has been submitted with commit

Re: Review Request 110833: Remove KIconLoader dependency to KWidgets

2013-06-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110833/ --- (Updated June 12, 2013, 2:15 p.m.) Status -- This change has been

Build failed in Jenkins: kdelibs_frameworks_qt5 #710

2013-06-12 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/710/changes Changes: [neoclust.kde] Remove extra #endif [aleixpol] Fix compilation -- [...truncated 6756 lines...] from

Build failed in Jenkins: kdelibs_frameworks_qt5 #711

2013-06-12 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/711/changes Changes: [aleixpol] Revert Fix compilation [neoclust.kde] Revert previous commit done quite simultaneously from the other one [faure+bluesystems] Remove deprecated Job::showErrorDialog, it breaks core/widgets separation.

Build failed in Jenkins: kdelibs_frameworks_qt5 #715

2013-06-12 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/715/changes Changes: [neoclust.kde] Get rid of onfig-compiler.h.cmake and config-prefix.h.cmake -- [...truncated 9916 lines...] In file included from

Review Request 110983: Move KToolBarPopupAction to KWidgetsAddons

2013-06-12 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110983/ --- Review request for KDE Frameworks. Description --- Move

Jenkins build is back to stable : kdelibs_frameworks_qt5 #717

2013-06-12 Thread KDE CI System
See http://build.kde.org/job/kdelibs_frameworks_qt5/717/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel