Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/#review34468 --- Ship it! staging/kjobwidgets/src/kabstractwidgetjobtracker.h

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/#review34470 --- Ship it! Please fix the unused includes spotted by David,

Re: Review Request 111028: Move kkeyserver* to KWindowsSystem

2013-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/#review34471 --- kdeui/util/kkeyserver.cpp

Re: Review Request 111028: Move kkeyserver* to KWindowsSystem

2013-06-17 Thread Benjamin Port
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111028/ --- (Updated June 17, 2013, 10:34 a.m.) Review request for KDE Frameworks.

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34475 --- ping... - Aleix Pol Gonzalez On June 14, 2013, 10:27 a.m.,

Re: Review Request 110845: Move kdeui/itemviews to ItemViews framework

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110845/#review34477 --- This review has been submitted with commit

Re: Review Request 110995: move jobs from kdeui to kjobswidgets framework

2013-06-17 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110995/ --- (Updated June 17, 2013, 11:17 a.m.) Status -- This change has been

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
On June 14, 2013, 6:59 a.m., Kevin Ottens wrote: staging/kconfigwidgets/src/kviewstatemaintainer.h, line 25 http://git.reviewboard.kde.org/r/111002/diff/1/?file=150267#file150267line25 Should be kconfigwidgets_export.h ... I even suspect this line could go completely. Yes. It

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Kevin Ottens
On June 14, 2013, 6:59 a.m., Kevin Ottens wrote: staging/kconfigwidgets/src/kviewstatemaintainer.h, line 25 http://git.reviewboard.kde.org/r/111002/diff/1/?file=150267#file150267line25 Should be kconfigwidgets_export.h ... I even suspect this line could go completely. Wojciech

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/ --- (Updated June 17, 2013, 1:13 p.m.) Review request for KDE Frameworks,

Jenkins build is back to stable : plasma-framework_master_qt5 #477

2013-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/477/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34496 --- Ship it! Ship It! - David Faure On June 17, 2013, 1:56

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34497 --- kdeui/paged/kpageview_p.cpp

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34498 --- About the question in the message: keeping a header for a

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34499 --- H very odd, it looks like kviewstatemaintainer.cpp content

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/ --- (Updated June 17, 2013, 3:17 p.m.) Review request for KDE Frameworks,

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34500 --- Ship it! Ship It! - Kevin Ottens On June 17, 2013, 3:19

Re: Review Request 111002: Move kviewstatemainteiner to KConfigWidgets

2013-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111002/#review34501 --- Ship it! Ship It! - Kevin Ottens On June 17, 2013, 3:17

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/#review34503 --- This review has been submitted with commit

Re: Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110997/ --- (Updated June 17, 2013, 3:34 p.m.) Status -- This change has been

KF5 Update Meeting Reminder

2013-06-17 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally signed message

KGlobalSettings move to kde4support

2013-06-17 Thread Aleix Pol
Hi, So I was looking at KGlobalSettings to see what we need to do to finally deprecate all KGlobalSettings, as suggested by the required kdelibs cleanups. So the things missing to be done are: - (in)active(Title/Color)Color: I'm unsure why those are there, but they're only used by khtml (within