Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/84/#review35019 --- Please also mark the feature on KLineEdit deprecated in that pa

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Re: QLineEdit and QComboBox tasks

Hello, On Tuesday 25 June 2013 00:17:24 Albert Vaca wrote: > As you say, a search on lxr reveals that it is used in 4 places. Of > those, 2 are already KUrlRequesters. To avoid breaking the other 2, we > can keep the property in KLineEdit and KComboBox (that will be in > KDE4Support), even though

Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/84/ --- (Updated June 24, 2013, 10:15 p.m.) Review request for KDE Frameworks. S

Review Request 111184: Moved url drop functionality from KLineEdit to KUrlChooser

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/84/ --- Review request for KDE Frameworks. Description --- KLineEdit and KCom

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

> On June 24, 2013, 2:18 p.m., Kevin Ottens wrote: > > staging/ki18n/src/klocalizedstring.cpp, line 44 > > > > > > Wondering, would that be something for the QPA platform theme then? So > > that ki18n stays passiv

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/78/#review34986 --- staging/ki18n/src/klocalizedstring.cpp

Re: Review Request 111210: Move KHelpMenu and friends to XmlGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/#review34985 --- Please split that review in two. One with the changes you did t

Re: Review Request 111191: Move KTextEdit to KTextWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review34984 --- staging/ktextwidgets/src/findreplace/kfinddialog.cpp

Re: Review Request 110988: Port kio-file to QFile

> On June 21, 2013, 7:44 a.m., David Faure wrote: > > Did you upload the same patch as before? The issues are still there (e.g. > > if (!write)) > > Martin Klapetek wrote: > I haven't updated it yet, will do so today. > > Kevin Ottens wrote: > Today as in three days ago? ;) Fwiw, I wa

Re: Review Request 111183: Move KLanguageButton to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/#review34980 --- staging/kwidgets/src/widgets/klanguagebutton.h

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 109667: Make some KConfig classes return a bool when saving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review34978 --- Ship it! Couple of nitpicks otherwise looks good. tier2/kcon

Re: Review Request 111175: Move KIconButton and KIconDialog to KIconThemes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/75/#review34977 --- Ship it! Ship It! - Kevin Ottens On June 22, 2013, 2:02 p.m

Re: Review Request 111170: Move KTip to KWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/70/#review34976 --- This patch is mostly correct. The KConfig dependency should sta

Re: Review Request 110988: Port kio-file to QFile

> On June 21, 2013, 7:44 a.m., David Faure wrote: > > Did you upload the same patch as before? The issues are still there (e.g. > > if (!write)) > > Martin Klapetek wrote: > I haven't updated it yet, will do so today. Today as in three days ago? ;) - Kevin -

DataEngine & KPluginFactory

Hey, As you know, I'm looking into what's needed for proper plugin support in KF5, trying to understand what's going on, and at least making our KDE4 solution work for KF5. Qt's native plugin functionality is clearly lacking for our usecase, as it doesn't allow to have multiple instances of the

Re: C++11 support on Frameworks

Le dimanche 23 juin 2013 02:16:01 Luiz Romário Santana Rios a écrit : > Will the Frameworks allow C++11? How much of it will be allowed? The KDE frameworks are extensions to Qt, so same rules as in Qt, to give the frameworks the same potential audience as the Qt libraries themselves : * Can't re

Re: C++11 support on Frameworks

Hello, On Sunday 23 June 2013 02:16:01 Luiz Romário Santana Rios wrote: > I just started contributing to the Frameworks recently (I'm R_Rios on > IRC) and I didn't finda thread about it in the ML archives, so I'll > just ask it myself. > > Will the Frameworks allow C++11? How much of it will be a

Re: QLineEdit and QComboBox tasks

Hello, On Saturday 22 June 2013 17:34:41 Albert Vaca wrote: > There are two tasks in Qt5 Epics [1] to implement replace-on-drop for > URLs on QLineEdit and QComboBox. This is currently present in > KLineEdit and KComboBox, because this behaviour is needed for > KUrlRequester (bug [2]). > > We (aa

Review Request 111210: Move KHelpMenu and friends to XmlGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- Review request for KDE Frameworks. Description --- Move: * KAboutAppl

Re: Review Request 111191: Move KTextEdit to KTextWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated June 24, 2013, 10:45 a.m.) Review request for KDE Frameworks. C

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 110858: Cleanup KDE development scripts

> On June 11, 2013, 7:43 p.m., David Faure wrote: > > build-progress.sh, line 16 > > > > > > I thought grep -r wasn't portable? Yep, this should be "-R", of course. Many grep(1) implementations still accept "-r",