Re: Review Request 111298: Add a URL handler for help:/// urls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/#review35340 --- Cool. No testing, though?

Re: DataEngine KPluginFactory

On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: On Monday, 2013-07-01, Sebastian Kügler wrote: Open questions: - KPart and QWidget create* calls: In my current patch, these are simply ignored. I'm getting away with one overridden function in our macro-generated

Re: e-c-m now installs into non-versioned directory

Le vendredi 28 juin 2013 23:27:13 Alexander Neundorf a écrit : Hi, I just increased the version of e-c- to 0.0.9 and it now installs simply into share/ECM/ instead share/ECM-0.0.9/. Thank you, thank you, thank you! You don't have to update it yet, but if you want to see whether this works

Re: DataEngine KPluginFactory

On Monday, 2013-07-01, Sebastian Kügler wrote: On Monday, July 01, 2013 13:35:27 Kevin Krammer wrote: On Monday, 2013-07-01, Sebastian Kügler wrote: On Monday, July 01, 2013 09:03:29 Kevin Krammer wrote: What if the macro only creates the header content (as its name already

Re: DataEngine KPluginFactory

On Monday, July 01, 2013 14:35:51 Kevin Krammer wrote: Well, the goal, for me, is to make plugin factories work. Right now, we only have a handful constructor, and I want to make it possible to build those with as little extra hassle as possible -- it means porting all plugins, and that's

Re: Review Request 111270: move kmodifierkeyinfo to KGuiAddons framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111270/#review35355 --- Note that a second patch to solve the TODO in the

Re: Review Request 111285: reduce KCompletion test dependency

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111285/ --- (Updated July 1, 2013, 2:49 p.m.) Status -- This change has been

Re: Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

On June 25, 2013, 6:46 a.m., Kevin Ottens wrote: kio/kfile/kurlrequester.cpp, line 483 http://git.reviewboard.kde.org/r/84/diff/2/?file=165624#file165624line483 Why don't you use KUrlMimeData like the original code in KLineEdit? It'll be more robust AFAICT. Albert Vaca

Re: Review Request 111319: Move kmessagewidget to kwidgetsaddons

On July 1, 2013, 3:08 p.m., Kevin Ottens wrote: tier1/kwidgetsaddons/src/kmessagewidget.cpp, line 90 http://git.reviewboard.kde.org/r/111319/diff/1/?file=166799#file166799line90 Could be changed to Close this message I guess. Close document has always been weird in that context

Re: Review Request 111298: Add a URL handler for help:/// urls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/ --- (Updated July 1, 2013, 5:13 p.m.) Review request for KDE Frameworks.

Review Request 111348: Don't require KApplication for using KGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111348/ --- Review request for KDE Frameworks. Description --- Initialize it

Re: Review Request 111348: Don't require KApplication for using KGlobalSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111348/#review35380 --- Veto. This ignores the history behind activate(). Commit log

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

On July 1, 2013, 2:39 p.m., Kevin Ottens wrote: kdeui/util/kglobalsettings.h, line 265 http://git.reviewboard.kde.org/r/71/diff/2/?file=166657#file166657line265 I think it's fine. lxr.kde.org seem to indicate that those colors got abused at some places anyway, and what's

Re: Review Request 111298: Add a URL handler for help:/// urls

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/#review35401 --- staging/kwidgets/src/urlhandler.cpp

Re: Review Request 111320: Port time_t to QDateTime in KHTMLPart (KIO)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111320/ --- (Updated July 1, 2013, 8:14 p.m.) Status -- This change has been

Re: Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111246/#review35405 --- This review has been submitted with commit

Re: Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111246/ --- (Updated July 1, 2013, 8:19 p.m.) Status -- This change has been

Re: Review Request 111301: Port time_t to QDateTime in http_cache_cleaner.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111301/#review35404 --- This review has been submitted with commit

Re: Review Request 111298: Add a URL handler for help:/// urls

On July 1, 2013, 8:01 p.m., David Gil Oliva wrote: staging/kwidgets/src/urlhandler.cpp, line 59 http://git.reviewboard.kde.org/r/111298/diff/3/?file=166986#file166986line59 const QString dir - const QString dir From the kdelibs coding style:

Review Request 111353: Port time_t to QDateTime in kdirwatch_unittest.cpp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111353/ --- Review request for KDE Frameworks. Description --- Port time_t to

KF5 Update Meeting Reminder

Hello all, I forgot to send it yesterday, so just a quick reminder: The next KF5 Update Meeting will happen *today* at *4pm* Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: