Re: Review Request 111319: Move kmessagewidget to kwidgetsaddons

2013-07-02 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111319/#review35419 --- Ship it! Ship It! - Kevin Ottens On July 1, 2013, 4:16 p.m.

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-07-02 Thread Kevin Ottens
> On July 1, 2013, 2:39 p.m., Kevin Ottens wrote: > > kdeui/util/kglobalsettings.h, line 265 > > > > > > I think it's fine. lxr.kde.org seem to indicate that those colors got > > abused at some places anyway, and

Re: Review Request 111353: Port time_t to QDateTime in kdirwatch_unittest.cpp

2013-07-02 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111353/#review35421 --- Ship it! Ship It! - Kevin Ottens On July 1, 2013, 9:57 p.m.

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-02 Thread Kevin Ottens
> On July 1, 2013, 8:01 p.m., David Gil Oliva wrote: > > staging/kwidgets/src/urlhandler.cpp, line 59 > > > > > > const QString& dir -> const QString &dir > > > > From the kdelibs coding style: > > http:/

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-02 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/#review35425 --- staging/kwidgets/src/urlhandler.cpp

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/ --- (Updated July 2, 2013, 11:07 a.m.) Review request for KDE Frameworks and K

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-02 Thread Aleix Pol Gonzalez
> On July 2, 2013, 8:35 a.m., Kevin Ottens wrote: > > staging/kwidgets/src/urlhandler.cpp, line 44 > > > > > > Well, this whole block creates such a help:/foo and then calls > > QDesktopService::openUrl again with

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-02 Thread Aleix Pol Gonzalez
> On July 1, 2013, 5:47 p.m., David Faure wrote: > > staging/kwidgets/src/CMakeLists.txt, line 29 > > > > > > everything else is in a subdir. utils/ would be good, I guess? I'll do that, I didn't put it in a subdi

Re: Review Request 111319: Move kmessagewidget to kwidgetsaddons

2013-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111319/ --- (Updated July 2, 2013, 10:57 a.m.) Status -- This change has been mar

Fwd: Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Alex Merry
I suspect a lot of people read both, but it's probably better to keep frameworks discussions on the frameworks list as much as possible. Forwarding there now. Alex Original Message Subject: Re: KIO progress towards tier 1 framework? Date: Tue, 2 Jul 2013 13:05:25 +0200 From: M

KIO progress towards tier 1 framework? (resend)

2013-07-02 Thread Mark
Hi, When i'm looking in the kdelibs splitting document [1] i only see KIO pop up twice. One to get kbookmarks out of KIO (which is work in progress). Another one with "kio-core" as work in progress. But i can't find any documentation anywhere that gives me a clear view as to how far KIO is on it'

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread David Faure
Le mardi 2 juillet 2013 13:49:01 Mark a écrit : > Hi, > > When i'm looking in the kdelibs splitting document [1] i only see KIO > pop up twice. One to get kbookmarks out of KIO (which is work in > progress). Another one with "kio-core" as work in progress. Right. > But i can't find any documenta

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Kevin Ottens
On Tuesday 02 July 2013 14:06:37 David Faure wrote: > KIO can't be tier1 though: kio core depends on kcoreaddons (for KJob), on > KConfig and on ki18n. > (and on kservice for some strange default-user-agent feature, maybe we can > change that) > > That makes it tier2 if we can remove the kservic

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 2, 2013, 3:32 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111080: Macro*.cmake changes

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/ --- (Updated July 2, 2013, 3:34 p.m.) Review request for KDE Frameworks and Al

Re: Review Request 111210: Move KHelpMenu and friends to XmlGui

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 2, 2013, 4:20 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111348: Don't require KApplication for using KGlobalSettings

2013-07-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111348/ --- (Updated July 2, 2013, 2:39 p.m.) Status -- This change has been disc

KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 27 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas, wojtask9 and myself. Topics discussed: * QFontsDatabase patch is getting ready; * Support for ct

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/#review35452 --- I don't understand the description of the change. It says "KLoc

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review35453 --- I guess I need a --find-copies-harder version of this to be abl

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/ --- (Updated July 2, 2013, 5:59 p.m.) Review request for KDE Frameworks and Ke

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/ --- (Updated July 2, 2013, 6:04 p.m.) Review request for KDE Frameworks and Ke

Re: Review Request 111353: Port time_t to QDateTime in kdirwatch_unittest.cpp

2013-07-02 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111353/ --- (Updated July 2, 2013, 4:14 p.m.) Status -- This change has been mark

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/#review35455 --- staging/kwidgets/src/widgets/klanguagebutton.cpp

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 2, 2013, 6:14 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111210: Move KHelpMenu and friends to XmlGui

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111210/ --- (Updated July 2, 2013, 6:31 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/ --- (Updated July 2, 2013, 6:44 p.m.) Review request for KDE Frameworks and Ke

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/ --- (Updated July 2, 2013, 7 p.m.) Review request for KDE Frameworks. Change

Re: Review Request 111298: Add a URL handler for help:/// urls

2013-07-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111298/ --- (Updated July 2, 2013, 6 p.m.) Review request for KDE Frameworks. Change

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/#review35468 --- kdeui/widgets/klanguagebutton.h

Re: Review Request 111191: Move KTextEdit to KTextWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/91/#review35473 --- Ship it! There are a lot of QLatin1String("...") which should

Re: KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Alexander Neundorf
On Tuesday 02 July 2013, Kevin Ottens wrote: > Hello everyone, > > This is the minutes of the Week 27 KF5 meeting. As usual it has been held > on #kde-devel at 4pm Paris time. > > Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas, > wojtask9 and myself. ... > * [steveire] i

Re: Review Request 111080: Macro*.cmake changes

2013-07-02 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111080/#review35475 --- Isn't the feature_summary() call missing some arguments ? - Al

Re: Why is KConfig tier2?

2013-07-02 Thread Alexander Neundorf
On Saturday 22 June 2013, Aleix Pol wrote: > On Sat, Jun 22, 2013 at 1:17 PM, David Faure wrote: > > Le samedi 22 juin 2013 13:03:22 Aleix Pol a écrit : > > > Hi, > > > We've been looking through some code scratching our heads on how we can > > > > do > > > > > it to workaround uses of KConfig b

Re: KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Alexander Neundorf
On Tuesday 02 July 2013, Kevin Ottens wrote: > Hello everyone, > > This is the minutes of the Week 27 KF5 meeting. As usual it has been held > on #kde-devel at 4pm Paris time. > > Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas, > wojtask9 and myself. > > Topics discussed

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Mark
** ahh, so we're continuing in this message after all instead of "KIO progress towards tier 1 framework? (resend)". ** On Tue, Jul 2, 2013 at 2:06 PM, David Faure wrote: > Le mardi 2 juillet 2013 13:49:01 Mark a écrit : >> Hi, >> >> When i'm looking in the kdelibs splitting document [1] i only se

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/ --- (Updated July 2, 2013, 9:42 p.m.) Review request for KDE Frameworks and Ke

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Chusslove Illich
> [: Kevin Ottens :] > Note that apparently there's no interest from the maintainer in making > ki18n tier1 (ktranscript plugin being part of it and depending on kjs)... > Which would make KIO tier3. You might want either to discuss with > Chusslove or consider using tr() I'm afraid. In the case o

Build failed in Jenkins: kdelibs_frameworks_qt5 #789

2013-07-02 Thread KDE CI System
See Changes: [vonreth] Start to replace parts of the wmi backend with a new faster backend [vonreth] some progress [vonreth] more progress, eliminated multiple enties [vonreth] fixed storagedrive, implemented a kind of blockdevice

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/ --- (Updated July 2, 2013, 10:46 p.m.) Review request for KDE Frameworks and K

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Stephen Kelly
Chusslove Illich wrote: >> [: Kevin Ottens :] >> Note that apparently there's no interest from the maintainer in making >> ki18n tier1 (ktranscript plugin being part of it and depending on kjs)... >> Which would make KIO tier3. You might want either to discuss with >> Chusslove or consider using t

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread Chusslove Illich
> [: Stephen Kelly :] > As far as I understand, the ki18n library does not depend on a javascript > engine, but only the separate ktranscript plugin does? It is not really separate, it is in plugin form only as an internal optimization detail (languages which don't use it don't pay the memory/ sta

Re: KIO progress towards tier 1 framework?

2013-07-02 Thread David Faure
Le mardi 2 juillet 2013 21:35:13 Mark a écrit : > ** ahh, so we're continuing in this message after all instead of "KIO > progress towards tier 1 framework? (resend)". ** No, this was a reply to your message on k-f-d. I just removed the "resend" in my reply, it didn't make sense for the reply. >

Build failed in Jenkins: kdelibs_frameworks_qt5 #790

2013-07-02 Thread KDE CI System
See Changes: [faure+bluesystems] Fix compilation by porting klanguagebuttontest -- [...truncated 16153 lines...]

Re: Review Request 111183: Move KLanguageButton to KWidgets

2013-07-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/83/#review35481 --- Ship it! thanks! (sorry for the conflict in the test program,

Re: KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Sune Vuorela
On 2013-07-02, Alexander Neundorf wrote: > E.g. kplotting and kwidgets have the same dependencies. I wouldn't mind > having > kplotting as part of kwidgets. I do think that consideratiotns like these are very important, but I also think we should wait with looking at merging them just a bit unt