Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review37187 --- staging/kservice/src/desktoptojson/kconfigtojson.cpp

Build failed in Jenkins: plasma-framework_master_qt5 #549

See -- [...truncated 567 lines...] from :23: /srv/j

Re: install paths

On Monday 05 August 2013 18:29:19 Aurélien Gâteau wrote: > We inherit the "plugins" dir from Qt itself. Qt installs image formats > plugins in LIBDIR/plugins/imageformats, styles plugins in > LIBDIR/plugins/styles and so on, so it makes sense to keep this > LIBDIR/plugins/CATEGORY structure IMO.

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37193 --- I was just working on the same thing. I'm not sure if we want

Review Request 111905: Actually emit iconChanged

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description

Re: Ki18n mostly ready

> [: Albert Astals Cid :] > to make it more obvious maybe it should be KI18N_TRANSLATION_DOMAIN ? Well possibly, but to me it looks redundant: "translation domain" is already Gettext-specific terminology, and it would be bizarre to use more than one Gettext-based system in the same piece of code s

Re: Ki18n mostly ready

> [: Sebastian Kügler :] > Putting KLocalizedString::insertCatalog in is good enough, mark it > DEPRECATED so we get warned that porting work is coming up. The way I see it, there are no more KLocalizedString::insertCatalog() calls anywhere :) All newly incoming code for porting will have the olde

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/#review37195 --- You seem to have forgotten about kcommentwidget. It can be disc

Re: Review Request 111905: Actually emit iconChanged

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/#review37197 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 6, 2013, 9:1

Re: Review Request 111905: Actually emit iconChanged

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- (Updated Aug. 6, 2013, 9:58 a.m.) Status -- This change has been disc

Build failed in Jenkins: plasma-framework_master_qt5 #550

See Changes: [hein] Make the setData() accessor take a QVariant as payload. -- [...truncated 563 lines...]

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

> On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: > > I was just working on the same thing. > > > > I'm not sure if we want to move this to kde4support. Can we just throw it > > away? Or would that be terribly wrong? We have a replacement in > > nepomuk-widgets. > > > > Strigi doesn't need to b

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

> On Aug. 6, 2013, 9:39 a.m., Vishesh Handa wrote: > > You seem to have forgotten about kcommentwidget. It can be discarded/moved > > as well. Ok! Will do. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

> On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: > > I was just working on the same thing. > > > > I'm not sure if we want to move this to kde4support. Can we just throw it > > away? Or would that be terribly wrong? We have a replacement in > > nepomuk-widgets. > > > > Strigi doesn't need to b

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

> On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: > > I was just working on the same thing. > > > > I'm not sure if we want to move this to kde4support. Can we just throw it > > away? Or would that be terribly wrong? We have a replacement in > > nepomuk-widgets. > > > > Strigi doesn't need to b

Jenkins build is back to stable : kdelibs_frameworks_qt5 #980

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111906: Update QToolbar's when icon changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/ --- Review request for KDE Frameworks. Description --- This is the first

Re: install paths

Le mardi 6 août 2013 07:27:21 Kevin Ottens a écrit : > On Monday 05 August 2013 18:29:19 Aurélien Gâteau wrote: > > Le lundi 5 août 2013 15:33:13 Sune Vuorela a écrit : > > > Next up is the '/kf5/' directory. I don't see what a shared kf5 > > > directory > > > for plugins is for since plugins for e

Re: Review Request 111906: Update QToolbar's when icon changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111906/#review37205 --- staging/frameworkintegration/src/platformtheme/kdeplatformthem

Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- Review request for KDE Frameworks and Plasma. Description --- Add KCo

Build failed in Jenkins: plasma-framework_master_qt5 #551

See Changes: [notmart] stackview has the currentitem, not page property -- [...truncated 564 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs

Jenkins build is back to normal : plasma-framework_master_qt5 #552

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2013-w31

Kevin Ottens wrote: > On Thursday 01 August 2013 00:38:51 Stephen Kelly wrote: >> Kevin Ottens wrote: >> >> So, if this target/variable task is deferred until CMake 2.8.13 can be >> >> used, the variables don't have to be used even in an intermediate >> >> state. >> > >> > I see, but when is 2.8.

Re: KF5 Update Meeting Minutes 2013-w31

On Tuesday 06 August 2013 15:37:02 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Thursday 01 August 2013 00:38:51 Stephen Kelly wrote: > >> Kevin Ottens wrote: > >> >> So, if this target/variable task is deferred until CMake 2.8.13 can be > >> >> used, the variables don't have to be used even i

Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111910/ --- Review request for KDE Frameworks. Description --- I've looked throug

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37219 --- As a non-Plasma user of this class, I fully support it being he

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 112 > > > > > > This looks like it should be const > > > > I suspect it wasn't because KCoreConfigSelet

Re: Review Request 111789: Improve KFileItemList memory usage and performance

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111789/#review37222 --- This review has been submitted with commit 0c01e89b329a846718e

Re: Review Request 111789: Improve KFileItemList memory usage and performance

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111789/ --- (Updated Aug. 6, 2013, 3:28 p.m.) Status -- This change has been mark

Jenkins build became unstable: kdelibs_frameworks_qt5 #982

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w32

Hello everyone, This is the minutes of the Week 31 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, albertvaka, apol, d_ed, mck182, mgraesslin, miroslav, PovAddict, sandsmark, sebas, shadeslayer, Sho, teo, vHanda and myself. Announcement

Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111911/ --- Review request for KDE Frameworks. Description --- A couple of issues

Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- Review request for KDE Frameworks. Description --- This patch introdu

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 112 > > > > > > This looks like it should be const > > > > I suspect it wasn't because KCoreConfigSelet

Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/ --- Review request for KDE Frameworks. Description --- Port khtml_part a

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982

Hi, 2013/8/6 KDE CI System : > See the crash in KDirListerTest has been caused by my recent change https://git.reviewboard.kde.org/r/111789/ First of all, I apologize for not having run that test before. I had thought that running KF

Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982

Hi, 2013/8/6 Frank Reininghaus: > Hi, > > 2013/8/6 KDE CI System : >> See > > the crash in KDirListerTest has been caused by my recent change > > https://git.reviewboard.kde.org/r/111789/ > > First of all, I apologize for not having run

Jenkins build is back to stable : kdelibs_frameworks_qt5 #984

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 6, 2013, 2:52 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 112 > > > > > > This looks like it should be const > > > > I suspect it wasn't because KCoreConfigSelet

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37232 --- > The tests seem to segfault with and without this patch. If y

Build failed in Jenkins: plasma-framework_master_qt5 #555

See Changes: [ervin] KWidgets is gone [ervin] Add missing includes -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Jenkins build is back to normal : kdelibs_frameworks_qt5 #987

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #556

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_stable #754

See Changes: [aacid] Prepare for 4.11.0 -- [...truncated 10762 lines...] from :29, from

Jenkins build is back to normal : kdelibs_stable #755

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111927: remove K_EXPORT_PLUGIN macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/ --- Review request for KDE Frameworks. Description --- Remove K_EXPORT_PL

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 7, 2013, 1:20 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review37244 --- This review has been submitted with commit 4df6c4926ef1d01acea

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 7, 2013, 1:28 a.m.) Status -- This change has been mark

Jenkins build became unstable: kdelibs_frameworks_qt5 #990

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 112 > > > > > > This looks like it should be const > > > > I suspect it wasn't because KCoreConfigSelet

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 6, 2013, 4:52 p.m., David Edmundson wrote: > > tier1/kconfig/src/gui/kconfigloader.h, line 112 > > > > > > This looks like it should be const > > > > I suspect it wasn't because KCoreConfigSelet