Hi,
I'd like to reach a decision regarding spell checking for QTextEdit.
It was initially a Qt5 task:
Allow to register a default syntax highlighter type for QTextEdit, the KDE
backend would register the spell checking one coming from sonnet as default
I started working on this task and put
On Wed, Aug 7, 2013 at 11:13 AM, Aurélien Gâteau agat...@kde.org wrote:
Hi,
I'd like to reach a decision regarding spell checking for QTextEdit.
It was initially a Qt5 task:
Allow to register a default syntax highlighter type for QTextEdit, the KDE
backend would register the spell
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/#review37260
---
tier1/sonnet/src/ui/texteditinstaller.h
On Wednesday, 2013-08-07, Aurélien Gâteau wrote:
A. Find a way to inject spellchecking in all QTextEdit through either QPA
or our style.
Pros:
- Completely transparent to Qt app developers
- Porting a KDE app to KF5 is only KTextEdit = QTextEdit
Cons:
- Depends on QPA and/or style, so
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111912/
---
(Updated Aug. 7, 2013, 1:05 p.m.)
Review request for KDE Frameworks.
Le mercredi 7 août 2013 11:13:53 Aurélien Gâteau a écrit :
Hi,
I'd like to reach a decision regarding spell checking for QTextEdit.
It was initially a Qt5 task:
Allow to register a default syntax highlighter type for QTextEdit, the KDE
backend would register the spell checking one
On Wednesday, 2013-08-07, Aurélien Gâteau wrote:
More on this topic, Alex Fiestas suggested a new option:
C) Add spellchecking to QTextEdit itself:
- Extend QTextEdit with new properties to enable spellchecking, set
spellchecking language...
- Add a spellcheck syntax highlighter
- Extend
See http://build.kde.org/job/kdelibs_frameworks_qt5/992/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Wednesday 07 August 2013 13:44:19 Kevin Krammer wrote:
On Wednesday, 2013-08-07, Aurélien Gâteau wrote:
I am tempted to say B) in the short term since it's mostly done, then C),
but this could mean KDE apps would be first changed to use
Sonnet::TextEditInstaller, only to drop it when
I decided to rearrange stuff on my system and did a clean build of qt5 from two
days ago, and then phonon4qt5 and kf5, using the latest cmake.
phonon4qt5 compiled and installed ok, and kf5 said that it was found, but then
failed:
In file included from
Le mercredi 7 août 2013 13:44:19 Kevin Krammer a écrit :
On Wednesday, 2013-08-07, Aurélien Gâteau wrote:
More on this topic, Alex Fiestas suggested a new option:
C) Add spellchecking to QTextEdit itself:
- Extend QTextEdit with new properties to enable spellchecking, set
spellchecking
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/#review37284
---
tier1/kconfig/autotests/kconfigloadertest.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111927/#review37285
---
Ship it!
Ship It!
- David Faure
On Aug. 7, 2013, 12:37
Le mercredi 7 août 2013 15:44:52 vous avez écrit :
On Wed, Aug 7, 2013 at 10:13 AM, Aurélien Gâteau agat...@kde.org wrote:
Hi,
I'd like to reach a decision regarding spell checking for QTextEdit.
It was initially a Qt5 task:
Allow to register a default syntax highlighter type for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111916/#review37288
---
This code should be made portable (to Windows), please use
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111911/#review37287
---
A global KDE::open: why not, might make windows porting
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111897/
---
(Updated Aug. 7, 2013, 4:23 p.m.)
Review request for KDE Frameworks and
On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote:
OK, I see now that it uses pointers to be able to modify the actual
KFileItems in KDirListerCache (if it would just keep KFileItems and
modify these, I guess that they would just detach from the ones inside
the cache, leaving those
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111910/#review37292
---
Thanks for that review.
So, profiles() and setProfile() are
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111886/#review37293
---
bump! (I think it didn't hit the mailing list for some
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111886/#review37298
---
Ship it!
just one thing to fix first
kdesu/client.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111937/
---
Review request for KDE Frameworks and Konsole.
Description
---
Port
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111927/
---
(Updated Aug. 7, 2013, 5:20 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111927/#review37299
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111937/#review37300
---
I don't think it is yet time to *default* to building the qt5
See http://build.kde.org/job/kdelibs_frameworks_qt5/993/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See http://build.kde.org/job/kdelibs_frameworks_qt5/994/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Aug. 7, 2013, 4:25 p.m., David Faure wrote:
Thanks for that review.
So, profiles() and setProfile() are used? For which purpose?
Martin Klapetek wrote:
profiles() is used quite extensively in kdepim, it iterates over profiles
looking for an email address (aka is this
On Aug. 7, 2013, 7:31 p.m., Sune Vuorela wrote:
I don't think it is yet time to *default* to building the qt5 versions. It
is these days quite normal to have both qt4 and qt5 installed and available.
True, didn't think about that. I will invert that logic. Any other objections?
-
On Aug. 7, 2013, 5:41 p.m., David Faure wrote:
tier1/kconfig/autotests/kconfigloadertest.cpp, line 56
http://git.reviewboard.kde.org/r/111908/diff/1/?file=176357#file176357line56
I have trouble understanding the purpose of this class. How is this
different from
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111908/
---
(Updated Aug. 8, 2013, 6:58 a.m.)
Review request for KDE Frameworks,
31 matches
Mail list logo
