Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/ --- (Updated Aug. 8, 2013, 6:58 a.m.) Review request for KDE Frameworks, Plasm

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

> On Aug. 7, 2013, 5:41 p.m., David Faure wrote: > > tier1/kconfig/autotests/kconfigloadertest.cpp, line 56 > > > > > > I have trouble understanding the purpose of this class. How is this > > different from > >

Review Request 111938: Allow installing both qca2 and qca3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111938/ --- Review request for KDE Frameworks. Description --- It is currently no

Re: Review Request 111937: Port to KF5/Qt5

> On Aug. 7, 2013, 7:31 p.m., Sune Vuorela wrote: > > I don't think it is yet time to *default* to building the qt5 versions. It > > is these days quite normal to have both qt4 and qt5 installed and available. True, didn't think about that. I will invert that logic. Any other objections? - Al

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111910/#review37308 --- Ship it! Ship It! - David Faure On Aug. 6, 2013, 2:30 p.m.,

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

> On Aug. 7, 2013, 4:25 p.m., David Faure wrote: > > Thanks for that review. > > > > So, profiles() and setProfile() are used? For which purpose? > > Martin Klapetek wrote: > profiles() is used quite extensively in kdepim, it iterates over profiles > looking for an email address (aka "is t

Jenkins build became unstable: kdelibs_frameworks_qt5 #995

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

> On Aug. 7, 2013, 4:25 p.m., David Faure wrote: > > Thanks for that review. > > > > So, profiles() and setProfile() are used? For which purpose? profiles() is used quite extensively in kdepim, it iterates over profiles looking for an email address (aka "is this particular email address among

Jenkins build is back to stable : kdelibs_frameworks_qt5 #994

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #993

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111937: Port to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111937/#review37300 --- I don't think it is yet time to *default* to building the qt5 v

Re: Review Request 111927: remove K_EXPORT_PLUGIN macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/#review37299 --- This review has been submitted with commit 3d00e4b21a89eb19dd2

Re: Review Request 111927: remove K_EXPORT_PLUGIN macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/ --- (Updated Aug. 7, 2013, 5:20 p.m.) Status -- This change has been mark

Review Request 111937: Port to KF5/Qt5

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111937/ --- Review request for KDE Frameworks and Konsole. Description --- Port t

Re: Review Request 111886: Stop using kde_file.h in kdesu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111886/#review37298 --- Ship it! just one thing to fix first kdesu/client.cpp

Re: Review Request 111886: Stop using kde_file.h in kdesu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111886/#review37293 --- bump! (I think it didn't hit the mailing list for some reason.

Re: Review Request 111910: Deprecate unused methods + enum values in KEMailSettings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111910/#review37292 --- Thanks for that review. So, profiles() and setProfile() are us

KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: > OK, I see now that it uses pointers to be able to modify the actual > KFileItems in KDirListerCache (if it would just keep KFileItems and > modify these, I guess that they would just detach from the ones inside > the cache, leaving those

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111897/ --- (Updated Aug. 7, 2013, 4:23 p.m.) Review request for KDE Frameworks and Vi

Re: Review Request 111911: Port kioslave/ftp/ftp.cpp away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111911/#review37287 --- A global KDE::open: why not, might make windows porting easier.

Re: Review Request 111916: Port khtml_part away from kde_file.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review37288 --- This code should be made portable (to Windows), please use QFil

Re: RFC: spell checking for QTextEdit

Le mercredi 7 août 2013 15:44:52 vous avez écrit : > On Wed, Aug 7, 2013 at 10:13 AM, Aurélien Gâteau wrote: > > Hi, > > > > I'd like to reach a decision regarding spell checking for QTextEdit. > > > > It was initially a Qt5 task: > > > > "Allow to register a default syntax highlighter type for

Re: Review Request 111927: remove K_EXPORT_PLUGIN macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111927/#review37285 --- Ship it! Ship It! - David Faure On Aug. 7, 2013, 12:37 a.m.

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review37284 --- tier1/kconfig/autotests/kconfigloadertest.cpp

Re: RFC: spell checking for QTextEdit

Le mercredi 7 août 2013 13:44:19 Kevin Krammer a écrit : > On Wednesday, 2013-08-07, Aurélien Gâteau wrote: > > More on this topic, Alex Fiestas suggested a new option: > > > > C) Add spellchecking to QTextEdit itself: > > - Extend QTextEdit with new properties to enable spellchecking, set > > spe

phonon detection

I decided to rearrange stuff on my system and did a clean build of qt5 from two days ago, and then phonon4qt5 and kf5, using the latest cmake. phonon4qt5 compiled and installed ok, and kf5 said that it was found, but then failed: In file included from /var/git/kf5/interfaces/kmediaplayer/kfile

Re: RFC: spell checking for QTextEdit

On Wednesday 07 August 2013 13:44:19 Kevin Krammer wrote: > On Wednesday, 2013-08-07, Aurélien Gâteau wrote: > > I am tempted to say B) in the short term since it's mostly done, then C), > > but this could mean KDE apps would be first changed to use > > Sonnet::TextEditInstaller, only to drop it wh

Jenkins build is back to stable : kdelibs_frameworks_qt5 #992

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: RFC: spell checking for QTextEdit

On Wednesday, 2013-08-07, Aurélien Gâteau wrote: > More on this topic, Alex Fiestas suggested a new option: > > C) Add spellchecking to QTextEdit itself: > - Extend QTextEdit with new properties to enable spellchecking, set > spellchecking language... > - Add a spellcheck syntax highlighter > - E

Re: RFC: spell checking for QTextEdit

Le mercredi 7 août 2013 11:13:53 Aurélien Gâteau a écrit : > Hi, > > I'd like to reach a decision regarding spell checking for QTextEdit. > > It was initially a Qt5 task: > > "Allow to register a default syntax highlighter type for QTextEdit, the KDE > backend would register the spell checking o

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/ --- (Updated Aug. 7, 2013, 1:05 p.m.) Review request for KDE Frameworks. Cha

Re: RFC: spell checking for QTextEdit

On Wednesday, 2013-08-07, Aurélien Gâteau wrote: > A. Find a way to inject spellchecking in all QTextEdit through either QPA > or our style. > > Pros: > - Completely transparent to Qt app developers > - Porting a KDE app to KF5 is only KTextEdit => QTextEdit > > Cons: > - Depends on QPA and/or s

Re: Review Request 111912: Introduce Sonnet::TextEditInstaller: easily add spellcheck support to a QTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111912/#review37260 --- tier1/sonnet/src/ui/texteditinstaller.h

Re: RFC: spell checking for QTextEdit

On Wed, Aug 7, 2013 at 11:13 AM, Aurélien Gâteau wrote: > Hi, > > I'd like to reach a decision regarding spell checking for QTextEdit. > > It was initially a Qt5 task: > > "Allow to register a default syntax highlighter type for QTextEdit, the KDE > backend would register the spell checking one c

RFC: spell checking for QTextEdit

Hi, I'd like to reach a decision regarding spell checking for QTextEdit. It was initially a Qt5 task: "Allow to register a default syntax highlighter type for QTextEdit, the KDE backend would register the spell checking one coming from sonnet as default" I started working on this task and put