Review Request 112151: Use components in FindXCB

2013-08-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- Review request for KDE Frameworks and Alexander Neundorf. Description

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/#review38098 --- staging/kio/src/core/authinfo.cpp

Re: Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it

2013-08-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112118/#review38099 --- Ship it! staging/kde4support/autotests/CMakeLists.txt

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 7:29 a.m., Kevin Ottens wrote: > > Ship It! Vishesh, anything preventing you to push this patch? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 9:30 a.m., Kevin Ottens wrote: > > Ship It! Wojciech, anything preventing you to push this patch? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/#revie

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 9:31 a.m., Kevin Ottens wrote: > > Ship It! Wojciech, anything preventing you from pushing this patch? - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/#

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Kevin Ottens
> On Aug. 12, 2013, 9:24 a.m., Kevin Ottens wrote: > > tier1/kconfig/src/gui/CMakeLists.txt, line 15 > > > > > > You will have to rebase your patch because of a commit I've pushed just > > now. It should use Qt5::

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112052/#review38105 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 11:53 a.

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 11:08 a.m., Albert Astals Cid wrote: > > Can it maybe even be a QCoreApplication? > > Wojciech Kapuscinski wrote: > Probably yes :) Kevin? Quite some of those tests refer to QIcon and QColor, so QGuiApplication makes more sense. - Kevin -

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/#review38108 --- Ship it! Ship It! - Kevin Ottens On Aug. 13, 2013, 11:06 a.

Re: Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112118/ --- (Updated Aug. 19, 2013, 9:03 a.m.) Status -- This change has been mar

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/#review38109 --- I'll trust you with the XCB code I'm totally clueless on that.

Re: Review Request 112118: Move KGlobalSettings to kde4support, stop compiling kdeui while at it

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112118/#review38110 --- This review has been submitted with commit 4bb2e6783c0965e6c98

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Kevin Ottens
> On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote: > > kfile/kdirselectdialog.cpp, line 408 > > > > > > Hmmm it makes me realize, couldn't KEncodingFileDialog be made to > > depend on the file module only? That w

Build failed in Jenkins: kdelibs_frameworks_qt5 #1034

2013-08-19 Thread KDE CI System
See Changes: [aleixpol] Move KGlobalSettings to kde4support, stop compiling kdeui while at it -- [...truncated 15967 lines...] [ 74%] Building CXX object staging/xmlgui/src/CMakeFiles/XmlGui.d

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/ --- (Updated Aug. 19, 2013, 9:32 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review38117 --- Ship it! Ship It! - Kevin Ottens On Aug. 19, 2013, 9:32 a.m

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review38118 --- Ship it! Ship It! - David Faure On Aug. 19, 2013, 9:32 a.m.

Re: Review Request 112151: Use components in FindXCB

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112151/ --- (Updated Aug. 19, 2013, 9:39 a.m.) Review request for KDE Frameworks, Alex

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38113 --- staging/kguiaddons/src/util/qiconoverlay.h

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/#review38122 --- kio/kfile/kurlrequester.cpp

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/#review38124 --- staging/frameworkintegration/src/platformtheme/CMakeLists.txt

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/ --- (Updated Aug. 19, 2013, 10:27 a.m.) Review request for KDE Frameworks. D

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/#review38125 --- Ship it! Ship It! - Kevin Ottens On Aug. 19, 2013, 10:27 a.

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/ --- (Updated Aug. 19, 2013, 10:37 a.m.) Status -- This change has been ma

Re: Review Request 112051: port kconfig_compiler from QApplication to QGuiApplication

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112051/ --- (Updated Aug. 19, 2013, 10:37 a.m.) Status -- This change has been ma

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/#review38127 --- This review has been submitted with commit 796a4955977430545cd

Re: Review Request 112046: reduce itmeviews test dependency

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112046/#review38129 --- This review has been submitted with commit 2f99377331f12ca3fb0

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/#review38130 --- This review has been submitted with commit 127b55739d507b97900

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/#review38128 --- This review has been submitted with commit d9a79c3091d44a00ac2

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/ --- (Updated Aug. 19, 2013, 10:37 a.m.) Status -- This change has been ma

Re: Review Request 112060: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 3)

2013-08-19 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112060/ --- (Updated Aug. 19, 2013, 10:25 a.m.) Review request for KDE Frameworks. C

Re: Review Request 111985: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 2)

2013-08-19 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111985/ --- (Updated Aug. 19, 2013, 10:40 a.m.) Status -- This change has been ma

Re: Review Request 111945: Use LINK_PUBLIC and LINK_PRIVATE in CMake (part 1)

2013-08-19 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111945/ --- (Updated Aug. 19, 2013, 10:40 a.m.) Status -- This change has been ma

Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-19 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112037/ --- (Updated Aug. 19, 2013, 10:43 a.m.) Review request for KDE Frameworks. D

KF5 Update Meeting 2013-w34 Reminder

2013-08-19 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by BlueSystems and KDAB to work on KDE Frameworks signature.asc Description: This is a digitally si

Build failed in Jenkins: kdelibs_frameworks_qt5 #1037

2013-08-19 Thread KDE CI System
See Changes: [wojtask9.kde] fix test linking -- [...truncated 15396 lines...] from :

Build failed in Jenkins: kdelibs_frameworks_qt5 #1036

2013-08-19 Thread KDE CI System
See Changes: [wojtask9.kde] Port kconfig_compiler from QApplication to QGuiApplication [wojtask9.kde] Use LINK_PRIVATE LINK_PUBLIC in CMake (part 1) [wojtask9.kde] Use LINK_PRIVATE LINK_PUBLIC in CMake (part 2) [wojtask9.kde] Reduc

Build failed in Jenkins: kdelibs_frameworks_qt5 #1038

2013-08-19 Thread KDE CI System
See Changes: [aleixpol] Remove KDEUI_DEPRECATED uses -- [...truncated 15284 lines...] :56:1: warning:

Build failed in Jenkins: kdelibs_frameworks_qt5 #1039

2013-08-19 Thread KDE CI System
See Changes: [afiestas] Remove unused include that fixes build [afiestas] kconfigskeleton is in KConfigGui, so adding it to the target -- [...truncated 15585 lines...]

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/#review38139 --- This review has been submitted with commit 499b52c5d6f169d9d78

Re: Review Request 111916: Port khtml_part away from kde_file.h

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111916/ --- (Updated Aug. 19, 2013, 2:05 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #1040

2013-08-19 Thread KDE CI System
See Changes: [me] Port khtml_part away from kde_file.h -- [...truncated 15585 lines...] [ 68%] Building CXX object staging/kiconthemes/tests/CMakeFiles/kiconeffecttest.dir/kiconeffecttest.cpp.

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112052/#review38143 --- This review has been submitted with commit 723d6d37b3286678cfd

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112052/ --- (Updated Aug. 19, 2013, 2:43 p.m.) Status -- This change has been mar

Re: Review Request 112096: Port KWindowEffects to XCB

2013-08-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112096/ --- (Updated Aug. 19, 2013, 5:11 p.m.) Review request for KDE Frameworks and M

Build failed in Jenkins: plasma-framework_master_qt5 #600

2013-08-19 Thread KDE CI System
See Changes: [notmart] remove old test panel -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #601

2013-08-19 Thread KDE CI System
See Changes: [notmart] export fillWidth/fillHeight properties -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #602

2013-08-19 Thread KDE CI System
See Changes: [notmart] correctly pass fillWidth and hints to outer layers -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Build failed in Jenkins: kdelibs_frameworks_qt5 #1043

2013-08-19 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kde

Build failed in Jenkins: kdelibs_frameworks_qt5 #1044

2013-08-19 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kde

Can not find XCB modules.

2013-08-19 Thread Bhushan Shah
Hello, I am using project-neon5 on KUbuntu 13.04. I have every packages installed on my computer which is required to build. I can not build kwin, kstyles and powermanagement data engine so I have to disable it for building kde-workspace. CMake exits saying that XCB Libraries are not installed. [

Re: Review Request 111636: Port away from kde_file.h in AuthInfo (KIO)

2013-08-19 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111636/ --- (Updated Aug. 19, 2013, 9:41 p.m.) Review request for KDE Frameworks. Ch

Build failed in Jenkins: plasma-framework_master_qt5 #603

2013-08-19 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Build failed in Jenkins: plasma-framework_master_qt5 #604

2013-08-19 Thread KDE CI System
See Changes: [mgraesslin] Fix linking -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace

Review Request 112170: Drop hack for cyclic depndencies between kde4support and kdelibs

2013-08-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112170/ --- Review request for KDE Frameworks. Description --- With KDEUI gone th