Review Request 112353: An attempt to fix sometimes failing KArchive test

2013-08-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112353/ --- Review request for KDE Frameworks. Description --- One of the

Re: Review Request 112353: An attempt to fix sometimes failing KArchive test

2013-08-29 Thread Mario Bensi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112353/#review38834 --- Ship it! Ship It! - Mario Bensi On Aug. 29, 2013, 10:13

Build failed in Jenkins: plasma-framework_master_qt5 #653

2013-08-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/653/changes Changes: [notmart] enable panel shadows [notmart] add shadows to dialogs -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave -

Review Request 112363: Make it possible for QToolBar to use Other toolbar settings

2013-08-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112363/ --- Review request for KDE Frameworks. Description --- Qt only knows

Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/ --- Review request for KDE Frameworks, kdelibs and Michael Pyne. Description

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38893 --- Looks good to me, but someone else should approve. - David

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38905 --- Yes it makes sense, although probably we should just nuke the

Re: Review Request 112367: Include the icon's theme in the cache key

2013-08-29 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112367/#review38906 --- The change seems reasonable (but keep in mind it makes one of

Build failed in Jenkins: plasma-framework_master_qt5 #654

2013-08-29 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/654/changes Changes: [sebas] Improve porting scripts -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 2 in workspace