Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review40192 --- Ship it! staging/kservice/src/services/ktraderparsetree.cpp <

Re: Review Request 112730: Make knewstuff build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/ --- (Updated Sept. 17, 2013, 7:29 a.m.) Review request for KDE Frameworks, Alb

Re: Review Request 112730: Make knewstuff build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review40193 --- knewstuff/CMakeLists.txt

Re: Review Request 112730: Make knewstuff build standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112730/#review40194 --- knewstuff/src/downloaddialog.cpp

Re: Review Request 112730: Make knewstuff build standalone

> On Sept. 17, 2013, 8:05 a.m., Chusslove Illich wrote: > > knewstuff/src/downloaddialog.cpp, line 35 > > > > > > Technically it is possible to mix translation frameworks, but I see no > > point > > to that. C

Re: Splitting out a KX11Extras frameworks from KWindowSystems

On 2013-09-16, Martin Graesslin wrote: > The KWindowSystems framework would need to become a tier2 framework and as > it needs to depend on NETwm (X11 implementation uses it and the defines are > used). It would contain: > * KKeyServer > * KWindowEffects (this could also stay in X11Extras) > * K

Re: Re: Splitting out a KX11Extras frameworks from KWindowSystems

On Monday 16 September 2013 13:27:27 Sune Vuorela wrote: > On 2013-09-16, Martin Graesslin wrote: > > The KWindowSystems framework would need to become a tier2 framework and as > > it needs to depend on NETwm (X11 implementation uses it and the defines > > are > > used). It would contain: > > * KK

Re: Review Request 112760: Add test program for KMessageBox methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112760/#review40198 --- This review has been submitted with commit aecf8ae1aa5eba31adc

Re: Review Request 112760: Add test program for KMessageBox methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112760/ --- (Updated Sept. 17, 2013, 9:27 a.m.) Status -- This change has been ma

Re: Review Request 112519: trim KStyle

> On Sept. 17, 2013, 1:37 a.m., Aleix Pol Gonzalez wrote: > > Bump! what's the status of this? waiting for "ship it" :) - Wojciech --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#

Re: Review Request 112547: avoid creating jobs on urls with double slashes

> On Sept. 8, 2013, 1:13 p.m., David Faure wrote: > > Please test https://codereview.qt-project.org/64926, it should make this > > fix unnecessary. > > Aleix Pol Gonzalez wrote: > Quietness suggests that this review can be closed probably. Is that the > case? Yes this should be discarded

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40208 --- staging/frameworkintegration/src/kstyle/kstyle.h

Re: Review Request 112717: Start adopting QCollator

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717/#review40209 --- Ship it! Looks good to me, except for one field which should b

Re: Review Request 112547: avoid creating jobs on urls with double slashes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547/ --- (Updated Sept. 17, 2013, 11:14 a.m.) Status -- This change has been d

Re: Review Request 112681: Tests for KPluginTrader and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/ --- (Updated Sept. 17, 2013, 11:27 a.m.) Review request for KDE Frameworks and

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40211 --- Ship it! Looks good to me now. - Aurélien Gâteau On Sept. 1

Review Request 112772: Create an ecm_mark_as_autotest macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/ --- Review request for Build System and KDE Frameworks. Description --- C

Re: KF5 Update Meeting 2013-w38 Reminder

On Mon, Sep 16, 2013 at 3:27 PM, Àlex Fiestas wrote: > Hi there ! > > Just a quick reminder: > The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm > Barcelona (CEST / UTC+2) time. > > If you want me to do any announcement tomorrow just when the meeting start > either send it as

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Sept. 16, 2013, 12:16 p.m., Fredrik Höglund wrote: > > tier1/kwindowsystem/src/kxutils_p.h, line 49 > > > > > > This statement is no longer true. If the pixmap is not an ARGB32 > > pixmap, the function will c

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/ --- (Updated Sept. 17, 2013, 1:54 p.m.) Review request for KDE Frameworks, Chr

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/#review40233 --- This review has been submitted with commit 808e6625c3964517cb9

Re: Review Request 112730: Make knewstuff build standalone

> On Sept. 17, 2013, 10:05 a.m., Chusslove Illich wrote: > > knewstuff/src/downloaddialog.cpp, line 35 > > > > > > Technically it is possible to mix translation frameworks, but I see no > > point > > to that.

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/ --- (Updated Sept. 17, 2013, 3:49 p.m.) Status -- This change has been ma

Re: Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112680/#review40235 --- This review has been submitted with commit f3cbecc96a8e2824816

Re: Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112680/ --- (Updated Sept. 17, 2013, 3:49 p.m.) Status -- This change has been ma

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112679/#review40234 --- This review has been submitted with commit 96f363e4f7f8b6655df

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112660/ --- (Updated Sept. 17, 2013, 3:49 p.m.) Status -- This change has been ma

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/ --- (Updated Sept. 17, 2013, 5:30 p.m.) Status -- This change has been ma

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review40239 --- This review has been submitted with commit 032cb2b94a1463f53f9

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112772/#review40240 --- The macro does more than the name implies, additionally to mark

Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/ --- Review request for KDE Frameworks and Alexander Neundorf. Description

ki18n

1. ki18n exists in both tier2 and staging 2. kunitconversion (tier2) depends on ki18n(tier2) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/#review40245 --- This review has been submitted with commit 75dddc4c6b6e5cbc049

Re: Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112662/ --- (Updated Sept. 17, 2013, 9:06 p.m.) Status -- This change has been ma

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really familiar with most of the affected code, and

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

> On Sept. 17, 2013, 8:26 p.m., Alexander Neundorf wrote: > > The macro does more than the name implies, additionally to marking it as > > test it also actually adds the test. > > So I'd prefer a different name. > > > > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE

Re: Review Request 112717: Start adopting QCollator

> On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: > > Thanks for your cool work on QCollator! It will be interesting to see how > > much we can gain by using QCollatorSortKey for sorting large sets of > > QStrings :-) > > > > I'm not really familiar with most of the affected code, and

Re: Review Request 112772: Create an ecm_mark_as_autotest macro

> On Sept. 17, 2013, 6:26 p.m., Alexander Neundorf wrote: > > The macro does more than the name implies, additionally to marking it as > > test it also actually adds the test. > > So I'd prefer a different name. > > > > Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE

Re: Review Request 112519: trim KStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112519/#review40252 --- Ship it! What exactly is the plan for "KStyle 3/3"? I see many

Re: Fwd: Print Dialog - next steps

On Monday 09 September 2013 14:07:31 Martin Klapetek wrote: > 5) In KF5 the KdePrintDialog stuff can either be removed entirely, or more > conservatively modified to no longer insert the extra KDE Cups widgets and > modifications so they don't appear twice. Discuss with Kevin and David > which the

Re: Review Request 112681: Tests for KPluginTrader and friends

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681/#review40255 --- seems to be the old patch again. No _data() method in here. -