Review Request 112926: Prepare ktextwidgets' cmake for splitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112926/ --- Review request for KDE Frameworks. Description --- Adds * find_packa

Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

CMake-gods, can you confirm the below? (It's inconsistent with my understanding, and how we've done it in the past months, I'd like to have a specialist opinion before going around and changing every single CMakeLists.txt in Plasma.) Thanks, -- sebas -- Forwarded Message --

Re: QTimeZone merged for 5.2

On 24 September 2013 19:24, Kevin Ottens wrote: > On Tuesday 24 September 2013 19:03:21 John Layt wrote: >> I'll do some analysis on the use of all the widgets and what ones are >> worth keeping, and look at the Qt widgets to see if they're worth >> switching to, if not before then at Qt Dev Days

Re: Review Request 112926: Prepare ktextwidgets' cmake for splitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112926/#review40737 --- Ship it! staging/ktextwidgets/autotests/CMakeLists.txt

Re: Review Request 112900: Prepare KDNSSD for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/#review40739 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 11:1

Re: Review Request 112919: Prepare KParts for the move

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112919/#review40740 --- Ship it! One thing to fix kparts/CMakeLists.txt

Re: Review Request 112902: Start cleanup for kdewebkit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40742 --- kdewebkit/CMakeLists.txt

Re: Review Request 112902: Start cleanup for kdewebkit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40743 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 11:1

Re: Review Request 112926: Prepare ktextwidgets' cmake for splitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112926/#review40744 --- This review has been submitted with commit 7869cf787e5d6dfb1f9

Re: Review Request 112926: Prepare ktextwidgets' cmake for splitting

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112926/ --- (Updated Sept. 25, 2013, 10:59 a.m.) Status -- This change has been m

Review Request 112927: Move KTextWidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112927/ --- Review request for KDE Frameworks. Description --- Moving to tier3 as

Re: Review Request 112927: Move KTextWidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112927/ --- (Updated Sept. 25, 2013, 11:38 a.m.) Review request for KDE Frameworks.

Re: Templates for frameworks CMake files

On Tuesday 24 September 2013 16:58:36 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Hi, > > > > I have been playing around with itemviews CMake files and put together > > some templates for the top level CMakeLists.txt and *Config.cmake.in. You > > can find them attached there. Any one against

Re: Review Request 112927: Move KTextWidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112927/#review40751 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 25, 2013, 1

Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. D

Re: Review Request 112927: Move KTextWidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112927/#review40752 --- This review has been submitted with commit 27a3076833ec0be4c81

Re: Review Request 112927: Move KTextWidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112927/ --- (Updated Sept. 25, 2013, 11:42 a.m.) Status -- This change has been m

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday 25 September 2013 11:22:57 Sebastian Kügler wrote: > CMake-gods, can you confirm the below? (It's inconsistent with my > understanding, and how we've done it in the past months, I'd like to have a > specialist opinion before going around and changing every single > CMakeLists.txt in Pl

Review Request 112929: Remove KPluginVerificationData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112929/ --- Review request for KDE Frameworks and David Faure. Description --- Re

Re: Review Request 112929: Remove KPluginVerificationData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112929/ --- (Updated Sept. 25, 2013, 11:50 a.m.) Review request for KDE Frameworks and

Re: Review Request 112929: Remove KPluginVerificationData

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112929/ --- (Updated Sept. 25, 2013, 11:50 a.m.) Review request for KDE Frameworks and

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/#review40754 --- This review has been submitted with commit 6a74b477fd13b7fa771

Re: Review Request 112816: Do not use internal headers in kcolorutilsdemo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112816/ --- (Updated Sept. 25, 2013, 11:56 a.m.) Status -- This change has been m

Review Request 112931: Prepare kconfigwidgets for tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112931/ --- Review request for KDE Frameworks. Description --- These changes make

Re: Review Request 112915: Fix kcrash standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/#review40758 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 1:39

Re: Review Request 112915: Fix kcrash standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/ --- (Updated Sept. 25, 2013, 12:41 p.m.) Status -- This change has been m

Re: Review Request 112915: Fix kcrash standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/#review40759 --- This review has been submitted with commit 0da0db25700305dcdd2

Review Request 112932: Update superbuild to include all tiered libraries

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/ --- Review request for KDE Frameworks. Description --- Add missing find_

Re: Review Request 112932: Update superbuild to include all tiered libraries

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/#review40764 --- Looks good to me, not adding the shipit because I'm clueless ab

Re: Review Request 112919: Prepare KParts for the move

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112919/#review40768 --- This review has been submitted with commit 9697ef3985110aa6ae7

Re: Review Request 112919: Prepare KParts for the move

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112919/ --- (Updated Sept. 25, 2013, 3:11 p.m.) Status -- This change has been ma

Re: QTimeZone merged for 5.2

> I've been > talking to the QML component guys and they will have a new calendar > component for 5.3 that they need QCalendarSystem for as well. Hi John, What you said there sounds very interesting to me! Do you have any link for me where i can read about that or where current code in that a

Re: Review Request 112900: Prepare KDNSSD for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/#review40769 --- This review has been submitted with commit 18f9e540fd45a2514cb

Re: Review Request 112900: Prepare KDNSSD for moving

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/ --- (Updated Sept. 25, 2013, 3:21 p.m.) Status -- This change has been ma

Review Request 112935: Move KPrintDialog into KPrintUtils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- Review request for KDE Frameworks and John Layt. Description --- Move

Build failed in Jenkins: kdelibs_frameworks_qt5 #1266

See Changes: [aleixpol] Prepare KParts for the move [aleixpol] Copy paste error [aleixpol] Prepare KDNSSD for moving -- [...truncated 16224 lines...] [ 80%] Building CXX object staging/xmlgu

Re: Review Request 112902: Start cleanup for kdewebkit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40770 --- This review has been submitted with commit 0b8576352e9a8f161ef

Re: Review Request 112902: Start cleanup for kdewebkit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40771 --- This review has been submitted with commit 034d9987b24f858f3b6

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/#review40772 --- staging/kde4attic/src/kdeprintdialog.h

Re: Review Request 112902: Start cleanup for kdewebkit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/ --- (Updated Sept. 25, 2013, 3:31 p.m.) Status -- This change has been ma

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday 25 September 2013 12:04:11 Aurélien Gâteau wrote: > On Wednesday 25 September 2013 11:22:57 Sebastian Kügler wrote: > > CMake-gods, can you confirm the below? (It's inconsistent with my > > understanding, and how we've done it in the past months, I'd like to have > > a > > specialist o

Build failed in Jenkins: kdelibs_frameworks_qt5 #1267

See Changes: [aleixpol] Add missing dependency in KDNSSD [aleixpol] Remove unused include [aleixpol] Convert include into forward declaration [aleixpol] Start cleanup for kdewebkit -- [...tr

Build failed in Jenkins: kdelibs_frameworks_qt5 #1268

See Changes: [aleixpol] fix kdewebkit compilation -- [...truncated 16169 lines...] [ 81%] Building CXX object staging/kio/autotests/CMakeFiles/krununittest.dir/krununittest.cpp.o

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wed, Sep 25, 2013 at 5:42 PM, Aurélien Gâteau wrote: > On Wednesday 25 September 2013 12:04:11 Aurélien Gâteau wrote: > > On Wednesday 25 September 2013 11:22:57 Sebastian Kügler wrote: > > > CMake-gods, can you confirm the below? (It's inconsistent with my > > > understanding, and how we've d

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:48 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kdelibs_frameworks_qt5 #1269

See Changes: [mklapetek] Temporarily partially revert 6ea7758c to fix build -- [...truncated 16186 lines...] Linking CXX executable ktoolbartest Linking CXX executable krulertest [ 82%] Buildin

Re: Review Request 112935: Move KPrintDialog into KPrintUtils

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112935/ --- (Updated Sept. 25, 2013, 4:50 p.m.) Review request for KDE Frameworks and

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013/9/25 Aurélien Gâteau : > The alternative syntax: ${KConfigCore_LIBRARIES} would work in both cases, but > it is more error prone: any typo in the variable name causes the variable to > be expanded to an empty string, making it more difficult to debug, whereas > using target names provide more

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wed, Sep 25, 2013 at 6:52 PM, Nicolás Alvarez wrote: > 2013/9/25 Aurélien Gâteau : > > The alternative syntax: ${KConfigCore_LIBRARIES} would work in both > cases, but > > it is more error prone: any typo in the variable name causes the > variable to > > be expanded to an empty string, making i

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

Aurélien, Thanks for the detailed explanation. Now the questions become: a) when will that cmake feature be in a released version of cmake? b) what should we do to get frameworks ready if not making them build by themself and part of kdelibs both? I guess I can go rename my private headers to _

Build failed in Jenkins: kdelibs_frameworks_qt5 #1270

See Changes: [aleixpol] More preparing KDEWebKit for moving to its own tier [aleixpol] fix KParts build -- [...truncated 30543 lines...] -- Installing:

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday 25 September 2013, Aurélien Gâteau wrote: ... > Unfortunately, ALIAS is a new feature of the add_library command, which is > only available in cmake git for now and will be in 2.8.12. Therefore we > cannot use this solution right now. This means we can't have standalone > builds of tie

Re: Review Request 112932: Update superbuild to include all tiered libraries

> On Sept. 25, 2013, 2:03 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me, not adding the shipit because I'm clueless about > > superbuild. > > > > Why do we need to specify the dependencies from superbuild? Shouldn't they > > depend on the Config.cmake files? You mean after "DEPENDS" ?

Review Request 112942: Move KDNSSD to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- Review request for KDE Frameworks. Description --- Moves KDNSSD to ti

Review Request 112940: Move all kio tests to the appropriate location

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112940/ --- Review request for KDE Frameworks. Description --- Read title Diffs

Re: Review Request 112932: Update superbuild to include all tiered libraries

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932/#review40789 --- Is anyone really using superbuild? - Albert Astals Cid On S

Review Request 112943: Move KParts to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112943/ --- Review request for KDE Frameworks. Description --- Not much else, onl

Review Request 112944: Move KDEWebKit to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112944/ --- Review request for KDE Frameworks. Description --- Moves KDEWebKit to

Re: Review Request 112942: Move KDNSSD to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/#review40792 --- Isn't part of the "done" to have unit tests? - Martin Klapetek

Re: Making KDocTools independent of KArchive

On Wednesday 25 September 2013, Albert Astals Cid wrote: > El Dimarts, 24 de setembre de 2013, a les 14:09:57, Kevin Ottens va escriure: > > On Tuesday 24 September 2013 13:48:55 Albert Astals Cid wrote: > > > El Dimarts, 24 de setembre de 2013, a les 08:49:20, Kevin Ottens va > > > > escriure: >

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

Jeremy Whiting wrote: > Aurélien, > > Thanks for the detailed explanation. Now the questions become: > > a) when will that cmake feature be in a released version of cmake? Impossible to know. I expected it would be released weeks ago. I guess it will be a few weeks more. > b) what should we

Re: Templates for frameworks CMake files

Aurélien Gâteau wrote: >> ECM and Qt version bumps are not as much an issue as the cmake one. The >> ECM and Qt version deps are not as likely to change. > > I don't understand why you think specifying the cmake version is an issue: > it should be easy to update the template when this happens, is

Re: Templates for frameworks CMake files

Stephen Kelly wrote: >>> Simplify by putting NO_MODULE before REQUIRED and removing COMPONENTS: >>> >>>find_package(Qt5 ${REQUIRED_QT_VERSION} NO_MODULE REQUIRED Widgets) >> >> Done. > > Are you sure? The reviewboard shows otherwise. > Ah, I was wrong here. I was looking at the KF5 line. Simpl

Re: Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112921/ --- (Updated Sept. 25, 2013, 8:21 p.m.) Review request for KDE Frameworks. C

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40802 --- Also consider replacing FooBar with @FooBar@ or something that

[kdelibs/frameworks] /: Only public dependencies should be found by config files.

Git commit bdae65595d679fb982ae67ea3d47c34c4dcc97cb by Stephen Kelly. Committed on 25/09/2013 at 21:25. Pushed by skelly into branch 'frameworks'. Only public dependencies should be found by config files. Also, in target_link_libraries lines, only 'leaf' nodes should be added. CCMAIL: kde-framew

Build failed in Jenkins: kdelibs_frameworks_qt5 #1271

See Changes: [steveire] Only public dependencies should be found by config files. -- [...truncated 30544 lines...] -- Installing:

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday, September 25, 2013 17:42:35 Aurélien Gâteau wrote: > Replying to myself: this topic was discussed on IRC with Stephen Kelly, the > result is the following: > > # Short version > > 1. To use the "Foo" framework within another framework whose code is in > kdelibs, use "Foo": > >

Re: Review Request 112942: Move KDNSSD to tier2

> On Sept. 25, 2013, 6:45 p.m., Martin Klapetek wrote: > > Isn't part of the "done" to have unit tests? I'm not a DNSSD developer, I don't know what would apply as a useful test. I agree that it's a bad thing for a framework not to be unit tested though, maybe we can create a tier for those mo

Jenkins build became unstable: plasma-framework_master_qt5 #768

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : plasma-framework_master_qt5 #769

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112896: Rework NETWM classes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/#review40840 --- I'm just going to point out something I know you already know s

Re: Review Request 112896: Rework NETWM classes

> On Sept. 26, 2013, 4:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. my aim was to write the unit test and that was the big junk of