Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112950/ --- Review request for KDE Frameworks and Valentin Rusu. Description ---

Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/ --- Review request for KDE Frameworks. Description --- Removed usage of K

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/ --- (Updated Sept. 26, 2013, 11:11 a.m.) Review request for KDE Frameworks.

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 1:28 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40855 --- template/CMakeLists.txt

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40856 --- You seem to be doing 3 different things here. Please make sure

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 2:05 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 112928: Template files for frameworks

> On Sept. 26, 2013, 1:55 p.m., Stephen Kelly wrote: > > template/CMakeLists.txt, line 16 > > > > > > Can this be changed from > > > > REQUIRED MODULE COMPONENTS > > > > to > > > > MO

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday 25 September 2013 19:13:00 Alexander Neundorf wrote: > On Wednesday 25 September 2013, Aurélien Gâteau wrote: > ... > > > Unfortunately, ALIAS is a new feature of the add_library command, which is > > only available in cmake git for now and will be in 2.8.12. Therefore we > > cannot u

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday 25 September 2013 18:08:31 you wrote: [snip] > Do we know why do we need the KF5:: namespacing? I guess it is to avoid confusion: some frameworks are prefixed with 'k' but others are not (frameworkintegration, itemmodels, itemviews, solid, sonnet, threadweaver, xmlgui). It's true w

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Wednesday 25 September 2013 13:52:01 Nicolás Alvarez wrote: > 2013/9/25 Aurélien Gâteau : > > The alternative syntax: ${KConfigCore_LIBRARIES} would work in both cases, > > but it is more error prone: any typo in the variable name causes the > > variable to be expanded to an empty string, making

[kdelibs/frameworks] /: Use a single version argument to ecm_setup_version.

Git commit b77fa776ae937e2489a40be95c1e397d400a965e by Stephen Kelly. Committed on 26/09/2013 at 12:52. Pushed by skelly into branch 'frameworks'. Use a single version argument to ecm_setup_version. Note: This requires the latest ecm master. CCMAIL: kde-frameworks-devel@kde.org M +1-1d

KParts / KIOConfig: Please unbreak plasma-framework

Hi, The recent changes in KParts and KIO have caused plasma-framework to fail building. First, KParts is not found, adding a find_package call makes it complain about KIOCore not being found. I've tried adding a KIOCoreConfig.cmake, but didn't manage to make it working. After about an hour of

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40861 --- template/CMakeLists.txt

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 3:13 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 112928: Template files for frameworks

> On Sept. 26, 2013, 2:57 p.m., Stephen Kelly wrote: > > template/CMakeLists.txt, line 26 > > > > > > I've changed this signature in ecm to take a single version component > > instead of 3. > > > > Please

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40866 --- > Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION? Ye

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

> On Sept. 26, 2013, 11:56 a.m., Stephen Kelly wrote: > > You seem to be doing 3 different things here. Please make sure to do each > > one in a separate commit. Alright. I'll split it into 3 different commits. Do you want 3 different reviews as well? Or will this one do? - Vishesh ---

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

> On Sept. 26, 2013, 11:56 a.m., Stephen Kelly wrote: > > You seem to be doing 3 different things here. Please make sure to do each > > one in a separate commit. > > Vishesh Handa wrote: > Alright. I'll split it into 3 different commits. Do you want 3 different > reviews as well? Or will t

[kdelibs/frameworks] staging/kde4support: Temporarily partially revert 6ea7758c to fix build

Git commit 13fa80e6a6198a440ae075fa959f8daccd516d87 by Martin Klapetek. Committed on 25/09/2013 at 16:41. Pushed by mklapetek into branch 'frameworks'. Temporarily partially revert 6ea7758c to fix build There seems to be a regression with recent Qt5 moc which breaks the build with this definition

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

Is there anything preventing us from using the ALIAS target right now? It's in the git version. The build guide say to get cmake from git. kdesrc-build gets it from git, and build.kde.org uses git latest. I just set KWindowSystem to have an alias and tried building knotifications. It worked beaut

kcmutils linking issues

Hello, I am trying to link kcmutils to kwincompositing (kwincompositing is the new version of the KWin Effects KCM). A few days before everything was working fine, until the kdeqt5staging was being removed from the kdelibs. So now i am not able to link the kcmutils with the kwincompositing. Thi

Re: Review Request 112943: Move KParts to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112943/#review40871 --- Ship it! Looks good, compiles so ship it. - Àlex Fiestas On

Re: Review Request 112944: Move KDEWebKit to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112944/#review40872 --- Ship it! Looks good, frameworks compiles so ship it! - Àlex F

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40873 --- Ship it! Looks good, send it when it's split as stephen suggue

[kdelibs/frameworks] /: Find KParts in KDELibs4Config.cmake

Git commit aac41bc93595a0f341886692fba48717a1a9e2a9 by Stephen Kelly. Committed on 26/09/2013 at 14:22. Pushed by skelly into branch 'frameworks'. Find KParts in KDELibs4Config.cmake CCMAIL: kde-frameworks-devel@kde.org M +3-1KDELibs4Config.cmake http://commits.kde.org/kdelibs/aac41bc9

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Thursday 26 September 2013 03:10:08 David Edmundson wrote: > Is there anything preventing us from using the ALIAS target right now? > > It's in the git version. The build guide say to get cmake from git. > kdesrc-build gets it from git, and build.kde.org uses git latest. +1 for me. That would

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Thu, Sep 26, 2013 at 5:10 AM, David Edmundson wrote: > Is there anything preventing us from using the ALIAS target right now? > > It's in the git version. The build guide say to get cmake from git. > kdesrc-build gets it from git, and build.kde.org uses git latest. > > I just set KWindowSystem

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 4:36 p.m.) Review request for KDE Frameworks, Ale

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/ --- (Updated Sept. 26, 2013, 4:37 p.m.) Review request for KDE Frameworks, Kev

Re: Review Request 112928: Template files for frameworks

> On Sept. 26, 2013, 3:43 p.m., Stephen Kelly wrote: > > > Maybe KF5_SELF_VERSION could be shortened to KF5_VERSION? > > > > Yes, that might be better. > > > > The patch looks good to me now. The above naming issue and the other > > re-ordering issue are up to your preferences. > > > > This

Re: Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Thursday 26 September 2013 03:10:08 David Edmundson wrote: > Is there anything preventing us from using the ALIAS target right now? yes it got discussed a short time ago[1] and the result of the discussion was "no" Cheers Martin [1] See thread with message id starting on Aug, 20th. signatu

Re: Review Request 112943: Move KParts to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112943/#review40876 --- This review has been submitted with commit 78a6b7d77c0d8db18c6

Re: Review Request 112943: Move KParts to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112943/ --- (Updated Sept. 26, 2013, 2:59 p.m.) Status -- This change has been ma

Re: Review Request 112944: Move KDEWebKit to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112944/ --- (Updated Sept. 26, 2013, 3:06 p.m.) Status -- This change has been ma

Re: Review Request 112944: Move KDEWebKit to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112944/#review40877 --- This review has been submitted with commit 58676e03ba6f2bf09f7

Re: Review Request 112940: Move all kio tests to the appropriate location

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112940/#review40879 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 26, 2013, 3

Re: [kdelibs/frameworks] /: Find KParts in KDELibs4Config.cmake

On Thursday, September 26, 2013 14:23:01 Stephen Kelly wrote: > Git commit aac41bc93595a0f341886692fba48717a1a9e2a9 by Stephen Kelly. > Committed on 26/09/2013 at 14:22. > Pushed by skelly into branch 'frameworks'. > > Find KParts in KDELibs4Config.cmake This seems to fix my build. Thanks, Steve!

Re: Review Request 112940: Move all kio tests to the appropriate location

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112940/ --- (Updated Sept. 26, 2013, 3:08 p.m.) Review request for KDE Frameworks. C

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Thursday 26 September 2013 16:38:31 Martin Gräßlin wrote: > On Thursday 26 September 2013 03:10:08 David Edmundson wrote: > > Is there anything preventing us from using the ALIAS target right now? > > yes it got discussed a short time ago[1] and the result of the discussion > was "no" Yes, ple

Re: Review Request 112940: Move all kio tests to the appropriate location

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112940/#review40881 --- This review has been submitted with commit 7f1663a47ed26dda435

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/#review40882 --- This review has been submitted with commit 7a3114156a514287416

Re: Review Request 112957: Move KMimeTypeChooser from kio to KWidgetAddons

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112957/ --- (Updated Sept. 26, 2013, 4:13 p.m.) Status -- This change has been ma

Re: Review Request 112940: Move all kio tests to the appropriate location

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112940/ --- (Updated Sept. 26, 2013, 4:13 p.m.) Status -- This change has been ma

Build failed in Jenkins: kdelibs_frameworks_qt5 #1280

See Changes: [me] Move all kio tests to the appropriate location [me] KMimeTypeChooser: Replace i18n calls with QApp::tr() [me] KMimeTypeChooser: Replace all char* strings with QStringLiteral [me] KMimeTypeChooser: Remove KConfig u

Re: Review Request 112838: KIconThemes move to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112838/#review40885 --- This review has been submitted with commit a62e363c90e31d64193

Re: Review Request 112838: KIconThemes move to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112838/ --- (Updated Sept. 26, 2013, 4:40 p.m.) Status -- This change has been ma

Build failed in Jenkins: kdelibs_frameworks_qt5 #1281

See Changes: [afiestas] Add finders for KIconThemes [afiestas] Document dependencies in KIconThemes [afiestas] Move KIconThemes to Tier3 -- [...truncated 4264 lines...] [ 42%] [ 42%] [ 42%] B

Re: Review Request 112829: Move XMLGUI to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/#review40886 --- This review has been submitted with commit 45cc2bd0a4b7ae01009

Build failed in Jenkins: kdelibs_frameworks_qt5 #1282

See Changes: [kde] Remove unused include [kde] Remove unused include -- [...truncated 16011 lines...] In file included from

Re: Review Request 112829: Move XMLGUI to Tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112829/ --- (Updated Sept. 26, 2013, 5:24 p.m.) Status -- This change has been ma

Re: Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112950/#review40891 --- Ship it! Ship It! - Valentin Rusu On Sept. 26, 2013, 8:13 a

Re: Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112950/#review40892 --- This review has been submitted with commit 61873dc8f55047f6bba

Re: Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112950/ --- (Updated Sept. 26, 2013, 8:16 p.m.) Status -- This change has been ma

Re: Review Request 112928: Template files for frameworks

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112928/#review40893 --- template/CMakeLists.txt

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

On Thursday 26 September 2013, Aurélien Gâteau wrote: > On Wednesday 25 September 2013 18:08:31 you wrote: > [snip] > > > Do we know why do we need the KF5:: namespacing? > > I guess it is to avoid confusion: some frameworks are prefixed with 'k' but > others are not (frameworkintegration, itemmo

Re: Review Request 112928: Template files for frameworks

> On Sept. 26, 2013, 8:27 p.m., Alexander Neundorf wrote: > > template/CMakeLists.txt, line 22 > > > > > > The idea here was that you can simply list all required KF5 frameworks > > in one find_package() call: > >

Re: [kdelibs/frameworks] staging/xmlgui/src: Document XML-GUI dependencies

Àlex Fiestas wrote: > +Qt5::Widgets#QWidget is used everywhere At least this is redundant. > +KConfigWidgets #KStandardAction, KToggleAction... Please review. Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: [kde-runtime/frameworks-scratch] /: Search and link to KCMUtils

Hrvoje Senjan wrote: > Pushed by hrvojes into branch 'frameworks-scratch'. Why are some repos getting 'frameworks-scratch' branches instead of just 'frameworks' ? Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org htt

Re: [kdelibs/frameworks] staging/kio/src/widgets: Make KIOWidgets link against KWidgetsAddons as KEditListWidget is used

David Edmundson wrote: > Make KIOWidgets link against KWidgetsAddons as KEditListWidget is used > KWidgetsAddons is already a dependency of KIOWidgets via KCompletion. http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=bdae65595d67 This should not be needed. Did you need it somehow? If you did

Re: [kdelibs/frameworks] staging/kio/src/widgets: Make KIOWidgets link against KWidgetsAddons as KEditListWidget is used

We had compile failures without it, http://build.kde.org/job/kdelibs_frameworks_qt5/1282/console This patch makes it compile. I think it is needed because keditlistwidget is in the public headers, so an app using KIOWidgets (in this case the kiowidgets tests, which is the part failing) needs to kn

Re: Review Request 112896: Rework NETWM classes

> On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: > > I'm just going to point out something I know you already know since we've > > discussed it many times; > > that an xcb port of the NETWM classes already exists in a branch. > > Martin Gräßlin wrote: > my aim was to write the unit te