Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2

2013-10-10 Thread Martin Gräßlin
On Wednesday 09 October 2013 22:18:26 nerdopolis wrote: Hi. I am trying to compile plasma-framework against a qt5 that is ready for Wayland, which does not have Desktop GL enabled. Wayland does not require OpenGL ES. This is a common misunderstanding due to first Weston versions requiring

Re: Review Request 113148: Move and clean KBuildsycoca to KService

2013-10-10 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113148/ --- (Updated Oct. 10, 2013, 10:04 a.m.) Review request for KDE Frameworks.

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41496 --- Ship it! With the two issues I've pointed out, this patch can

Re: Review Request 113154: Remove KFileMetaDataWidget and friends

2013-10-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113154/ --- (Updated Oct. 10, 2013, 12:56 p.m.) Review request for KDE Frameworks.

Re: Review Request 113050: Use enum for KMessageBox return types

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/#review41507 --- This review has been submitted with commit

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113174/ --- (Updated Oct. 10, 2013, 1:30 p.m.) Review request for KDE Frameworks.

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-10 Thread Aleix Pol Gonzalez
On Oct. 9, 2013, 4:19 p.m., David Edmundson wrote: kjsembed/kjscmd/kjscmd.cpp, line 78 http://git.reviewboard.kde.org/r/113174/diff/1/?file=200020#file200020line78 this seems to break whitespace for no reason? - Aleix ---

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-10 Thread Aleix Pol Gonzalez
On Oct. 9, 2013, 5:22 p.m., Kevin Ottens wrote: kjsembed/examples/kjsconsole/console.cpp, line 35 http://git.reviewboard.kde.org/r/113174/diff/1/?file=199962#file199962line35 Hm actually surprising, where does this include come from? KJS, JSVariableObject.h is where GlobalObject is

Re: update your cmake!

2013-10-10 Thread Aurélien Gâteau
On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Oh... this means we can now make use of ALIAS targets and build truly standalone frameworks \o/ Aurélien

Re: libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-10 Thread Alexander Neundorf
On Wednesday 09 October 2013, Sebastian Kügler wrote: Hi, While porting libnm-qt to Qt5, I'm running into the following problem when building the tests. I've not seen this error before, and I'd like advice how to fix it. [ 59%] Building CXX object

Re: update your cmake!

2013-10-10 Thread Alexander Neundorf
On Thursday 10 October 2013, Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Doesn't it error out in cmake_minimum_required() ? If not, I'd suggest that somebody takes care of handling this

Re: libnm-qt Qt5 port: -fPIC or fPIE needed?

2013-10-10 Thread Stephen Kelly
Sebastian Kügler wrote: Could anyone give me a hint how to fix this? You are apparently using empty variables like ${QT_QTCORE_LIBRARY}. Those are not defined in Qt 5. -target_link_libraries(NetworkManagerQt ${MODEMMANAGERQT_LIBRARY} ${QT_QTCORE_LIBRARY} ${QT_QTDBUS_LIBRARY}

Re: update your cmake!

2013-10-10 Thread Stephen Kelly
Alexander Neundorf wrote: On Thursday 10 October 2013, Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Doesn't it error out in cmake_minimum_required() ? If not, I'd suggest that somebody

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112918/#review41528 --- This review has been submitted with commit

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/ --- (Updated Oct. 10, 2013, 6:08 p.m.) Review request for KDE Frameworks.

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41533 --- This review has been submitted with commit

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 10, 2013, 6:29 p.m.) Status -- This change has been

Re: Review Request 113155: Port all kde4_add_unit_test uses

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113155/#review41535 --- kfile/tests/CMakeLists.txt

Re: kio-related build error in plasma-framework

2013-10-10 Thread Sebastian Kügler
On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote: I'm getting a build error in a few places in plasma-framework, kio isn't found. I can't seem to figure out why, maybe someone who has a better overview of what in KIO is where, and what I need to tell cmake to figure this out? The

Re: update your cmake!

2013-10-10 Thread Stephen Kelly
Aurélien Gâteau wrote: On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors. Oh... this means we can now make use of ALIAS targets and build truly standalone

Re: update your cmake!

2013-10-10 Thread Aleix Pol
On Fri, Oct 11, 2013 at 2:43 AM, Stephen Kelly steve...@gmail.com wrote: Aurélien Gâteau wrote: On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote: Hi, In order to build KF5 and Plasma2 code, you have to update your cmake to 2.8.12. Otherwise, you'll get build errors.