---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113301/
---
Review request for KDE Frameworks and Martin Gräßlin.
Repository: kdelibs
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote:
KDE5PORTING.html, lines 290-295
http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290
This is not valid anymore. It should now be
qCdebug/warning/notice/... and with a category. I think it;s best to just
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/#review41860
---
There are couple issues still, I pointed only bunch of them as
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote:
KDE5PORTING.html, lines 290-295
http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290
This is not valid anymore. It should now be
qCdebug/warning/notice/... and with a category. I think it;s best to just
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote:
KDE5PORTING.html, lines 290-295
http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290
This is not valid anymore. It should now be
qCdebug/warning/notice/... and with a category. I think it;s best to just
On Oct. 17, 2013, 1:16 a.m., Aleix Pol Gonzalez wrote:
tier1/kidletime/CMakeLists.txt, line 5
http://git.reviewboard.kde.org/r/113276/diff/1/?file=202040#file202040line5
really needed?
I think it helps structuring the file, especially if it gets more widespread.
- Aurélien
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113300/#review41874
---
Ship it!
Looks good. Feel free to push your changes to these
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113276/
---
(Updated Oct. 17, 2013, 12:04 p.m.)
Review request for KDE Frameworks and
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote:
KDE5PORTING.html, lines 290-295
http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290
This is not valid anymore. It should now be
qCdebug/warning/notice/... and with a category. I think it;s best to just
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113276/#review41881
---
Ship it!
Ship It!
- Stephen Kelly
On Oct. 17, 2013, 10:04
Hi,
Today I tried to ensure KI18n could build standalone, but I found out it
builds a plugin library, ktranscript, which requires KJS internals: it
generates a lookup table with a Perl script from KJS and #include a bunch of
KJS uninstalled headers (see ktranscript.cpp).
What should be done
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113302/
---
Review request for KDE Frameworks, David Faure and Kevin Ottens.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113301/
---
(Updated Oct. 17, 2013, 3:04 p.m.)
Status
--
This change has been
On Oct. 15, 2013, 1:51 p.m., Aurélien Gâteau wrote:
Standalone build fails here with this message:
-- Found KF5: /home/aurelien/opt/kf5/share/ECM/find-modules/FindKF5.cmake
(found suitable version 5.0.0, minimum required is 5.0.0) found
components: CMake Compiler InstallDirs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113301/#review41895
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113276/
---
(Updated Oct. 17, 2013, 5:33 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/
---
(Updated Oct. 17, 2013, 4 p.m.)
Review request for KDE Frameworks and
On Oct. 17, 2013, 4:46 a.m., Martin Klapetek wrote:
tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 183
http://git.reviewboard.kde.org/r/113298/diff/1/?file=202295#file202295line183
Spaces inside - KDirWatch *, bool
I added the parameter names to kdirwatch_p.h too.
On Oct. 17,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/
---
(Updated Oct. 17, 2013, 4:05 p.m.)
Review request for KDE Frameworks and
Hello!
I want to compile kde library without building tests or auto tests.
Reason behind this is I want to speed up compiling process.. Martin
Gräßlin suggested me to use
-DKDE4_BUILD_TESTS=FALSE -DBUILD_TESTING=FALSE
cmake options but this options are not working, with this option cmake
fails
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/#review41907
---
Good job! I think this can go in, but I'd like someone else
On Oct. 17, 2013, 4:27 p.m., Martin Klapetek wrote:
tier1/kcoreaddons/src/lib/io/kdirwatch.cpp, line 1225
http://git.reviewboard.kde.org/r/113298/diff/3/?file=202348#file202348line1225
I think this could be better as uncommenting the variable and using
Q_UNUSED (and moving the *
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113298/
---
(Updated Oct. 17, 2013, 4:53 p.m.)
Review request for KDE Frameworks and
On Oct. 17, 2013, 7:27 p.m., Martin Klapetek wrote:
tier1/kcoreaddons/src/lib/io/kdirwatch_p.h, line 199
http://git.reviewboard.kde.org/r/113298/diff/3/?file=202349#file202349line199
why did you choose _path instead of just path?
Nicolás Alvarez wrote:
Because that's what
On Oct. 16, 2013, 12:15 p.m., John Layt wrote:
Wow, there sure is a lot of code in there catering for all the possible
corner cases :-) QTimeZone has a lot less places it checks, so I'll need
to do an in-depth comparison, but given Qt5 will only support modern
distros I think most
On Thu, Oct 17, 2013 at 8:23 AM, Bhushan Shah bhus...@gmail.com wrote:
Hello!
I want to compile kde library without building tests or auto tests.
Reason behind this is I want to speed up compiling process.. Martin
Gräßlin suggested me to use
-DKDE4_BUILD_TESTS=FALSE -DBUILD_TESTING=FALSE
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113260/
---
(Updated Oct. 17, 2013, 9:13 p.m.)
Review request for KDE Runtime, KDE
On 17 October 2013 01:51, Aleix Pol aleix...@kde.org wrote:
Hi,
I was trying to port some application to Qt/KF5, then I realized that I
didn't know how to port KLocale::formatByteSize. I don't see anything in
QLocale for this, so I feel a bit stuck. Also I don't see any information in
28 matches
Mail list logo
