Jenkins build is back to stable : kdelibs_stable #878

2013-10-30 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/878/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-10-30 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/#review42696 --- for some reason the cmake magic that is supposed to ensure the

Jenkins build became unstable: kdelibs_stable #879

2013-10-30 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/879/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113503: make dbus dependency optional in JobWidgets

2013-10-30 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113503/ --- (Updated Oct. 30, 2013, 10:08 a.m.) Review request for KDE Frameworks,

cmake and linking issues

2013-10-30 Thread Giorgos Tsiapaliokas
Hello, I have came across to some buildsystem issues. if I don't have the KDE4Support and KDELibs4 with this *exact* order, cmake will fail. Without this order cmake fails in plasma-framework and in plasmate. I have attached the output from cmake. find_package(KDE4Support REQUIRED NO_MODULE)

Re: Review Request 113406: Add a macro to automatically generate forward headers

2013-10-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42700 --- Looks good to me (apart from the expired pastebin links in the

Re: cmake and linking issues

2013-10-30 Thread Stephen Kelly
Giorgos Tsiapaliokas wrote: find_package(KDE4Support REQUIRED NO_MODULE) find_package(KDELibs4 REQUIRED NO_MODULE) So should the find_package be written like this? Is it normal to fail otherwise? There are likely two issues: 1) a bug in cmake fixed in master with

Getting ecm files from the ECM package

2013-10-30 Thread Stephen Kelly
Hello, Soon I will be replacing code like find_package(KF5 REQUIRED CMake Compiler InstallDirs) with include(KDEInstallDirs) include(KDECMakeSettings) include(KDECompilerSettings) As I've said before, it makes no sense that we have to find KF5 in order to build KF5, so I'm going to

Re: Review Request 113498: Fix KCompletion standalone build

2013-10-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113498/ --- (Updated Oct. 30, 2013, 2:26 p.m.) Status -- This change has been

Re: Review Request 113500: make KNewStuff build on its own

2013-10-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/#review42705 --- Patch does not apply here. Can you refresh it to apply on

Re: Review Request 113432: Install FindDBusMenuQt5.cmake

2013-10-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113432/ --- (Updated Oct. 30, 2013, 3:15 p.m.) Status -- This change has been

Review Request 113505: Add unit tests for KTranscript

2013-10-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113505/ --- Review request for KDE Frameworks and Chusslove Illich. Repository:

Re: Review Request 113500: make KNewStuff build on its own

2013-10-30 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/ --- (Updated Oct. 30, 2013, 9:41 a.m.) Review request for KDE Frameworks.

Review Request 113506: Add a BUILD_ALL option to superbuild

2013-10-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- Review request for KDE Frameworks and Alexander Neundorf. Repository:

Re: Using KSSLSettings from KHTML

2013-10-30 Thread David Faure
On Tuesday 29 October 2013 15:22:18 David Edmundson wrote: Currently KHTMLPart uses KSSLSettings from KIOCore It uses the methods: warnOnUnencrypted setWarnOnUnencrypted This class does not have the header exported in KIOCore, so whilst it builds now it will fail when we split. The

Review Request 113507: Use ecm_mark_as_test for test-only targets

2013-10-30 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113507/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113505: Add unit tests for KTranscript

2013-10-30 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113505/#review42710 --- Ship it! Most definitely. The test semantics looks good. I'll

Review Request 113510: Deprecate methods in kimageio

2013-10-30 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113510/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Build failed in Jenkins: plasma-framework_master_qt5 #874

2013-10-30 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/874/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace http://build.kde.org/job/plasma-framework_master_qt5/ws/ Running Prebuild

Build failed in Jenkins: plasma-framework_master_qt5 #875

2013-10-30 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/875/changes Changes: [notmart] removing panels works -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Review Request 113511: Install KSslSettings header

2013-10-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113511/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Getting ecm files from the ECM package

2013-10-30 Thread Alexander Neundorf
On Wednesday 30 October 2013, Stephen Kelly wrote: Hello, Soon I will be replacing code like find_package(KF5 REQUIRED CMake Compiler InstallDirs) with include(KDEInstallDirs) include(KDECMakeSettings) include(KDECompilerSettings) As I've said before, it makes no sense that