Re: Review Request 113500: make KNewStuff build on its own

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/#review43035 --- Ship it! Looks good to me, other than the trailing spaces note

Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113606: Fix standalone build of KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/#review43038 --- This review has been submitted with commit d770f5a672773b8c6d9

Re: Review Request 113606: Fix standalone build of KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/ --- (Updated Nov. 5, 2013, 10:42 a.m.) Status -- This change has been mar

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

> On Nov. 4, 2013, 4:54 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch > > frameworks. For whatever reason, it still installs "libKPty.so.SOVERSION", instead of "libKPty.so.5.0.0". - Christoph

Re: Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/ --- (Updated Nov. 5, 2013, 10:51 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 113609: Fix standalone build of kservice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/#review43040 --- This review has been submitted with commit 5ad3e2ea15d436bf926

Re: Review Request 113609: Fix standalone build of kservice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/ --- (Updated Nov. 5, 2013, 10:53 a.m.) Status -- This change has been mar

Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables

> On Nov. 4, 2013, 4:54 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch > > frameworks. > > Christoph Feck wrote: > For whatever reason, it still installs "libKPty.so.SOVERSION", instead of >

Re: Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/#review43041 --- Ship it! tier1/kcoreaddons/autotests/CMakeLists.txt

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

> On Nov. 2, 2013, 1:42 p.m., Alex Merry wrote: > > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp, lines 73-76 > > > > > > Would it not be marginally more efficient (and still correct) to put > > this test at the

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/ --- (Updated Nov. 5, 2013, 11:04 a.m.) Review request for KDE Frameworks. Re

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

> On Nov. 2, 2013, 1:42 p.m., Alex Merry wrote: > > tier2/kjobwidgets/src/kdialogjobuidelegate.cpp, line 79 > > > > > > This will be application model, I believe. Might be worth mentioning > > the class apidocs (

Re: Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/#review43046 --- This review has been submitted with commit d72bc864157f8ae54b3

Re: Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/ --- (Updated Nov. 5, 2013, 11:15 a.m.) Status -- This change has been mar

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review43047 --- This review has been submitted with commit efbf655b7ab548a0bcc

Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/ --- (Updated Nov. 5, 2013, 11:23 a.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #1586

See Changes: [afiestas] Implement queueing directly in KDialogJobUiDelegate [afiestas] Remove QSKiP in kdirwatch autotest that doesn't seem needed anymore -- [...truncated 4906 lines...] Built

Review Request 113641: Fix standalone build of KIconThemes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113641/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113625: Prepare KHTML for moving into tier4.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/ --- (Updated Nov. 5, 2013, 11:52 a.m.) Review request for KDE Frameworks. Re

Re: Review Request 113406: Add a macro to automatically generate forward headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review43048 --- Ship it! Ship It! - Stephen Kelly On Oct. 29, 2013, 10:52 a

Re: Review Request 113406: Add a macro to automatically generate forward headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review43049 --- This review has been submitted with commit 573907a1dbbf63ca745

Re: Review Request 113406: Add a macro to automatically generate forward headers

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Nov. 5, 2013, 12:09 p.m.) Status -- This change has been mar

Re: Review Request 113625: Prepare KHTML for moving into tier4.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/#review43050 --- Ship it! Looks good to me - Aleix Pol Gonzalez On Nov. 5, 2

Re: Review Request 113634: Generate one autotest per each kdriwatch compiled bakend

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113634/#review43051 --- tier1/kcoreaddons/autotests/CMakeLists.txt

Re: Review Request 113641: Fix standalone build of KIconThemes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113641/#review43054 --- Ship it! Ship It! - Kevin Ottens On Nov. 5, 2013, 11:44 a.m

Re: Review Request 113641: Fix standalone build of KIconThemes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113641/#review43055 --- This review has been submitted with commit 32b03eec265a6ae3c72

Re: Review Request 113641: Fix standalone build of KIconThemes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113641/ --- (Updated Nov. 5, 2013, 1:47 p.m.) Status -- This change has been mark

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113642/ --- (Updated Nov. 5, 2013, 1:54 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/ --- (Updated Nov. 5, 2013, 1:53 p.m.) Review request for KDE Frameworks and Au

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/#review43058 --- tier2/kjobwidgets/src/CMakeLists.txt

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote: > > tier2/kjobwidgets/src/CMakeLists.txt, line 17 > > > > > > You should replace this line with: > > > > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURR

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote: > > tier2/kjobwidgets/src/CMakeLists.txt, line 17 > > > > > > You should replace this line with: > > > > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURR

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

> On Nov. 5, 2013, 1:54 p.m., Aurélien Gâteau wrote: > > tier2/kjobwidgets/src/CMakeLists.txt, line 17 > > > > > > You should replace this line with: > > > > if("${CMAKE_BINARY_DIR}" STREQUAL "${CMAKE_CURR

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/ --- (Updated Nov. 5, 2013, 2:18 p.m.) Review request for KDE Frameworks and Au

Re: Review Request 113625: Prepare KHTML for moving into tier4.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/ --- (Updated Nov. 5, 2013, 2:28 p.m.) Status -- This change has been mark

Review Request 113645: Fix Warning of Unused Parameter in KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113645/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/#review43065 --- tier2/kjobwidgets/CMakeLists.txt

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/ --- (Updated Nov. 5, 2013, 2:40 p.m.) Review request for KDE Frameworks and Au

Re: Review Request 113625: Prepare KHTML for moving into tier4.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/#review43064 --- This review has been submitted with commit 62c3ce73fc99fe588f0

Build failed in Jenkins: kdelibs_frameworks_qt5 #1591

See Changes: [kde] KHTML: Remove KBookmarks from publicly linked libraries -- [...truncated 8003 lines...] Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/xml/dom2_rangeimpl.cpp.o Bui

Review Request 113646: Fix KTextWidgets standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113646/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113646: Fix KTextWidgets standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113646/#review43068 --- tier3/ktextwidgets/src/widgets/ktextedit.cpp

Re: Review Request 113500: make KNewStuff build on its own

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/#review43069 --- This review has been submitted with commit 002415a3ce493667252

Re: Review Request 113500: make KNewStuff build on its own

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113500/ --- (Updated Nov. 5, 2013, 3:05 p.m.) Status -- This change has been mark

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

> On Nov. 4, 2013, 4:12 p.m., John Layt wrote: > > I've asked on the Qt Development list about Qt 5 Solaris support. I'm told > > it builds and works to some extent, and patches are welcome, but not > > without having been tested on a real Solaris build first, which I have no > > desire to do

Build failed in Jenkins: kdelibs_frameworks_qt5 #1592

See Changes: [jpwhiting] Make knewstuff3 build standalone. -- [...truncated 8018 lines...] Linking CXX executable kxerrorhandlertest Generating kimiface.moc Linking CXX executable ktabwidgettes

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43071 --- Looks ok to me. I'd like someone with more knowledge of KWindow

Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review43072 --- Looks fine to me, would need someone with more X knowledge to l

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/#review43075 --- Ship it! Ship It! - Kevin Ottens On Nov. 5, 2013, 2:40 p.m.

Re: Review Request 113646: Fix KTextWidgets standalone build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113646/#review43076 --- Ship it! Ship It! - Kevin Ottens On Nov. 5, 2013, 2:58 p.m.

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113642/#review43073 --- Ship it! Ship It! - Kevin Ottens On Nov. 5, 2013, 1:54 p.m.

Re: Review Request 113645: Fix Warning of Unused Parameter in KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113645/#review43074 --- The queueing has just been reintroduced by Alex. Please rebase

Re: Review Request 113645: Fix Warning of Unused Parameter in KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113645/ --- (Updated Nov. 5, 2013, 3:53 p.m.) Status -- This change has been disc

KF5 Update Meeting Minutes 2013-w45

Hello everyone, This is the minutes of the Week 43 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, d_ed, dfaure, dMaggot, mgraesslin, Riddell, sandsmark, sebas, svuorela, teo and myself. * afiestas is working toward completion of

Re: KF5 Update Meeting Minutes 2013-w45

On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: > On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: > > > > * sandsmark cleaned up KTextEditorSpellingInterface; > > I think this was discussed before, but I forgot it again :( > > The KTextEditor stuff, will it stay in KDELibs for

Re: KF5 Update Meeting Minutes 2013-w45

On Tuesday 05 November 2013 17:20:27 Dominik Haumann wrote: > On Tuesday 05 November 2013 17:13:01 Milian Wolff wrote: > > On Tuesday 05 November 2013 17:04:47 Kevin Ottens wrote: > > > > > > > * sandsmark cleaned up KTextEditorSpellingInterface; > > > > I think this was discussed before, but I

Review Request 113650: Adopt ecm_generate_headers in KParts framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113650/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113642/ --- (Updated Nov. 5, 2013, 5:27 p.m.) Status -- This change has been mark

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/#review43089 --- This review has been submitted with commit 3a2abcf24d1703a6c31

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113642/#review43088 --- This review has been submitted with commit 5899a8dd46d0e7dda51

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113643/ --- (Updated Nov. 5, 2013, 5:27 p.m.) Status -- This change has been mark

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

> On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: > > Looks much better, but it doesn't handle depth 30 pixmaps. > > Martin Gräßlin wrote: > I'm lacking ideas on how to test this. Do you know any application which > uses 30 bit pixmaps? > > Fredrik Höglund wrote: > The default dept

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/#review43127 --- I just tried this on Windows 7, MSVC 2010, 32-bit. The library

Review Request 113657: Fix Standalone Configuration of DNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kdelibs

Review Request 113670: Link kde4support privately to QtX11Extras and QtSvg

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113670/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

> On Nov. 6, 2013, 12:26 a.m., Nicolás Alvarez wrote: > > I just tried this on Windows 7, MSVC 2010, 32-bit. The library itself > > compiles. The autotests ask for X11 headers though; it seems some of the > > autotests have to be disabled altogether on Windows. > > > > In addition, the only ma

Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 6, 2013, 7:28 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

> On Nov. 5, 2013, 4:09 p.m., Kevin Ottens wrote: > > Looks ok to me. I'd like someone with more knowledge of KWindowSystem > > and/or windows to look at it though. I cannot comment on the Windows bit, but the cmake stuff around it looks good to me. - Martin ---