Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-12 Thread Martin Gräßlin
On Nov. 10, 2013, 10:54 a.m., David Faure wrote: tier3/kconfigwidgets/src/kcolorscheme.h, line 596 http://git.reviewboard.kde.org/r/113685/diff/1/?file=210267#file210267line596 Wouldn't Oxygen be translated, normally? If so, isn't this bad API, giving a translated name

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/ --- (Updated Nov. 12, 2013, 9:13 a.m.) Review request for KDE Frameworks,

Re: Review Request 113796: KDBusService: only register desktop activation object for Unique apps

2013-11-12 Thread David Faure
On Nov. 11, 2013, 5:28 p.m., David Faure wrote: I'm not sure this is a good idea. Yes, the spec for this (e.g. for app launchers) is only about unique apps, but I still want to be able to start a konqueror instance (org.kde.konqueror-12345) and then make a dbus call to have it open

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread David Faure
On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote: Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare? Nicolás Alvarez wrote: In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread David Faure
On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote: Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare? Nicolás Alvarez wrote: In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/ --- (Updated Nov. 12, 2013, 9:48 a.m.) Review request for KDE Frameworks,

Re: Review Request 113801: note that binaries are for developer use

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113801/#review43503 --- This review has been submitted with commit

Re: Review Request 113801: note that binaries are for developer use

2013-11-12 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113801/ --- (Updated Nov. 12, 2013, 9:44 a.m.) Status -- This change has been

Review Request 113810: update kcookiejar manpage

2013-11-12 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113810/ --- Review request for KDE Frameworks and David Faure. Repository: kdelibs

Re: Review Request 113810: update kcookiejar manpage

2013-11-12 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113810/ --- (Updated Nov. 12, 2013, 10:10 a.m.) Review request for KDE Frameworks and

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review43507 --- This review has been submitted with commit

Re: Review Request 113810: update kcookiejar manpage

2013-11-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113810/#review43509 --- Ship it! Looks good to me, probably tasks should be created

Re: Review Request 113796: KDBusService: only register desktop activation object for Unique apps

2013-11-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113796/ --- (Updated Nov. 12, 2013, 11:48 a.m.) Status -- This change has been

Re: Review Request 113810: update kcookiejar manpage

2013-11-12 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113810/ --- (Updated Nov. 12, 2013, 11:51 a.m.) Status -- This change has been

Review Request 113816: Improve KDBusAddons API docs

2013-11-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113816/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens.

KDBusService, Open and ActivateAction

2013-11-12 Thread Alex Merry
This question is mainly directed at David Faure and Kevin Ottens, as the authors of KDBusService, but to provide context for everyone else, KDBusService implements (among other things) the D-Bus activation scheme from the desktop entry spec

Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

2013-11-12 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113818/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository:

Re: Review Request 113816: Improve KDBusAddons API docs

2013-11-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113816/#review43523 --- Ship it! Many thanks, this is good stuff.

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

2013-11-12 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113818/#review43524 --- Ship it! Ship It! - Maarten De Meyer On Nov. 12, 2013,

Re: KDBusService, Open and ActivateAction

2013-11-12 Thread David Faure
On Tuesday 12 November 2013 13:40:06 Alex Merry wrote: This question is mainly directed at David Faure and Kevin Ottens, as the authors of KDBusService, but to provide context for everyone else, KDBusService implements (among other things) the D-Bus activation scheme from the desktop entry

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

2013-11-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113818/#review43527 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 12, 2013,

Re: Review Request 113816: Improve KDBusAddons API docs

2013-11-12 Thread Alex Merry
On Nov. 12, 2013, 3:31 p.m., David Faure wrote: tier1/kdbusaddons/src/kdbusservice.h, line 61 http://git.reviewboard.kde.org/r/113816/diff/1/?file=212621#file212621line61 (not related to this commit, but this makes me re-read this paragraph, and Thiago made me realize meanwhile

KF5 Update Meeting Minutes 2013-w46

2013-11-12 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 46 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, apol, dfaure, dMaggot, jpwhiting, mdemeyer, mgraesslin, randomguy3, Riddell, sebas, svuorela and myself. Announcement: * I plan to open

Re: Review Request 113816: Improve KDBusAddons API docs

2013-11-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113816/ --- (Updated Nov. 12, 2013, 4:04 p.m.) Status -- This change has been

Re: Review Request 113816: Improve KDBusAddons API docs

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113816/#review43529 --- This review has been submitted with commit

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

2013-11-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113818/#review43530 --- This review has been submitted with commit

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

2013-11-12 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113818/ --- (Updated Nov. 12, 2013, 4:06 p.m.) Status -- This change has been

Re: KDBusService, Open and ActivateAction

2013-11-12 Thread Alex Merry
On 12/11/13 15:46, David Faure wrote: On Tuesday 12 November 2013 13:40:06 Alex Merry wrote: When the application is specified as being Unique, the KDBusService constructor of a second instance will call Activate() on the first instance and then quit. This means that any command line

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

2013-11-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review43533 --- CMakeLists.txt

Re: KDBusService, Open and ActivateAction

2013-11-12 Thread David Faure
On Tuesday 12 November 2013 16:12:51 Alex Merry wrote: Well, except that the desktop spec allows (and encourages) the specification of an equivalent Exec line. So the idea would be that you would, say, specify [Desktop Action Foo] Name=Do Foo Exec=app --action=foo and then KDBusService

Re: KDBusService, Open and ActivateAction

2013-11-12 Thread Alex Merry
On 12/11/13 17:17, David Faure wrote: IOW, I would let the app handle this the way it wants. It receives the command line, it gets the dbus calls via KDBusService, so it can handle it all. Which means we need a way to *let* the application deal with it like that. As it stands, the

Re: KDBusService, Open and ActivateAction

2013-11-12 Thread David Faure
On Tuesday 12 November 2013 17:27:31 Alex Merry wrote: On 12/11/13 17:17, David Faure wrote: IOW, I would let the app handle this the way it wants. It receives the command line, it gets the dbus calls via KDBusService, so it can handle it all. Which means we need a way to *let* the

Review Request 113821: Don't install kpagedialog_p.h

2013-11-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/ --- Review request for KDE Frameworks and David Faure. Repository: kdelibs

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113805/#review43538 --- IMO the patch as it is is not good. Several things: 1) This

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Alexander Neundorf
On Nov. 12, 2013, 12:02 a.m., Aleix Pol Gonzalez wrote: Maybe I've missed something, but I would like to have it explained somehow. Why is it bad to define such values? How will g++ calls compare? Nicolás Alvarez wrote: In normal CMake, -DCMAKE_BUILD_TYPE=Debug builds without

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Sune Vuorela
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Getting ecm files from the ECM package

2013-11-12 Thread Alexander Neundorf
On Monday 11 November 2013, Aaron J. Seigo wrote: On Sunday, November 3, 2013 20:51:57 Alexander Neundorf wrote: I wanted to release ECM as fast as possible, since this was one of the main points I got from the platform meeting in Randa in June 2011: people want to be able to use cmake

Re: Having a Tier 0 for cmake and git submodules

2013-11-12 Thread Alexander Neundorf
On Monday 11 November 2013, Ben Cooksley wrote: On Mon, Nov 11, 2013 at 10:48 PM, David Faure fa...@kde.org wrote: On Monday 11 November 2013 01:06:33 Michael Pyne wrote: On Sun, November 10, 2013 20:11:07 David Faure wrote: On Sunday 10 November 2013 13:44:09 Michael Pyne wrote: I

Re: Having a Tier 0 for cmake and git submodules

2013-11-12 Thread Alexander Neundorf
On Sunday 10 November 2013, Kevin Ottens wrote: Hello, Since there's been several times discussions about having a kind of Tier 0 for building our frameworks containing what is right now in ECM kde-modules directory, but the idea was never really on the table because of the extra dependency

Review Request 113683: Fix kdeclarative standalone build

2013-11-12 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Aurélien Gâteau.

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Alexander Neundorf
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Getting ecm files from the ECM package

2013-11-12 Thread Sune Vuorela
On 2013-11-11, Aaron J. Seigo ase...@kde.org wrote: would that work for everyone? I don't think it solves the actual hard point: Where should the final home for the stuff in ecm/kde-modules be ? I'll like to reiterate what I suggested should happen with it: KDEInstallDirs.cmake : Keep it as

Re: Getting ecm files from the ECM package

2013-11-12 Thread Alexander Neundorf
On Monday 11 November 2013, Aaron J. Seigo wrote: ... in my mind this allows: * an immediate release of ecm * allows KDE to back it rather than have ecm distanced from KDE * this gives ecm a needed “reference customer” * this gives KDE a first step into the “we’re a community

Re: Getting ecm files from the ECM package

2013-11-12 Thread Kevin Ottens
On Tuesday 12 November 2013 20:04:38 Sune Vuorela wrote: On 2013-11-11, Aaron J. Seigo ase...@kde.org wrote: would that work for everyone? I don't think it solves the actual hard point: Where should the final home for the stuff in ecm/kde-modules be ? Agreed. Although that's from the KF5

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Sune Vuorela
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Alexander Neundorf
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Sune Vuorela
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Review Request 113805: Do not change the build types available with cmake

2013-11-12 Thread Alexander Neundorf
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote: IMO the patch as it is is not good. Several things: 1) This file, is not mandatory at all with KDE frameworks. You can build applications using KDE frameworks libraries without it. You (the developer of the application) simply

Re: Review Request 113683: Fix kdeclarative standalone build

2013-11-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43555 --- Ship it! No, if it works just push it. - Aleix Pol Gonzalez

Re: Having a Tier 0 for cmake and git submodules

2013-11-12 Thread Alexander Neundorf
On Sunday 10 November 2013, Kevin Ottens wrote: Hello, Since there's been several times discussions about having a kind of Tier 0 for building our frameworks containing what is right now in ECM kde-modules directory, but the idea was never really on the table because of the extra dependency

Re: Getting ecm files from the ECM package

2013-11-12 Thread Alexander Neundorf
On Tuesday 12 November 2013, Kevin Ottens wrote: On Tuesday 12 November 2013 20:04:38 Sune Vuorela wrote: On 2013-11-11, Aaron J. Seigo ase...@kde.org wrote: would that work for everyone? I don't think it solves the actual hard point: Where should the final home for the stuff in

Review Request 113825: Move kmediaplayer to staging (and fix its CMake files)

2013-11-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113825/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 113827: CMake: refer to target directly instead of getting LOCATION property

2013-11-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113827/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113685/#review43557 --- About the .colors translations, we have this

Optional QtGui dependency for KDBusAddons?

2013-11-12 Thread Alex Merry
This is in relation to https://git.reviewboard.kde.org/r/113798/ Basically, KDBusService, which handles (among other things) unique applications, needs to deal with startup notification. It both needs to get the existing startup notification info if it is a duplicate instance that needs to pass

Review Request 113830: Allow unique apps to access command-line arguments of later invocations

2013-11-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/ --- Review request for KDE Frameworks and David Faure. Repository: kdelibs

Re: Optional QtGui dependency for KDBusAddons?

2013-11-12 Thread Martin Gräßlin
On Tuesday 12 November 2013 23:42:36 Alex Merry wrote: The latter is my personal preference (and I don't see any real issue with KDBusAddons optionally using something from Qt Essentials), but what are other people's thoughts? Could you explain why KDBusService has to care about the

Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-12 Thread Martin Gräßlin
On Nov. 12, 2013, 11:49 p.m., Albert Astals Cid wrote: About the .colors translations, we have this ./kdeui/colors/kcolordialog.cpp:104:{ 40.colors, I18N_NOOP2(palette name, Forty Colors) }, ./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors, I18N_NOOP2(palette name,

Re: Optional QtGui dependency for KDBusAddons?

2013-11-12 Thread Kevin Ottens
On Wednesday 13 November 2013 06:38:44 Martin Gräßlin wrote: On Tuesday 12 November 2013 23:42:36 Alex Merry wrote: The latter is my personal preference (and I don't see any real issue with KDBusAddons optionally using something from Qt Essentials), but what are other people's thoughts?

Accessing the private of KGlobalShortcut in kglobalaccel

2013-11-12 Thread Martin Gräßlin
Hi, I'm currently trying to port kglobalaccel in kde-runtime to frameworks. I'm facing an issue in the file globalshortcut.cpp: it tries to access the private header of KGlobalShortcutInfo to create a custom KGlobalShortcutInfo object[1]. Now this looks obviously wrong and doesn't work as the