On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote:
About the .colors translations, we have this
./kdeui/colors/kcolordialog.cpp:104:{ 40.colors,
I18N_NOOP2(palette name, Forty Colors) },
./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors,
I18N_NOOP2(palette name,
On 13/11/13 05:38, Martin Gräßlin wrote:
On Tuesday 12 November 2013 23:42:36 Alex Merry wrote:
The latter is my personal preference (and I don't see any real issue
with KDBusAddons optionally using something from Qt Essentials), but
what are other people's thoughts?
Could you explain why
On Nov. 12, 2013, 10:49 p.m., Albert Astals Cid wrote:
About the .colors translations, we have this
./kdeui/colors/kcolordialog.cpp:104:{ 40.colors,
I18N_NOOP2(palette name, Forty Colors) },
./kdeui/colors/kcolordialog.cpp:105:{ Oxygen.colors,
I18N_NOOP2(palette name,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113821/#review43572
---
Ship it!
I don't spot anything wrong.
- Vishesh Handa
On
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113821/#review43573
---
tier4/kcmutils/src/kcmultidialog.cpp
See http://build.kde.org/job/plasma-framework_master_qt5/902/changes
Changes:
[bhush94] Make plasma-framework build without tests
--
[...truncated 254 lines...]
[ 7%] Automatic moc for target platformcomponentsplugin
Generating moc_modeltest.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113834/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote:
tier4/kcmutils/src/kcmultidialog.cpp, line 262
http://git.reviewboard.kde.org/r/113821/diff/1/?file=213192#file213192line262
I don't think this is right.
If we copy a KCMultiDialog instance, we wouldn't copy the
See http://build.kde.org/job/plasma-framework_master_qt5/903/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 18
http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18
I don't think we want that, superbuild shouldn't be used after the
splitting but the kde build script. We will need it
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113506/
---
(Updated Nov. 13, 2013, 2:07 p.m.)
Review request for Build System, KDE
On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote:
tier4/kcmutils/src/kcmultidialog.cpp, line 262
http://git.reviewboard.kde.org/r/113821/diff/1/?file=213192#file213192line262
I don't think this is right.
If we copy a KCMultiDialog instance, we wouldn't copy the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112874/
---
(Updated Nov. 13, 2013, 1:17 p.m.)
Status
--
This change has been
On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote:
Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin
Ottens. Committed on 12/11/2013 at 17:09.
Pushed by ervin into branch 'frameworks'.
Move cmake legacy to KDE4Support
All the old CMake is now provided by KDE4Support as a
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113830/#review43586
---
tier1/kdbusaddons/src/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113830/
---
(Updated Nov. 13, 2013, 1:52 p.m.)
Review request for KDE Frameworks and
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 18
http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18
I don't think we want that, superbuild shouldn't be used after the
splitting but the kde build script. We will need it
On Nov. 13, 2013, 1:33 p.m., David Faure wrote:
tier1/kdbusaddons/src/CMakeLists.txt, line 17
http://git.reviewboard.kde.org/r/113830/diff/1/?file=213290#file213290line17
Maybe this should be called org.kde.KDBusService.xml instead.
It's an implementation detail of
On 13/11/13 13:20, Christoph Feck wrote:
On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote:
tier4/kde4support/cmake/modules-tests/OpenEXR/CMakeLists.txt
[from: cmake/modules-tests/OpenEXR/CMakeLists.txt - 100%
similarity] R +0-0
OpenEXR is needed by
On Nov. 13, 2013, 1:33 p.m., David Faure wrote:
tier1/kdbusaddons/src/kdbusservice.h, line 172
http://git.reviewboard.kde.org/r/113830/diff/1/?file=213291#file213291line172
When is this emitted, then? Only if the dbus-based app launcher calls
Activate?
Maybe
On Nov. 12, 2013, 6:11 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 18
http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18
I don't think we want that, superbuild shouldn't be used after the
splitting but the kde build script. We will need it
On Nov. 12, 2013, 5:11 p.m., Aleix Pol Gonzalez wrote:
CMakeLists.txt, line 18
http://git.reviewboard.kde.org/r/113506/diff/5/?file=211419#file211419line18
I don't think we want that, superbuild shouldn't be used after the
splitting but the kde build script. We will need it
See http://build.kde.org/job/kdelibs_frameworks_qt5/1661/changes
Changes:
[aleixpol] Move KIO to tier3
--
[...truncated 198 lines...]
-- Looking for include file valgrind/memcheck.h
-- Looking for include file valgrind/memcheck.h - not found
-- Looking
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113821/#review43603
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113821/
---
(Updated Nov. 13, 2013, 3:43 p.m.)
Status
--
This change has been
On Nov. 13, 2013, 1:33 p.m., David Faure wrote:
tier1/kdbusaddons/src/kdbusservice.h, line 172
http://git.reviewboard.kde.org/r/113830/diff/1/?file=213291#file213291line172
When is this emitted, then? Only if the dbus-based app launcher calls
Activate?
Maybe
On Wednesday 13 November 2013 14:20:45 Christoph Feck wrote:
On Tuesday 12 November 2013 20:36:21 Kevin Ottens wrote:
Git commit f073b4561730ef50b4968b92b30cbcc32bccdc7e by Kevin
Ottens. Committed on 12/11/2013 at 17:09.
Pushed by ervin into branch 'frameworks'.
Move cmake legacy to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/#review43607
---
tier3/kconfigwidgets/src/kcolorschememanager.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113830/
---
(Updated Nov. 13, 2013, 5:09 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/#review43616
---
Why is it tier3? It doesn't seem to depend on anything, no?
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113845/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113830/#review43618
---
Of course, if we wanted to support Ryan's use cases (like text
On Nov. 13, 2013, 10:22 a.m., Aleix Pol Gonzalez wrote:
Why is it tier3? It doesn't seem to depend on anything, no?
No it doesn't depend on anything, but is specific to kde platform. I put it
into tier3 because that's what I was told in the meeting, maybe another tier
makes more sense
On Nov. 13, 2013, 5:41 p.m., David Faure wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93
http://git.reviewboard.kde.org/r/113685/diff/2/?file=212585#file212585line93
this is still a C++11 initializer list, which isn't in the wiki page of
allowed C++11 constructs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113847/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/
---
(Updated Nov. 13, 2013, 11:01 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/#review43621
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Nov. 13, 2013,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/
---
(Updated Nov. 13, 2013, 6:57 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113844/#review43622
---
This review has been submitted with commit
On Nov. 11, 2013, 5:45 p.m., David Faure wrote:
Thanks for implementing that. Indeed the TODO didn't mean adding a method
to QApplication, but it was about the member that was there in qt4, and
that is now in QXcbConnection.
The optional dependency on QtGui breaks the rules for
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113792/#review43628
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 11, 2013, 1:32
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113683/#review43629
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 12, 2013, 7:52
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113825/#review43630
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 12, 2013, 10:09
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113827/#review43631
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 12, 2013, 10:29
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113834/#review43632
---
Ship it!
Once 113828 is in of course
- Kevin Ottens
On
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113845/#review43633
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 13, 2013, 5:33
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113830/#review43634
---
tier1/kdbusaddons/src/kdbusservice.h
On Nov. 13, 2013, 4:41 p.m., David Faure wrote:
tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 93
http://git.reviewboard.kde.org/r/113685/diff/2/?file=212585#file212585line93
this is still a C++11 initializer list, which isn't in the wiki page of
allowed C++11 constructs
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113847/#review43636
---
Ship it!
Ship It!
- Kevin Ottens
On Nov. 13, 2013, 5:53
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113792/#review43639
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113792/
---
(Updated Nov. 13, 2013, 10:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113825/
---
(Updated Nov. 14, 2013, 12:05 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113827/#review43643
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113825/#review43642
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113827/
---
(Updated Nov. 14, 2013, 12:05 a.m.)
Status
--
This change has been
On Nov. 11, 2013, 5:45 p.m., David Faure wrote:
Thanks for implementing that. Indeed the TODO didn't mean adding a method
to QApplication, but it was about the member that was there in qt4, and
that is now in QXcbConnection.
The optional dependency on QtGui breaks the rules for
On Nov. 12, 2013, 10:39 a.m., Commit Hook wrote:
This review has been submitted with commit
53e8e439af2483c86b21ad4d53ffe4da622e8c44 by Martin Klapetek to branch
frameworks.
Locally, I get this error:
AUTOMOC: error: process for /local/build/kf5/runtime/ktimezoned/ktimezoned.moc
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113685/
---
(Updated Nov. 14, 2013, 6:50 a.m.)
Review request for KDE Frameworks,
59 matches
Mail list logo
