Review Request 113851: Unbreak kauth-policy-gen

2013-11-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113851: Unbreak kauth-policy-gen

2013-11-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/ --- (Updated Nov. 14, 2013, 10:38 a.m.) Review request for KDE Frameworks. C

Re: Review Request 113851: Unbreak kauth-policy-gen

2013-11-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/ --- (Updated Nov. 14, 2013, 10:43 a.m.) Review request for KDE Frameworks and

Build failed in Jenkins: kdelibs_frameworks_qt5 #1671

2013-11-14 Thread KDE CI System
See Changes: [jr] add trailing slash to fix list() -- [...truncated 5630 lines...] Linking CXX shared module emoticonstheme_xmpp.so [ 64%] Built target klanguagebuttontest [ 65%] Building CXX o

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1672

2013-11-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113851: Unbreak kauth-policy-gen

2013-11-14 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113851/#review43658 --- After applying this patch, kde-workspace builds with clean inst

Re: Review Request 113847: Remove unnecessary dependency in dnssd

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113847/#review43663 --- This review has been submitted with commit fc78af7548938ee32f5

Re: Review Request 113847: Remove unnecessary dependency in dnssd

2013-11-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113847/ --- (Updated Nov. 14, 2013, 1:57 p.m.) Status -- This change has been mar

Re: Review Request 113845: Remove unnecessary dependencies in kauth

2013-11-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113845/ --- (Updated Nov. 14, 2013, 2:02 p.m.) Status -- This change has been mar

Re: Review Request 113845: Remove unnecessary dependencies in kauth

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113845/#review43664 --- This review has been submitted with commit 2a5fb637a595d38a9f5

Review Request 113860: Improve dependency specification in karchive

2013-11-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113860/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 113861: use ecm_mark_as_test instead of kde4_add_unit_test in kwin

2013-11-14 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113861/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kde-work

Review Request 113862: Improve dependency specification in kcodecs

2013-11-14 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113862/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113861: use ecm_mark_as_test instead of kde4_add_unit_test in kwin

2013-11-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113861/#review43671 --- Ship it! Ship It! - Martin Gräßlin On Nov. 14, 2013, 3:53 p

Re: Review Request 113861: use ecm_mark_as_test instead of kde4_add_unit_test in kwin

2013-11-14 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113861/ --- (Updated Nov. 14, 2013, 3:34 p.m.) Status -- This change has been mar

Re: Review Request 113861: use ecm_mark_as_test instead of kde4_add_unit_test in kwin

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113861/#review43674 --- This review has been submitted with commit 659ee81a092a7efe0e5

Review Request 113863: Remove WINCE specific cmake code paths

2013-11-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113863/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113683: Fix kdeclarative standalone build

2013-11-14 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/ --- (Updated Nov. 14, 2013, 3:56 p.m.) Status -- This change has been mar

Re: Review Request 113683: Fix kdeclarative standalone build

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113683/#review43677 --- This review has been submitted with commit 934008a4684befba40c

Re: RFC Rules for installation of header files

2013-11-14 Thread Aurélien Gâteau
On 10.11.2013 18:27, Kevin Ottens wrote: Hello, On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: Yesterday frameworks meeting spawned a discussion regarding folders in header files. I think there's an aspect missing in your proposal. There's the convention we want for #include an

Re: RFC Rules for installation of header files

2013-11-14 Thread Kevin Ottens
On Thursday 14 November 2013 18:04:57 Aurélien Gâteau wrote: > On 10.11.2013 18:27, Kevin Ottens wrote: > > Hello, > > > > On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: > >> Yesterday frameworks meeting spawned a discussion regarding folders > >> in header files. > > > > I think the

Fwd: RFC Rules for installation of header files

2013-11-14 Thread Aleix Pol
On Thu, Nov 14, 2013 at 5:04 PM, Aurélien Gâteau wrote: > On 10.11.2013 18:27, Kevin Ottens wrote: > >> Hello, >> >> On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: >> >>> Yesterday frameworks meeting spawned a discussion regarding folders >>> in header files. >>> >> >> I think ther

Re: RFC Rules for installation of header files

2013-11-14 Thread Aurélien Gâteau
On 14.11.2013 18:20, Kevin Ottens wrote: On Thursday 14 November 2013 18:04:57 Aurélien Gâteau wrote: On 10.11.2013 18:27, Kevin Ottens wrote: > Hello, > > On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: >> Yesterday frameworks meeting spawned a discussion regarding folders >> in

Re: Fwd: RFC Rules for installation of header files

2013-11-14 Thread Aleix Pol
On 14.11.2013 18:31, Aleix Pol wrote: On Thu, Nov 14, 2013 at 5:04 PM, Aurélien Gâteau [3]> wrote: On 10.11.2013 18:27, Kevin Ottens wrote: Hello, On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wrote: Yesterday frameworks meeting spawned a discussion regarding folders in header fi

Build failed in Jenkins: plasma-framework_master_qt5 #904

2013-11-14 Thread KDE CI System
See Changes: [aleixpol] Add a tool to follow KDE cmake coding style with regard to end commands [aleixpol] Remove predicates on cmake end commands [aleixpol] Deprecate plasma_add_plugin

Re: RFC Rules for installation of header files

2013-11-14 Thread Kevin Ottens
On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: > Looks like we have an agreement then. Let me recap: > > # Installation dir > > All header files are installed in $PREFIX/include/KF5/$Framework. > This includes 'k' prefixed headers like kfoo and KFoo, I assume you meant kfoo.h here.

Re: Fwd: RFC Rules for installation of header files

2013-11-14 Thread Kevin Ottens
On Thursday 14 November 2013 18:43:59 Aleix Pol wrote: > On 14.11.2013 18:31, Aleix Pol wrote: > > On Thu, Nov 14, 2013 at 5:04 PM, Aurélien Gâteau > [3]> > > > > wrote: > >> On 10.11.2013 18:27, Kevin Ottens wrote: > >>> Hello, > >>> > >>> On Wednesday 06 November 2013 08:52:29 Aurélien Gâteau wr

Re: Fwd: RFC Rules for installation of header files

2013-11-14 Thread Aurélien Gâteau
This thread is confusing, I don't know who I'm replying to... From: said Aleix, signature Aurélien... Did you guys merge or something? :-) Nah, we did not. My webmail is screwed up and by default sets the From field to the sender of the mail I am replying to. Sorry Aleix for impersonating you.

Re: RFC Rules for installation of header files

2013-11-14 Thread Aurélien Gâteau
On 14.11.2013 18:55, Kevin Ottens wrote: On Thursday 14 November 2013 18:40:04 Aurélien Gâteau wrote: Looks like we have an agreement then. Let me recap: # Installation dir All header files are installed in $PREFIX/include/KF5/$Framework. This includes 'k' prefixed headers like kfoo and KFoo,

Review Request 113867: Add knewstuff public dependencies to it's config.cmake file.

2013-11-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113867/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113867: Add knewstuff public dependencies to it's config.cmake file.

2013-11-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113867/#review43690 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 14, 2013, 6:

Re: Review Request 113867: Add knewstuff public dependencies to it's config.cmake file.

2013-11-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113867/ --- (Updated Nov. 14, 2013, 6:40 p.m.) Status -- This change has been mar

Re: Review Request 113867: Add knewstuff public dependencies to it's config.cmake file.

2013-11-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113867/#review43691 --- This review has been submitted with commit 91f29c4eeb690737499

Build failed in Jenkins: kdelibs_frameworks_qt5 #1677

2013-11-14 Thread KDE CI System
See Changes: [aleixpol] Rename knewstuff3 to KF5::KNewStuff -- [...truncated 6699 lines...] [ 80%] Building CXX object tier4/khtml/src/CMakeFiles/KHtml.dir/misc/AtomicString.cpp.o [ 80%] Build

Build failed in Jenkins: kdelibs_frameworks_qt5 #1678

2013-11-14 Thread KDE CI System
See Changes: [aleixpol] Update KDELibs4Config.cmake with the new KNewStuff name [jpwhiting] Add public library dependencies to KNewStuffConfig.cmake [jpwhiting] Fix whitespace in knewstuff CMakeLists.txt file. -

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1679

2013-11-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel