Re: Review Request 113685: New KColorSchemeManager to support changing color scheme in app

2013-11-17 Thread Martin Gräßlin
> On Nov. 15, 2013, 8:42 p.m., Kevin Ottens wrote: > > tier3/kconfigwidgets/src/kcolorschememanager.cpp, line 124 > > > > > > Would make sense to change the lambda so that you'd pass 16 and 24 > > instead. It fee

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

2013-11-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113877/ --- (Updated Nov. 18, 2013, 7:04 a.m.) Review request for KDE Frameworks. Ch

Build failed in Jenkins: kdelibs_frameworks_qt5 #1691

2013-11-17 Thread KDE CI System
See Changes: [steveire] Add KEmoticons to the deprecated libs. [steveire] Make it possible to avoid excessive warnings. [steveire] Make insertCatalog code compile, but do nothing. [steveire] Reduce noise. [kensington] Improve depe

Re: Wrapping up about KI18n and UIC

2013-11-17 Thread Chusslove Illich
> [: Stephen Kelly :] > If such calls are generated by uic, then that is a bug in Qt (which should > have been reported years ago), and should be fixed in Qt, right? Maybe, I'm not sure of the conventions of Qt Linguist. For Gettext-based system, empty string will not result in empty translation,

Re: Wrapping up about KI18n and UIC

2013-11-17 Thread Stephen Kelly
Kevin Ottens wrote: > On Friday 15 November 2013 16:28:10 Stephen Kelly wrote: >> Aleix Pol wrote: >> > I see that Stephen Kelly has been doing some work on Qt and cmake to >> > make it possible to integrate these properly, but also those changes >> > will get in cmake 3 and Qt 5.3 which are not a

Re: Wrapping up about KI18n and UIC

2013-11-17 Thread Stephen Kelly
Chusslove Illich wrote: >> [: Aleix Pol :] >> I have been going through the list looking for what we should we do when >> it comes to .ui file generation and i18n. > > I am confused by that too. Stephen's projected solution seems to me more > elegant in principle, but I couldn't quite get if (whe

Build failed in Jenkins: kdelibs_frameworks_qt5 #1690

2013-11-17 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kde

Re: Review Request 113887: Deprecate KDE4_* KAuth macros

2013-11-17 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113887/#review43856 --- Ship it! Ship It! - Stephen Kelly On Nov. 15, 2013, 5:34 p.

Build failed in Jenkins: kdelibs_frameworks_qt5 #1689

2013-11-17 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kde

Re: Review Request 113860: Improve dependency specification in karchive

2013-11-17 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113860/ --- (Updated Nov. 17, 2013, 4:08 p.m.) Status -- This change has been mar

Re: Review Request 113860: Improve dependency specification in karchive

2013-11-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113860/#review43852 --- This review has been submitted with commit fe5191e578e1b7280b0

Build failed in Jenkins: kdelibs_frameworks_qt5 #1688

2013-11-17 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace Running Prebuild steps [kde

Re: Review Request 113862: Improve dependency specification in kcodecs

2013-11-17 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113862/ --- (Updated Nov. 17, 2013, 4:04 p.m.) Status -- This change has been mar

Re: Review Request 113862: Improve dependency specification in kcodecs

2013-11-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113862/#review43851 --- This review has been submitted with commit 7e9f1bd0e9b93ce739c

Build failed in Jenkins: kdelibs_frameworks_qt5 #1687

2013-11-17 Thread KDE CI System
See Changes: [steveire] Add KEmoticons to the deprecated libs. [steveire] Make it possible to avoid excessive warnings. [steveire] Make insertCatalog code compile, but do nothing. [steveire] Reduce noise. -