Re: Superbuild in kdelibs

On Fri, Nov 22, 2013 at 3:52 AM, Aurélien Gâteau wrote: > Hi, > Hi, > > This morning I merged my superbuild changes in the frameworks branch. > > Superbuild support was originally enabled by default, but I turned it > off because it broke on build.kde.org. You can turn it on by passing > -DSUP

Re: Reporting bugs against frameworks/plasma2

Long term, I disagree with using the version "frameworks" everywhere. We want to have a split between Frameworks5.0 and Plasma2.0 and they may not be on the same release cycle. That said; you can rename a version in bugzilla with relative ease, and it will 'update' all existing reports. David __

Re: Review Request 113631: Allow compiling kwindowsystem on Windows

> On Nov. 10, 2013, 5:08 p.m., Patrick von Reth wrote: > > please use winsock2.h instead of winsock.h > > Kevin Ottens wrote: > Alexander? Any chance to see this comment addressed? > > Alexander Richardson wrote: > Oops somehow didn't see that comment. Sure I will fix it right away. Any

Re: Review Request 113798: KDBusService: pass the desktop startup ID when calling Activate

> On Nov. 11, 2013, 5:45 p.m., David Faure wrote: > > Thanks for implementing that. Indeed the TODO didn't mean adding a method > > to QApplication, but it was about the member that was there in qt4, and > > that is now in QXcbConnection. > > > > The optional dependency on QtGui breaks the rul

Re: Review Request 113830: Allow unique apps to access command-line arguments of later invocations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113830/#review44129 --- Ship it! Ship It! - Kevin Ottens On Nov. 19, 2013, 4:10 p.m

Re: kded5 and kde-workspace

On Thursday 21 November 2013 11:09:22 Daniel Nicoletti wrote: > Funny this is the kind of thing that could just be > avoided if projects stopped using the > org.kde.kded DBus interface and instead registered > their own. I for example don't need to do any change > because I register org.kde.apperd

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 21, 2013, 12:38 p.m.) Status -- This change has been ma

Re: Review Request 113949: Workaround for dependency issues when generating .json from .desktop files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113949/#review44130 --- Ship it! Ship It! - Kevin Ottens On Nov. 19, 2013, 6:19 p.m

Re: Reporting bugs against frameworks/plasma2

Hello, On Thursday 21 November 2013 15:59:17 David Edmundson wrote: > Long term, I disagree with using the version "frameworks" everywhere. Agreed... > We want to have a split between Frameworks5.0 and Plasma2.0 and they > may not be on the same release cycle. > > That said; you can rename a ver

Superbuild in kdelibs

Hi, This morning I merged my superbuild changes in the frameworks branch. Superbuild support was originally enabled by default, but I turned it off because it broke on build.kde.org. You can turn it on by passing -DSUPERBUILD=ON to cmake. When superbuild is enabled, you can build any framework s

Re: Review Request 113503: make dbus dependency optional in JobWidgets

> On Nov. 15, 2013, 6:20 p.m., Kevin Ottens wrote: > > Any chance to see Stephen's comments addressed or this patch is abandoned? Last warning, I'll close it as discarded if it's not updated on my next round of reviews. - Kevin --- Thi

Re: Review Request 113975: Make some KSSL files public API

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113975/#review44133 --- I'd give a ship it, but I'd like David to take a look at it. -

Re: Review Request 113968: Make KFileAudioPreview use its own config group

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113968/#review44132 --- Ship it! Ship It! - Kevin Ottens On Nov. 20, 2013, 11:36 a.

Review Request 114004: Install kio/connection_p.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114004/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/#review44131 --- Ship it! Ship It! - Kevin Ottens On Nov. 20, 2013, 7:39 a.m

Re: Reporting bugs against frameworks/plasma2

On Thursday 21 November 2013 15:53:33 Àlex Fiestas wrote: > Hi there! > > We are already trying to dogfood Plasma2 + frameworks and as it was to be > expected we have tons of bugs :p so I have taken the liberty of setting up > bugzilla, we can change things if you don't agree with that I have done

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44125 --- tier3/kiconthemes/src/CMakeLists.txt

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

> On Nov. 21, 2013, 4:21 p.m., Aurélien Gâteau wrote: > > Ship It! Hold your horses people... I'd like to get a chance to look at this one. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.k

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113987/ --- (Updated Nov. 21, 2013, 5:53 p.m.) Status -- This change has been mar

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/ --- (Updated Nov. 21, 2013, 5:35 p.m.) Status -- This change has been mar

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44120 --- Ship it! Ship It! - Aurélien Gâteau On Nov. 21, 2013, 1:29

Review Request 114003: Install private headers needed by kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113987/ --- (Updated Nov. 21, 2013, 5:28 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/#review44106 --- KIcon can get rid of the dependency since now QIcon will use th

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1719

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1718

See Changes: [agateau] Rework superbuild to make it easier to use [agateau] add kdoctools to dependencies [agateau] Disable kcmutils for now [agateau] Add a SUPERBUILD option to be able to turn off superbuild [agateau] Disable sup

Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/#review44105 --- This review has been submitted with commit 359dec5c94dee325d7e

Review Request 113996: Install needed private headers for FrameworksIntegration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113996/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Reporting bugs against frameworks/plasma2

On Thursday 21 November 2013 16:34:28 Kevin Ottens wrote: > Hello, > > On Thursday 21 November 2013 15:59:17 David Edmundson wrote: > > Long term, I disagree with using the version "frameworks" everywhere. > > Agreed... > > > We want to have a split between Frameworks5.0 and Plasma2.0 and they >

Re: Review Request 113949: Workaround for dependency issues when generating .json from .desktop files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113949/#review44139 --- This review has been submitted with commit 6f11c4fb9fbae6e38f5

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113987/#review44147 --- This review has been submitted with commit 2a1ec57480a3abf4212

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

> On Nov. 21, 2013, 12:42 p.m., Àlex Fiestas wrote: > > KIcon can get rid of the dependency since now QIcon will use the > > QPlatformTheme to obtain the engine, meaning that all QIcon will have our > > KIconEngine already. > > > > for the case of the PlatformTheme, we do need that header. Me

Re: Review Request 113987: tier3/kpty: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113987/#review44136 --- Ship it! Ship It! - Kevin Ottens On Nov. 21, 2013, 4:28 p.m

Re: Review Request 113996: Install needed private headers for FrameworksIntegration

> On Nov. 21, 2013, 5:21 p.m., Aurélien Gâteau wrote: > > Ship It! > > Kevin Ottens wrote: > Hold your horses people... I'd like to get a chance to look at this one. At least the kmessageboxnotifyinterface.h is a no brainer, I created it but forgot to add it to the install() command. - A

Reporting bugs against frameworks/plasma2

Hi there! We are already trying to dogfood Plasma2 + frameworks and as it was to be expected we have tons of bugs :p so I have taken the liberty of setting up bugzilla, we can change things if you don't agree with that I have done. For frameworks: I have added a new version called "fram

Jenkins build became unstable: kdelibs_frameworks_qt5 #1721

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113949: Workaround for dependency issues when generating .json from .desktop files

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113949/ --- (Updated Nov. 21, 2013, 5:10 p.m.) Status -- This change has been mar

Re: Review Request 114003: Install private headers needed by kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114003/#review44135 --- Don't we have better solutions than installing random private h

Re: Review Request 113962: Fixing regression in KWindowSystem_X11

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113962/#review44141 --- This review has been submitted with commit cca88c8b3b3911f5f48

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1716

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1715

See Changes: [agateau] Add missing find_package(KDocTools) calls [agateau] kpagedialog_p.h is no longer installed, do not include it -- [...truncated 4030 lines...] Scanning dependencies of ta

Re: Review Request 113972: Add some autotests for KMediaPlayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113972/#review44101 --- This review has been submitted with commit 9b725fcb31a60155891

Re: Review Request 113972: Add some autotests for KMediaPlayer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113972/ --- (Updated Nov. 21, 2013, 11:05 a.m.) Status -- This change has been ma

Re: kded5 and kde-workspace

On Wednesday 20 November 2013 20:47:54 Àlex Fiestas wrote: > Hey there > > Today I have been porting powerdevil and while doing it found out that kded5 > was not loading any modules and many kde-workspace projects were using > org.kde.kded instead of the one ended with .kded5 > > Tomorrow I'd lik

Re: Review Request 113937: Remove dependency from kio on kinit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113937/ --- (Updated Nov. 21, 2013, 9:52 a.m.) Status -- This change has been mar

Re: Review Request 113937: Remove dependency from kio on kinit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113937/#review44093 --- This review has been submitted with commit b93ed9fc37e13ef3ba6