Jenkins build is back to normal : kded_master_qt5 #7

2014-01-02 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: What are the plans with CamelCase includes?

2014-01-02 Thread David Faure
On Thursday 02 January 2014 07:45:12 Kevin Ottens wrote: > On Thursday 02 January 2014 00:31:05 David Faure wrote: > > On Tuesday 31 December 2013 14:48:13 Aleix Pol wrote: > > > > -- Up-to-date: > > > > /d/kde/inst/kde_frameworks/include/KF5/kcoreaddons/kaboutdata.h > > > > -- Up-to-date: > > > >

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Christoph Cullmann
> > This wasn't intended I guess. When the discussion about include files > > occured the consensus was to have everything in a single directory (the > > camel cased one). > > OK I initially thought it was so the implementation of ecm_generate_headers > is > simpler (lowercase everything), but in

Re: What are the plans with CamelCase includes?

2014-01-02 Thread David Faure
On Thursday 02 January 2014 11:42:57 Christoph Cullmann wrote: > > > This wasn't intended I guess. When the discussion about include files > > > occured the consensus was to have everything in a single directory (the > > > camel cased one). > > > > OK I initially thought it was so the implementati

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Christoph Cullmann
- Ursprüngliche Mail - > > Hmm, > > > > just a question for the case, that we have a namespace, like KTextEditor. > > > > At the moment we install (e.g. for KTextEditor::View): > > > > KTextEditor/View > > > > and > > > > ktexteditor/view.h > > > > Will that change still make that pos

Build failed in Jenkins: kjsembed_master_qt5 #4

2014-01-02 Thread KDE CI System
See -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace Running Prebuild steps [kjsembed_mas

Re: Forwarding headers: current status

2014-01-02 Thread David Faure
On Thursday 02 January 2014 00:58:21 David Faure wrote: > karchive -- TODO split out KArchiveFile etc. I'll do that next. Done. > kded [why does it install a kded_version.h?] Fixed. > kjsembed [why does it install a kjsembed_version.h and a kjsembed_export.h, > if it has no headers?] Fixed. >

Re: What are the plans with CamelCase includes?

2014-01-02 Thread David Faure
On Thursday 02 January 2014 11:35:43 David Faure wrote: > See attached patch. I forgot to attach the corresponding patch for ECM. Tested on KParts too, with the addition of a "PREFIX" variable. MODULE_NAME = KParts or KIOCore .. the include dir under KF5, always titlecase PREFIX = KParts or KIO,

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Kevin Ottens
On Thursday 02 January 2014 12:25:47 David Faure wrote: > On Thursday 02 January 2014 11:35:43 David Faure wrote: > > See attached patch. > > I forgot to attach the corresponding patch for ECM. > > Tested on KParts too, with the addition of a "PREFIX" variable. > > MODULE_NAME = KParts or KIOCor

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Aleix Pol
On Thu, Jan 2, 2014 at 12:31 AM, David Faure wrote: > On Tuesday 31 December 2013 14:48:13 Aleix Pol wrote: > > > -- Up-to-date: > > > /d/kde/inst/kde_frameworks/include/KF5/kcoreaddons/kaboutdata.h > > > -- Up-to-date: > > > /d/kde/inst/kde_frameworks/include/KF5/KCoreAddons/KAboutData > > > > >

Re: Forwarding headers for ThreadWeaver

2014-01-02 Thread Mirko Boehm
Hi! On 01 Jan 2014, at 18:37 , David Faure wrote: > On Wednesday 01 January 2014 18:27:36 Mirko Boehm wrote: >> Hi, >> >> On 01 Jan 2014, at 17:26 , David Faure wrote: >>> I'm converting all frameworks to ecm_generate_headers, which creates >>> Framework/File forwarding headers for framework/f

Re: What are the plans with CamelCase includes?

2014-01-02 Thread David Faure
On Thursday 02 January 2014 14:06:47 Kevin Ottens wrote: > On Thursday 02 January 2014 12:25:47 David Faure wrote: > > On Thursday 02 January 2014 11:35:43 David Faure wrote: > > > See attached patch. > > > > I forgot to attach the corresponding patch for ECM. > > > > Tested on KParts too, with t

Re: Forwarding headers for ThreadWeaver

2014-01-02 Thread David Faure
On Thursday 02 January 2014 15:29:13 Mirko Boehm wrote: > > The official way used by all other modules would be > > threadweaver/job.h (lowercase real header) and > > ThreadWeaver/Job (forwarding header) > > Ok. Is this a green light for us to convert all of threadweaver (and its users) to this

Re: Forwarding headers for ThreadWeaver

2014-01-02 Thread Mirko Boehm
Hi, On 02 Jan 2014, at 15:37 , David Faure wrote: > On Thursday 02 January 2014 15:29:13 Mirko Boehm wrote: >>> The official way used by all other modules would be >>> threadweaver/job.h (lowercase real header) and >>> ThreadWeaver/Job (forwarding header) >> >> Ok. > > Is this a green light f

Re: Forwarding headers for ThreadWeaver

2014-01-02 Thread David Faure
On Thursday 02 January 2014 16:26:33 Mirko Boehm wrote: > Hi, > > On 02 Jan 2014, at 15:37 , David Faure wrote: > > On Thursday 02 January 2014 15:29:13 Mirko Boehm wrote: > >>> The official way used by all other modules would be > >>> threadweaver/job.h (lowercase real header) and > >>> ThreadWe

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Kevin Ottens
On Thursday 02 January 2014 12:25:47 David Faure wrote: > Awaiting for green light. /me waves the green light. Cheers. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part.

Re: Forwarding headers for ThreadWeaver

2014-01-02 Thread Kevin Ottens
On Thursday 02 January 2014 17:14:36 David Faure wrote: > On Thursday 02 January 2014 16:26:33 Mirko Boehm wrote: > > Hi, > > > > On 02 Jan 2014, at 15:37 , David Faure wrote: > > > On Thursday 02 January 2014 15:29:13 Mirko Boehm wrote: > > >>> The official way used by all other modules would be

Re: Issues porting KGeography to KF5

2014-01-02 Thread Kevin Ottens
On Tuesday 31 December 2013 10:39:08 David Faure wrote: > On Tuesday 31 December 2013 00:52:59 David Gil Oliva wrote: > > Hi! > > > > I'm porting KGeography to KF5, and I found some issues. > > > > *KConfigDialog::setHelp()* > > > > KConfigDialog* dialog = new KConfigDialog(this, "settings", > >

Re: modules for KF5 TP1 release

2014-01-02 Thread Martin Sandsmark
Hi! :-D On Tue, Dec 31, 2013 at 10:32:22AM +0100, David Faure wrote: > sonnetmaster Can I break API after the TP1 release? I have some cleanups done in Sonnet (and more ABI breaks underways, missing some virtuals). -- Martin Sandsmark ___ Kde-fram

Re: Issues porting KGeography to KF5

2014-01-02 Thread Albert Astals Cid
El Dijous, 2 de gener de 2014, a les 17:36:41, Kevin Ottens va escriure: > On Tuesday 31 December 2013 10:39:08 David Faure wrote: > > On Tuesday 31 December 2013 00:52:59 David Gil Oliva wrote: > > > Hi! > > > > > > I'm porting KGeography to KF5, and I found some issues. > > > > > > *KConfigDial

Re: Issues porting KGeography to KF5

2014-01-02 Thread Kevin Ottens
On Thursday 02 January 2014 19:45:36 Albert Astals Cid wrote: > El Dijous, 2 de gener de 2014, a les 17:36:41, Kevin Ottens va escriure: > > On Tuesday 31 December 2013 10:39:08 David Faure wrote: > > > On Tuesday 31 December 2013 00:52:59 David Gil Oliva wrote: > > > > Hi! > > > > > > > > I'm por

Re: Issues porting KGeography to KF5

2014-01-02 Thread Albert Astals Cid
El Dijous, 2 de gener de 2014, a les 19:48:46, Kevin Ottens va escriure: > On Thursday 02 January 2014 19:45:36 Albert Astals Cid wrote: > > El Dijous, 2 de gener de 2014, a les 17:36:41, Kevin Ottens va escriure: > > > On Tuesday 31 December 2013 10:39:08 David Faure wrote: > > > > On Tuesday 31 D

Re: Issues porting KGeography to KF5

2014-01-02 Thread Kevin Ottens
On Thursday 02 January 2014 19:51:17 Albert Astals Cid wrote: > El Dijous, 2 de gener de 2014, a les 19:48:46, Kevin Ottens va escriure: > > On Thursday 02 January 2014 19:45:36 Albert Astals Cid wrote: > > > El Dijous, 2 de gener de 2014, a les 17:36:41, Kevin Ottens va escriure: > > > > On Tuesda

Jenkins build is back to normal : kjsembed_master_qt5 #5

2014-01-02 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: modules for KF5 TP1 release

2014-01-02 Thread Kevin Ottens
On Thursday 02 January 2014 19:18:05 Martin Sandsmark wrote: > Hi! :-D > > On Tue, Dec 31, 2013 at 10:32:22AM +0100, David Faure wrote: > > sonnetmaster > > Can I break API after the TP1 release? I have some cleanups done in Sonnet > (and more ABI breaks underways, missing some virtuals). Ye

Re: Review Request 114726: Make sure ktoolbar_unittest does not depend on global icon settings

2014-01-02 Thread Alex Merry
> On Dec. 30, 2013, 12:31 p.m., David Faure wrote: > > I don't really understand why this fails > > > > IMHO it *did* make sense for the KToolBar unittest to check which icon size > > the toolbars will get by default. > > > > The value of 2 on build.kde.org, for instance, should never neve

Re: Review Request 114727: Unconditionally skip ICU-dependent encoding tests in kcharsettest

2014-01-02 Thread Alex Merry
> On Dec. 30, 2013, 1:09 p.m., David Faure wrote: > > The commit message is a bit misleading btw: these codecs are not missing if > > Qt was compiled without ICU support, but if it was compiled *with* ICU > > support. > > Bug in ICU, it seems, at least for iso-8859-16. > > > > This prompted me

Re: Review Request 114727: Unconditionally skip ICU-dependent encoding tests in kcharsettest

2014-01-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114727/ --- (Updated Jan. 2, 2014, 8:39 p.m.) Status -- This change has been dis

plasma-shell does not start correctly if some paths are set to symlinks

2014-01-02 Thread Jacopo De Simoi
Dear Frameworkers, I encountered a strange issue: while moving around my installation (from SSD to HDD) I created a (symbolic) link from /usr/kf5 to a new location (/scratch/usr/kf5) and left all paths (e.g. QML2_IMPORT_PATH) set to the original location (/usr/kf5). In this case plasma-shel

Re: KF5 Update Meeting Minutes Almost 2014

2014-01-02 Thread Aleix Pol
On Tue, Dec 31, 2013 at 4:29 PM, David Faure wrote: > On Tuesday 31 December 2013 16:17:20 Kevin Ottens wrote: > > Hello everyone, > > > > This is the minutes of the last meeting of 2013. As usual it has been > held > > on #kde-devel at 4pm Paris time. > > > > Were present: apol and myself. > > S