---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115190/#review48357
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115190/
---
(Updated Jan. 27, 2014, 8:14 a.m.)
Status
--
This change has been
On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote:
It's a test, not a demo. If you want, it's for demonstrating the developer
that he did it right, but I wouldn't see it as documentation.
I would rename it to KRecentFilesActionTest
Yes, definitely a manual test (otherwise
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/
---
(Updated Jan. 27, 2014, 9:37 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/
---
(Updated Jan. 27, 2014, 9:43 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115230/
---
(Updated Jan. 27, 2014, 9:54 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115285/#review48360
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115285/
---
(Updated Jan. 27, 2014, 9:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115325/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115264/#review48365
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115264/
---
(Updated Jan. 27, 2014, 11:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115266/
---
(Updated Jan. 27, 2014, 11:42 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115266/#review48366
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115120/#review48367
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115120/
---
(Updated Jan. 27, 2014, 11:43 a.m.)
Status
--
This change has been
See http://build.kde.org/job/kde4support_master_qt5/39/
--
[...truncated 625 lines...]
Generating moc_kmenubar.cpp
Generating moc_kmessageboxmessagehandler.cpp
Generating moc_knumvalidator.cpp
Generating moc_kpassivepopupmessagehandler.cpp
Generating
On Jan. 27, 2014, 7:36 a.m., Kevin Ottens wrote:
Why not... makes me want to ask the same for the other HAVE_FOO we have in
the other frameworks. You might have opened the pandora box. :-)
Martin Gräßlin wrote:
yes the same reasoning applies to all frameworks. Though one could also
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115294/#review48371
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115294/
---
(Updated Jan. 27, 2014, 12:03 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115295/
---
(Updated Jan. 27, 2014, 12:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115296/#review48373
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/#review48374
---
Ship it!
Just one more thing to check, then go ahead and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115123/
---
(Updated Jan. 27, 2014, 12:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115123/#review48375
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48377
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/
---
(Updated Jan. 27, 2014, 12:30 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115330/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115218/
---
(Updated Jan. 27, 2014, 4:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115218/#review48391
---
This review has been submitted with commit
There is an existing page about slitting runtime here:
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization
linked to from http://community.kde.org/Frameworks/Epics
Alex's wiki page looks far more populated.
We should make sure we avoid wiki duplication.
David
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115332/
---
Review request for KDE Frameworks and Aurélien Gâteau.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115268/
---
(Updated Jan. 27, 2014, 4:31 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115336/
---
Review request for KDE Frameworks.
Repository: kservice
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115332/#review48402
---
Looks good, but I would suggest using Python logging module
On Jan. 27, 2014, 5:37 p.m., Aurélien Gâteau wrote:
Looks good, but I would suggest using Python logging module instead of
writing our own. Basic usage should be as simple as:
# setup
import logging
... parse args...
if args.quiet:
minlevel = logging.WARNING
else:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115337/
---
Review request for KDE Frameworks, Aurélien Gâteau and Allen Winter.
On Jan. 27, 2014, 2:23 a.m., Aleix Pol Gonzalez wrote:
It's a test, not a demo. If you want, it's for demonstrating the developer
that he did it right, but I wouldn't see it as documentation.
I would rename it to KRecentFilesActionTest
Kevin Ottens wrote:
Yes, definitely a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/
---
(Updated Jan. 27, 2014, 7:14 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/#review48411
---
This review has been submitted with commit
On Jan. 27, 2014, 12:20 p.m., Alex Merry wrote:
src/kcompletion.h, line 831
https://git.reviewboard.kde.org/r/115206/diff/2/?file=240658#file240658line831
Does doxygen properly generate a link for this without the leading
KCompletion::?
Yes, it does. I've checked in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115343/
---
Review request for KDE Frameworks.
Repository: solid
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115344/
---
Review request for KDE Frameworks and kdewin.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115344/#review48418
---
We use to do so in the CMake files (as more than one source
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
Review request for KDE Frameworks, kdewin and Alex Merry.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115344/
---
(Updated Jan. 27, 2014, 11:22 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48421
---
src/imageformats/pic_write.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48422
---
Just ran a quick test, using the imageconverter tool in the
On Jan. 27, 2014, 10:36 p.m., Alex Merry wrote:
Just ran a quick test, using the imageconverter tool in the tests/
directory. I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115337/#review48424
---
Ship it!
Ship It!
- Allen Winter
On Jan. 27, 2014, 6:10
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115337/
---
(Updated Jan. 27, 2014, 10:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115337/#review48426
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review48427
---
src/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
---
(Updated Jan. 28, 2014, 12:40 a.m.)
Review request for KDE Frameworks
On Jan. 27, 2014, 11:36 p.m., Alex Merry wrote:
Just ran a quick test, using the imageconverter tool in the tests/
directory. I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then
On Jan. 27, 2014, 11:57 p.m., Luigi Toscano wrote:
src/CMakeLists.txt, line 150
https://git.reviewboard.kde.org/r/115209/diff/2/?file=235239#file235239line150
I think you swapped the code for the two conditions (the part with 'cmd
/k' should be inside if (WIN32) I guess
You're
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115347/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115347/#review48448
---
Ship it!
grep -irn xml * gives me nothing, looks unused
-
57 matches
Mail list logo
