Review Request 115863: Improve khtml dependencies

2014-02-18 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115863/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 115584: Remove kfileaudiopreview transitive dependencies

2014-02-18 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115584/ --- (Updated Feb. 18, 2014, 8:15 a.m.) Status -- This change has been

Re: Review Request 115584: Remove kfileaudiopreview transitive dependencies

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115584/#review50130 --- This review has been submitted with commit

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

2014-02-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/#review50136 --- Ping, any comments? - Martin Klapetek On Feb. 13, 2014,

kimageformats test fails on i386

2014-02-18 Thread Jonathan Riddell
I'm getting a fail for kwidgetsaddons Start 1: kimageformats-read-jp2 1/13 Test #1: kimageformats-read-jp2 ...***Failed0.21 sec Only this test fails and only on i386, tried with the latest git. Any ideas? Jonathan ___

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

2014-02-18 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/#review50149 --- Overriding a CMake package like this will just cause all

Re: kimageformats test fails on i386

2014-02-18 Thread Alex Merry
On 18/02/14 15:06, Jonathan Riddell wrote: I'm getting a fail for kwidgetsaddons Start 1: kimageformats-read-jp2 1/13 Test #1: kimageformats-read-jp2 ...***Failed0.21 sec Only this test fails and only on i386, tried with the latest git. Any ideas? Odd. In terms

KF5 Update Meeting Minutes 2014-w8

2014-02-18 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 8 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, alexmerry, dfaure, mck182, mgraesslin, sebas, svuorela, teo, tosky and myself. Announcement: * Alpha 1 is out; * Get ready for alpha 2 end of

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/#review50152 --- This review has been submitted with commit

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

2014-02-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/ --- (Updated Feb. 18, 2014, 3:26 p.m.) Status -- This change has been

Re: Review Request 115658: Also port KWindowSystem::windowInfo to the flags

2014-02-18 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115658/#review50153 --- Ship it! Ship It! - Kevin Ottens On Feb. 11, 2014, 1:30

Review Request 115869: Simplify argument parsing for ecm_generate_headers

2014-02-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115869/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

2014-02-18 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115496/#review50155 --- Ship it! Looks great. Do you plan on a transition period of

Re: Review Request 115496: Rename CMakePackageConfigHelpers to ECMPackageConfigHelpers

2014-02-18 Thread Alex Merry
On Feb. 18, 2014, 3:40 p.m., Sune Vuorela wrote: Looks great. Do you plan on a transition period of more than a week? No. In fact, my aim is to get it done today. The script is a simple sed command. - Alex --- This is an

Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists

2014-02-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/ --- (Updated Feb. 18, 2014, 3:49 p.m.) Review request for Build System,

Re: kimageformats test fails on i386

2014-02-18 Thread Jonathan Riddell
On Tue, Feb 18, 2014 at 03:23:42PM +, Alex Merry wrote: On 18/02/14 15:06, Jonathan Riddell wrote: I'm getting a fail for kwidgetsaddons Start 1: kimageformats-read-jp2 1/13 Test #1: kimageformats-read-jp2 ...***Failed0.21 sec Only this test fails and

Re: Review Request 115869: Simplify argument parsing for ecm_generate_headers

2014-02-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115869/ --- (Updated Feb. 18, 2014, 4:26 p.m.) Review request for Build System,

Re: Review Request 115745: kservice: Allow compiling with MSVC

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115745/#review50166 --- This review has been submitted with commit

Re: Review Request 115745: kservice: Allow compiling with MSVC

2014-02-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115745/ --- (Updated Feb. 18, 2014, 4:49 p.m.) Status -- This change has been

Re: Review Request 115741: Fix MSVC build of kinit

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/#review50168 --- This review has been submitted with commit

Re: Review Request 115741: Fix MSVC build of kinit

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115741/#review50169 --- This review has been submitted with commit

Re: Review Request 115869: Simplify argument parsing for ecm_generate_headers

2014-02-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115869/#review50170 --- Ship it! Ship It! - David Faure On Feb. 18, 2014, 4:26

Re: Review Request 115869: Simplify argument parsing for ecm_generate_headers

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115869/#review50171 --- This review has been submitted with commit

ECM find modules

2014-02-18 Thread Alex Merry
If you have find modules that you think should go into extra-cmake-modules 1.0.0, mention them in this email thread. I would like to have a rule similar to the old kdelibs rule for classes: at least two users, otherwise you may as well just put them in the project's local cmake directory. I did

Re: [sprinter] runners: activities runner ported to Sprinter

2014-02-18 Thread Albert Astals Cid
El Dimarts, 18 de febrer de 2014, a les 18:32:01, Aaron Seigo va escriure: Git commit be5ad03baf3fe327018742a114051377f8eea3c5 by Aaron Seigo. Committed on 18/02/2014 at 18:30. Pushed by aseigo into branch 'master'. activities runner ported to Sprinter can't fully test this one as the

Build failed in Jenkins: kcoreaddons_master_qt5 #27

2014-02-18 Thread KDE CI System
See http://build.kde.org/job/kcoreaddons_master_qt5/27/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace http://build.kde.org/job/kcoreaddons_master_qt5/ws/ Running Prebuild steps

Review Request 115874: Fix unit tests on Windows by adding two expected failures

2014-02-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115874/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Build failed in Jenkins: kwidgetsaddons_master_qt5 #25

2014-02-18 Thread KDE CI System
See http://build.kde.org/job/kwidgetsaddons_master_qt5/25/ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 in workspace http://build.kde.org/job/kwidgetsaddons_master_qt5/ws/ Running Prebuild steps

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/#review50175 --- This review has been submitted with commit

Re: Review Request 115610: Hide private method behind the d-pointer in KLineEdit

2014-02-18 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115610/ --- (Updated Feb. 18, 2014, 8:59 p.m.) Status -- This change has been

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115602/ --- (Updated Feb. 18, 2014, 9:50 p.m.) Review request for KDE Frameworks and

Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/ --- Review request for KDE Frameworks. Repository: kconfig Description

KPassivePopup should be in kwidgets ?

2014-02-18 Thread Sune Vuorela
Hi I was just looking at knotification, and for some reason, KPassivePopup is ended up here. I was quite surprised to see it there, as it is used for 'popping up stuff' all over the place, and isn't really notification specific. Shouldn't it rather be in kwidgets? /Sune - hoping for a widgets

Re: KPassivePopup should be in kwidgets ?

2014-02-18 Thread Martin Klapetek
On Tue, Feb 18, 2014 at 11:21 PM, Sune Vuorela nos...@vuorela.dk wrote: Hi I was just looking at knotification, and for some reason, KPassivePopup is ended up here. I was quite surprised to see it there, as it is used for 'popping up stuff' all over the place, and isn't really notification

Re: KPassivePopup should be in kwidgets ?

2014-02-18 Thread Christoph Feck
On Tuesday 18 February 2014 23:21:53 Sune Vuorela wrote: Hi I was just looking at knotification, and for some reason, KPassivePopup is ended up here. I was quite surprised to see it there, as it is used for 'popping up stuff' all over the place, and isn't really notification specific.

Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-18 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/ --- Review request for Build System, Documentation and KDE Frameworks.

Review Request 115879: DocBookXML has been renamed, use the new exported variables

2014-02-18 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115879/ --- Review request for Documentation and KDE Frameworks. Repository:

Re: KPassivePopup should be in kwidgets ?

2014-02-18 Thread Alex Merry
On 18/02/14 22:46, Christoph Feck wrote: On Tuesday 18 February 2014 23:21:53 Sune Vuorela wrote: Hi I was just looking at knotification, and for some reason, KPassivePopup is ended up here. I was quite surprised to see it there, as it is used for 'popping up stuff' all over the place, and

Re: Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/#review50181 --- Does this have any other users than kdoctools? If not, it

Re: Review Request 115876: More generic DocBookXML - DocBookXML4

2014-02-18 Thread Luigi Toscano
On Feb. 18, 2014, 11:13 p.m., Alex Merry wrote: Does this have any other users than kdoctools? If not, it should probably just move to that module. Even if kde4support ends up using it, I don't view that as a reason to put it in ECM. There are no other use apart from kdoctools and

Re: ECM find modules

2014-02-18 Thread Alex Merry
On 18/02/14 18:09, Alex Merry wrote: If you have find modules that you think should go into extra-cmake-modules 1.0.0, mention them in this email thread. I would like to have a rule similar to the old kdelibs rule for classes: at least two users, otherwise you may as well just put them in

Re: Review Request 115832: Print the diff to stdout on comparison failure

2014-02-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/ --- (Updated Feb. 19, 2014, 7 a.m.) Status -- This change has been

Re: Review Request 115832: Print the diff to stdout on comparison failure

2014-02-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115832/#review50192 --- This review has been submitted with commit