Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- (Updated Feb. 25, 2014, 8:46 a.m.) Review request for Build System, Extra

Re: Review Request 116025: Add documentation about writing find modules

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50781 --- docs/writing-find-modules.md

Re: setting SOVERSION to 5

2014-02-24 Thread Kevin Ottens
On Monday 24 February 2014 20:23:25 šumski wrote: > On Monday 24 of February 2014 16:13:48 Jonathan Riddell wrote: > ... > > > Shall I do this change to the frameworks? > > My opinion as a fellow packager is - please don't. IMHO, now that the > versioning is fully correct, it would be really weir

Review Request 116037: change entities to reflect new branding

2014-02-24 Thread T.C. Hollingsworth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/ --- Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard L

Re: KDocTools history import

2014-02-24 Thread Luigi Toscano
Alex Merry wrote: > I screwed up the history import of the FindDocBook*.cmake files from > e-c-m into KDocTools, so Luigi asked me to do it again. This involves > removing those files, then merging in a more sensible history (that > isn't curtailed like the other one was). > > This can be found a

Re: Review Request 115316: Add demo for KRecentFileList

2014-02-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/ --- (Updated Feb. 24, 2014, 10:05 p.m.) Review request for KDE Frameworks.

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-02-24 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/#review50766 --- src/tools/ksvg2icns/ksvg2icns.cpp

Review Request 116030: Extend tests to cover getConf... calls

2014-02-24 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116030/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review50765 --- src/khelpclient.cpp

Re: setting SOVERSION to 5

2014-02-24 Thread šumski
On Monday 24 of February 2014 16:13:48 Jonathan Riddell wrote: ... > Shall I do this change to the frameworks? My opinion as a fellow packager is - please don't. IMHO, now that the versioning is fully correct, it would be really weird to have soversion 5 at version 4.97.0 Cheers, Hrvoje > Jon

Re: Review Request 116025: Add documentation about writing find modules

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review50727 --- great work! I will happily test it tomorrow for fixing my two

Review Request 116026: Remove the WebP format

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116026/ --- Review request for KDE Frameworks. Repository: kimageformats Descriptio

Re: Review Request 115913: Rename webp.xml to kf5-imagesformats-webp.xml on installation

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115913/ --- (Updated Feb. 24, 2014, 5:04 p.m.) Status -- This change has been ma

Re: Review Request 115913: Rename webp.xml to kf5-imagesformats-webp.xml on installation

2014-02-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115913/#review50721 --- This review has been submitted with commit 89a3e64c0eda9acefd

Review Request 116025: Add documentation about writing find modules

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 115913: Rename webp.xml to kf5-imagesformats-webp.xml on installation

2014-02-24 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115913/#review50718 --- Ship it! Ship It! - Jonathan Riddell On Feb. 20, 2014, 2:1

setting SOVERSION to 5

2014-02-24 Thread Jonathan Riddell
In the tech preview release the libraries were all versioned 5.0.0 with SOVERSION of 5. In alpha 1 that became 4.96.0 with SOVERSION of 4. The SOVERSION will presumably go back to 5 at some point before release. It's quite hassleful to packagers to keep changing the SOVERSION so I propose chang

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Alex Merry
> On Feb. 24, 2014, 2:55 p.m., Alex Merry wrote: > > Same comments as for FindEGL.cmake: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported target

KF5 Update Meeting 2014-w9 Reminder

2014-02-24 Thread Kevin Ottens
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed mes

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Martin Gräßlin
> On Feb. 24, 2014, 3:55 p.m., Alex Merry wrote: > > Same comments as for FindEGL.cmake: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported target

Re: Review Request 116014: Add a FindEgl module

2014-02-24 Thread Alex Merry
> On Feb. 24, 2014, 2:51 p.m., Alex Merry wrote: > > Three things: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported targets in new find modules,

Re: Review Request 116014: Add a FindEgl module

2014-02-24 Thread Martin Gräßlin
> On Feb. 24, 2014, 3:51 p.m., Alex Merry wrote: > > Three things: > > - what projects are using it? I guess KWin is one; any others? > > - it needs to set the DESCRIPTION and URL package properties (from > > FeatureSummary) > > - I've been aiming to create imported targets in new find modules,

extra-cmake-modules maintainership

2014-02-24 Thread Alex Merry
Alex, I seem to have ended up becoming the de facto extra-cmake-modules maintainer. Kevin said that you might interested in taking up the reins again at some point in the future, so I thought I'd check whether you were happy with me taking on the role officially, at least until you feel you have

KDocTools history import

2014-02-24 Thread Alex Merry
I screwed up the history import of the FindDocBook*.cmake files from e-c-m into KDocTools, so Luigi asked me to do it again. This involves removing those files, then merging in a more sensible history (that isn't curtailed like the other one was). This can be found at g...@git.kde.org:clones/kdoc

Re: Review Request 116018: Add a FindWayland module

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/#review50706 --- Same comments as for FindEGL.cmake: - what projects are using

Re: Review Request 116014: Add a FindEgl module

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/#review50705 --- Three things: - what projects are using it? I guess KWin is o

Review Request 116018: Add a FindWayland module

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116018/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake

Re: Problem building using kdesrcbuild

2014-02-24 Thread Hugo Pereira Da Costa
On 02/24/2014 02:19 PM, Martin Klapetek wrote: Hey, it's a cmake bug, follow this to get it sorted for now: http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012005.html Thanks and sorry for the noise. I guess I should read emails to this list more carefully. Cheers -- Marti

Re: Problem building using kdesrcbuild

2014-02-24 Thread Martin Klapetek
Hey, it's a cmake bug, follow this to get it sorted for now: http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/012005.html Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org http

Problem building using kdesrcbuild

2014-02-24 Thread Hugo Pereira Da Costa
Hi, I've been struggling with building kde-runtime and kde-workspace, from head using kdesrcbuild for a couple of hours now. Issue I have with kde-runtime at config step is: CMake Error at /home/hpereira/kf5/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:52 (find_package): Could not

Re: Review Request 116014: Add a FindEgl module

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- (Updated Feb. 24, 2014, 2:08 p.m.) Review request for KDE Frameworks and

Review Request 116014: Add a FindEgl module

2014-02-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116014/ --- Review request for KDE Frameworks. Repository: extra-cmake-modules Desc

Re: Runtime conflict with KF5Plasma and KDE 4 in same prefix

2014-02-24 Thread Michael Palimaka
On 02/24/2014 05:41 AM, Martin Graesslin wrote: > On Monday 24 February 2014 05:33:37 Michael Palimaka wrote: >> Hi, >> >> I have run into a strange issue when KDE 4 and KF5Plasma are installed >> into the same prefix (I can reliably reproduce the issue by >> installing/uninstalling KF5Plasma and r

Re: kprintutils - next steps

2014-02-24 Thread Alex Merry
On 23/02/14 19:02, John Layt wrote: > 2) Copy code from kprintutils to kde4support > - Do we bother to keep the history? > - Where do we put it? I would be inclined to keep the history. I can dig up the magic to do that if you like. Alex ___ Kde-frame

Review Request 116012: Inline deprecated methods, and silence false positives in tests

2014-02-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116012/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #57

2014-02-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #56

2014-02-24 Thread KDE CI System
See Changes: [mgraesslin] Follow Qt's OpenGL compile flags -- Started by upstream project "plasma-framework_master_qt5" build number 56 originally caused by:

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

2014-02-24 Thread Frank Reininghaus
> On Feb. 15, 2014, 7:38 p.m., David Faure wrote: > > src/khistorycombobox.cpp, line 508 > > > > > > infinite recursion! > > > > Sounds like a unittest for reset() should be added. > > David Gil Oliva w

Re: Porting feedback: Hiding the Help button in KConfigDialog

2014-02-24 Thread David Faure
On Sunday 23 February 2014 20:12:05 Kevin Krammer wrote: > On Sunday, 2014-02-23, 18:41:38, David Faure wrote: > > On Sunday 23 February 2014 14:17:29 Kevin Krammer wrote: > > > But usage of the button box already leaks, there are two protected > > > accessors to it. > > > > In which class? You l

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-24 Thread Kevin Krammer
> On Feb. 22, 2014, 3:24 p.m., Michael Palimaka wrote: > > If this is tier 1 now, please don't forget to update the wiki and the yaml > > file. > > Hrvoje Senjan wrote: > Also find_dependency(KF5JS "@KF5_VERSION@") can go away =) Both good catches. All in now - Kevin --