Re: Does KKeyserver QT_TR_NOOP work?

2014-03-31 Thread Martin Gräßlin
On Monday 31 March 2014 00:09:18 Albert Astals Cid wrote: Running lupdate complains so I'm not sure it does /home/scripty/prod/git- unstable/frameworks_kwindowsystem/src/kkeyserver_x11.cpp:88: Class 'KKeyServer' lacks Q_OBJECT macro on a quick check it looks like unused code. Will try to

Review Request 117196: Remove unused global variable from kkeyserver_x11.cpp

2014-03-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Review Request 117197: Fix warnings caused by changing to enum types in NET classes

2014-03-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Lots of duplicated catalogs

2014-03-31 Thread Aurélien Gâteau
I am on it. On Sun, Mar 30, 2014, at 15:15, Albert Astals Cid wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot $ find -name

Re: Lots of duplicated catalogs

2014-03-31 Thread Aurélien Gâteau
On Sun, Mar 30, 2014, at 15:15, Albert Astals Cid wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot Renamed to kdecalendarsystems5.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot

Re: Lots of duplicated catalogs

2014-03-31 Thread Burkhard Lück
Am Montag, 31. März 2014, 02:40:48 schrieb Aurélien Gâteau: On Sun, Mar 30, 2014, at 15:15, Albert Astals Cid wrote: $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Can't find this one, neither on my machine nor using lxr. Do you know where it

Translation support in Qt-translation-based frameworks

2014-03-31 Thread Aurélien Gâteau
Hi, I just committed the necessary build system changes to enable all Qt-translation-based frameworks to build, install and load their translations. This means the following frameworks: kauth kbookmarks kcodecs kcompletion kcoreaddons kcrash kdbusaddons kdesignerplugin kdnssd kglobalaccel

Re: Review Request 116037: change entities to reflect new branding

2014-03-31 Thread Kevin Ottens
On March 4, 2014, 8:48 p.m., Kevin Ottens wrote: Ship It! Kevin Ottens wrote: Any news? Anything blocking this patch from being committed? T.C. Hollingsworth wrote: Well I still need to fix the i18n issues and change up the entities a little bit to reflect the feedback to

Re: Review Request 117070: remove check for Linux kernel = 2.6.14

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117070/#review54680 --- Ship it! Ship It! - Kevin Ottens On March 25, 2014, 10:22

Re: Review Request 117122: Cut the dependency between country files and KIO

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117122/#review54681 --- Ship it! Ship It! - Kevin Ottens On March 27, 2014, 6:42

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Alex Merry
On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/#review54682 --- Ship it! Ship It! - Kevin Ottens On March 28, 2014, 7:24

Re: Review Request 117151: use renamed kf5_entry.desktop file

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117151/#review54683 --- Ship it! Ship It! - Kevin Ottens On March 28, 2014, 7:26

Re: Review Request 117134: Use QLocale to list all languages

2014-03-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/ --- (Updated March 31, 2014, 2:40 p.m.) Status -- This change has been

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Aurélien Gâteau
On Mon, Mar 31, 2014, at 7:38, Alex Merry wrote: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Good idea. Aurélien

Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/#review54685 --- Not sure about renaming that one, it's perfectly fine to have

Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4

2014-03-31 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated March 31, 2014, 2:44 p.m.) Review request for KDE Frameworks

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54686 --- Couple of nitpicks, overall I like where this is going.

Re: Review Request 117190: Improve tests

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/#review54687 --- Ship it! Ship It! - Kevin Ottens On March 30, 2014, 3:15

Re: Review Request 117190: Improve tests

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/#review54689 --- This review has been submitted with commit

Re: Review Request 117190: Improve tests

2014-03-31 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- (Updated March 31, 2014, 2:52 p.m.) Status -- This change has been

Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-31 Thread Kevin Ottens
On March 27, 2014, 3:47 p.m., Kevin Ottens wrote: src/kjsembed/CMakeLists.txt, line 75 https://git.reviewboard.kde.org/r/117012/diff/1/?file=256496#file256496line75 Agreed, that should be the preferred way. Note that some other frameworks probably carry the same mistake

Re: Review Request 117196: Remove unused global variable from kkeyserver_x11.cpp

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/#review54692 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 7:45

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 2:55 p.m.) Review request for KDE Frameworks

Re: Review Request 117197: Fix warnings caused by changing to enum types in NET classes

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/#review54693 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 8:17

Re: Review Request 117150: use renamed kf5_entry.desktop file

2014-03-31 Thread Kevin Ottens
On March 31, 2014, 2:39 p.m., Kevin Ottens wrote: Ship It! Actually scrap that, seeing the confusion around those files I might have been mistaken myself. - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 117151: use renamed kf5_entry.desktop file

2014-03-31 Thread Kevin Ottens
On March 31, 2014, 2:39 p.m., Kevin Ottens wrote: Ship It! Actually scrap that, seeing the confusion around those files I might have been mistaken myself. - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
On March 31, 2014, 2:49 p.m., Kevin Ottens wrote: src/plugin/kpluginloader.h, line 305 https://git.reviewboard.kde.org/r/117185/diff/2/?file=258191#file258191line305 Why is this class all inlined? Because it's a pretty trivial container class. It was patterned off things like

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 3:34 p.m.) Review request for KDE Frameworks,

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54701 --- Ship it! Ship It! - Kevin Ottens On March 31, 2014, 3:34

kcrash test failure

2014-03-31 Thread Jonathan Riddell
Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 31, 2014, 4:23 p.m.) Status -- This change has been

Re: Review Request 117185: Remove KPluginLoader dependency on KService

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/#review54704 --- This review has been submitted with commit

Build failed in Jenkins: khtml_master_qt5 #66

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/khtml_master_qt5/66/ -- [...truncated 175 lines...] == Commencing the Build Scanning dependencies of target khtmlimagepart_automoc Scanning dependencies of target kmultipart_automoc Scanning dependencies of target

Build failed in Jenkins: kde4support_master_qt5 #103

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/kde4support_master_qt5/103/ -- [...truncated 989 lines...] [ 42%] Building CXX object src/CMakeFiles/KF5KDE4Support.dir/kdeui/kdialogbuttonbox.cpp.o [ 43%] Building CXX object

Re: kcrash test failure

2014-03-31 Thread Michael Palimaka
On 04/01/2014 03:21 AM, Jonathan Riddell wrote: Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Jonathan I can reproduce consistently on amd64. ___ Kde-frameworks-devel mailing list

Build failed in Jenkins: kparts_master_qt5 #44

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/kparts_master_qt5/44/ -- [...truncated 60 lines...] kconfig - Branch master ki18n - Branch master kcompletion - Branch master kxmlgui - Branch master == Applying Patches === No patches to apply == Syncing

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #220

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/220/ -- [...truncated 734 lines...] [ 49%] Building CXX object

Re: Review Request 117197: Fix warnings caused by changing to enum types in NET classes

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/#review54705 --- This review has been submitted with commit

Re: Review Request 117196: Remove unused global variable from kkeyserver_x11.cpp

2014-03-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117196/ --- (Updated March 31, 2014, 4:48 p.m.) Status -- This change has been

Re: Review Request 117197: Fix warnings caused by changing to enum types in NET classes

2014-03-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117197/ --- (Updated March 31, 2014, 4:48 p.m.) Status -- This change has been

Jenkins build is back to normal : kparts_master_qt5 #45

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/kparts_master_qt5/45/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kde4support_master_qt5 #105

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/kde4support_master_qt5/105/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : khtml_master_qt5 #67

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/khtml_master_qt5/67/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #222

2014-03-31 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/222/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-31 Thread Dominik Haumann
On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote:

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-31 Thread Ben Cooksley
On Tue, Apr 1, 2014 at 9:34 AM, Dominik Haumann dhaum...@kde.org wrote: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/#review54724 --- Ship it! Funny that somehow errno manages to never use CAN

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Albert Astals Cid
El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release time from the kde translation infrastructure. Should go in .gitignore, yes? Why? We have been living without this in

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-03-31 Thread Albert Astals Cid
El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Albert Astals Cid
El Dilluns, 31 de març de 2014, a les 07:30:29, Aurélien Gâteau va escriure: Hi, I just committed the necessary build system changes to enable all Qt-translation-based frameworks to build, install and load their translations. This means the following frameworks: kauth kbookmarks

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/#review54726 --- This review has been submitted with commit

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/#review54725 --- This review has been submitted with commit

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 10:29 p.m.) Status -- This change has been

Re: Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- (Updated March 31, 2014, 10:29 p.m.) Status -- This change has been

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Albert Astals Cid
El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the po/ dir, it will be generated at release

Review Request 117268: Deprecate the RESTORE macro

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Alex Merry
On 01/04/14 00:14, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry va escriure: On 31/03/14 15:30, Aurélien Gâteau wrote: Do not commit the

Re: Translation support in Qt-translation-based frameworks

2014-03-31 Thread Albert Astals Cid
El Dimarts, 1 d'abril de 2014, a les 00:22:14, Alex Merry va escriure: On 01/04/14 00:14, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 23:46:40, Alex Merry va escriure: On 31/03/14 23:22, Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 15:38:39, Alex Merry

Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly

2014-03-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/#review54730 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 31, 2014,

Review Request 117271: KIconDialog: do not connect to a signal that does not exist

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Review Request 117272: Use KIconDialog instead of running kdialog to choose icons

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/#review54731 --- This review has been submitted with commit

Re: Review Request 117269: Use KEMailSettings, instead of parsing configurations directly

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117269/ --- (Updated April 1, 2014, 12:52 a.m.) Status -- This change has been

Re: Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/#review54733 --- Ship it! Good catch! We should figure out how to figure out

Re: Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Alex Merry
On April 1, 2014, 1:07 a.m., Aleix Pol Gonzalez wrote: Good catch! We should figure out how to figure out these problems somehow... How did you notice it? Grepping everything for kde.*4 (see http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References) -

Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 117272: Use KIconDialog instead of running kdialog to choose icons

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/ --- (Updated April 1, 2014, 1:18 a.m.) Status -- This change has been

Re: Review Request 117272: Use KIconDialog instead of running kdialog to choose icons

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117272/#review54736 --- This review has been submitted with commit

Re: Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/#review54738 --- This review has been submitted with commit

Re: Review Request 117273: Fix i18n in ksendbugmail

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117273/ --- (Updated April 1, 2014, 1:19 a.m.) Status -- This change has been

Review Request 117275: Deprecate the catalog name stuff from KAboutData

2014-03-31 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael