Review Request 118158: Always set src_dir to a not-empty value ('.')

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118158/ --- Review request for Documentation, KDE Frameworks, Alex Merry, and Aurélien

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/ --- (Updated May 15, 2014, 11:20 p.m.) Status -- This change has been ma

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/#review58039 --- This review has been submitted with commit e7f2ed9ac96b1498b3

Re: Review Request 117125: start_kdeinit: Use capabilities instead of SUID

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117125/ --- (Updated May 15, 2014, 11:12 p.m.) Review request for KDE Frameworks, And

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/ --- (Updated May 15, 2014, 9:10 p.m.) Status -- This change has been mar

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58035 --- This review has been submitted with commit aa75425637604a87d5

Re: Review Request 118115: adapt to ecm_add_test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118115/ --- (Updated May 15, 2014, 8:37 p.m.) Status -- This change has been mar

Re: Review Request 118115: adapt to ecm_add_test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118115/#review58033 --- This review has been submitted with commit 6c56d494f8dfaf157e

Re: Review Request 118147: fix running ECMKDEModules test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/ --- (Updated May 15, 2014, 7:03 p.m.) Status -- This change has been mar

Re: Review Request 118147: fix running ECMKDEModules test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/#review58032 --- This review has been submitted with commit edbefdaa47ba2af0f6

Re: Review Request 118147: fix running ECMKDEModules test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/#review58023 --- Ship it! Ship It! - Alex Merry On May 15, 2014, 2:32 p.m.,

Re: Review Request 118116: Rename DBus interfaces to use new namespaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/#review58020 --- Ship it! Ship It! - David Edmundson On May 13, 2014, 4:25

Re: Review Request 118104: Fix tests in kio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118104/#review58019 --- Ship it! Ship It! - David Edmundson On May 12, 2014, 4:45

Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/#review58018 --- You probably want to .join(", ") with a space so it can wrap.

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote: > > Note that this broke lots of KAboutData uses. > > > > Please, when doing such changes remember there's things already ported. > > Michael Pyne wrote: > Yes, my apologies. > > But the pain this change would cause if implem

Re: Review Request 117919: kcoreaddons: Move license-related KAboutData enums to KAboutLicense.

> On May 14, 2014, 10:48 a.m., Aleix Pol Gonzalez wrote: > > Note that this broke lots of KAboutData uses. > > > > Please, when doing such changes remember there's things already ported. Yes, my apologies. But the pain this change would cause if implemented (and the inconsistent nature of hav

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58012 --- Ship it! Ship It! - Marco Martin On May 15, 2014, 2:57 p.m

Re: Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/#review58009 --- Ship it! Ship It! - Luigi Toscano On May 15, 2014, 5:18 p.

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/ --- (Updated May 15, 2014, 3:19 p.m.) Status -- This change has been mar

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58007 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 2:57

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review58006 --- Ship it! Ship It! - Patrick von Reth On May 15, 2014, 3 p.

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review58004 --- This review has been submitted with commit df8f37b5904557331f

Review Request 118156: Make SUBDIR argument mandatory in kdoctools_create_handbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118156/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review57999 --- Ship it! Thanks doc/khelpcenter/CMakeLists.txt

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review57998 --- Ship it! Ship It! - Luigi Toscano On May 15, 2014, 4:40 p.

Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: plasma-

Review Request 118153: remove unneeded file which collides with kf5plasma exports

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: plasma-

Re: Review Request 118119: remove unneeded header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/ --- (Updated May 15, 2014, 2:54 p.m.) Status -- This change has been mar

Re: Review Request 118119: remove unneeded header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/#review57995 --- This review has been submitted with commit c68db518c8ea2199ae

Re: Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/#review57993 --- By the way, I found the offending entries with: "find . -name

Review Request 118149: Make sure KHelpCenter documentation goes to its own subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118149/ --- Review request for Documentation and KDE Frameworks. Repository: khelpcen

Review Request 118147: fix running ECMKDEModules test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118147/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

Jenkins build became unstable: kdelibs_stable #1089

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118101: fixed windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118101/ --- (Updated May 15, 2014, 9:30 a.m.) Status -- This change has been mar

Re: Review Request 118101: fixed windows build

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118101/#review57977 --- This review has been submitted with commit 4f30494d9544bfb21d