Hi all,
while trying to get rid of kdelibs4support I stumbled [1] over
KIntSpinBox::setSuffix which allows to set a plural aware suffix. The
recommendation is to port to QSpinBox, but as far as I can see there is
suitable replacement for the plural aware suffix.
What is the best solution to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118323/#review58767
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118323/
---
(Updated May 30, 2014, 6 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118352/
---
(Updated May 30, 2014, 6:09 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118352/#review58768
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118234/
---
(Updated May 30, 2014, 8:15 a.m.)
Review request for KDE Frameworks and
On Wednesday 28 May 2014 19:33:42 Aaron J. Seigo wrote:
int endPoint = ds.device()-pos();
ds.device()-seek(savePoint);
ds 0;
ds.device()-seek(endPoint);
ds 1337;
++records;
This could break if QDataStream decides to buffer the changes, i.e. not flush
before you
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/
---
Review request for KDE Frameworks and Christoph Feck.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/#review58781
---
Ship it!
Good catch, merci! Any chance this fixes bug
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/#review58782
---
src/kicontheme.cpp
On May 30, 2014, 12:40 p.m., Christoph Feck wrote:
Good catch, merci! Any chance this fixes bug 330845?
Yup, it does. I had Eike especially test this for his comment #2 on that bug,
he says this fixes the problem :)
- Martin
---
On May 30, 2014, 12:45 p.m., Aleix Pol Gonzalez wrote:
src/kicontheme.cpp, line 480
https://git.reviewboard.kde.org/r/118415/diff/1/?file=276419#file276419line480
The iconPath call doesn't look trivial. I don't think we want the call
twice, put it in a variable maybe?
Fwiw, that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/#review58788
---
This review has been submitted with commit
On May 30, 2014, 4:10 p.m., Christoph Feck wrote:
Good catch, merci! Any chance this fixes bug 330845?
Martin Klapetek wrote:
Yup, it does. I had Eike especially test this for his comment #2 on that
bug, he says this fixes the problem :)
This fixes bug indeed but scales up icons
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118415/
---
(Updated May 30, 2014, 10:55 a.m.)
Status
--
This change has been
On May 30, 2014, 4:10 p.m., Christoph Feck wrote:
Good catch, merci! Any chance this fixes bug 330845?
Martin Klapetek wrote:
Yup, it does. I had Eike especially test this for his comment #2 on that
bug, he says this fixes the problem :)
Bhushan Shah wrote:
This fixes bug
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118403/#review58790
---
Ship it!
Ship It!
- Alex Merry
On May 29, 2014, 4:09
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118404/#review58791
---
Ship it!
Ship It!
- Alex Merry
On May 29, 2014, 4:21
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118425/
---
Review request for KDE Frameworks.
Repository: kdelibs4support
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118404/
---
(Updated May 30, 2014, 5:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118404/#review58833
---
This review has been submitted with commit
See http://build.kde.org/job/kross_master_qt5/59/changes
Changes:
[hrvoje.senjan] Make sure krossqtsplugin is really treated as plugin
--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118403/
---
(Updated May 30, 2014, 5:55 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118403/#review58834
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118270/
---
(Updated May 31, 2014, 2:07 a.m.)
Review request for Documentation, KDE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/
---
(Updated May 30, 2014, 11:42 p.m.)
Review request for KDE Frameworks,
26 matches
Mail list logo
