Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59483 --- Ship it! Excellent, thanks! Just a couple minor things, then

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 7:21 a.m., John Layt wrote: > > src/core/kconfig.cpp, line 98 > > > > > > The bcp47Name() is a complicated beast that could add lots of other > > bits on like script to use, etc. I would stick

Re: Jenkins build became unstable: kcoreaddons_master_qt5 #104

On June 6, 2014 03:36:43 PM KDE CI System wrote: > See I've been trying to figure out what caused this issue, but the test passes perfectly on my local systems. Is there any information on what the KDE CI runs for the tests, for insta

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

> On June 6, 2014, 10:34 p.m., David Faure wrote: > > Interestingly, I had a benchmark to compare a number of data structures for > > UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That > > benchmark is the commented-out "newApiPerformance()" method in jobtest.cpp. > > > > I j

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review59479 --- Interestingly, I had a benchmark to compare a number of data s

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

On 06/06/14 20:29, David Faure wrote: > On Saturday 10 May 2014 10:28:43 Alex Merry wrote: >> Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. >> Committed on 10/05/2014 at 10:26. >> Pushed by alexmerry into branch 'master'. >> >> Revert "use the NAME_PREFIX only for the test, not

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

On Saturday 10 May 2014 10:28:43 Alex Merry wrote: > Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. > Committed on 10/05/2014 at 10:26. > Pushed by alexmerry into branch 'master'. > > Revert "use the NAME_PREFIX only for the test, not for the executable" I didn't follow the fu

Re: Review Request 117974: Some more KArchive examples

> On May 12, 2014, 3:16 p.m., Kevin Ottens wrote: > > examples/bzip2gzip/main.cpp, line 74 > > > > > > Maybe a better idea to use a loop to avoid the readAll? I know that's > > an example which needs to be kept s

Re: Review Request 117974: Some more KArchive examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/ --- (Updated June 6, 2014, 7:15 p.m.) Review request for KDE Frameworks. Ch

Jenkins build became unstable: kcoreaddons_master_qt5 #104

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 6, 2014, 3:33 p.m.) Status -- This change has been mar

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/ --- (Updated June 6, 2014, 3:33 p.m.) Status -- This change has been mar

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59457 --- This review has been submitted with commit 4d69bd9dd5e6bbd55f

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59456 --- This review has been submitted with commit d56f01760138fd8cd2

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/#review59426 --- This review has been submitted with commit f23fb35f2daed46710

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/ --- (Updated June 6, 2014, 12:31 p.m.) Status -- This change has been ma

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/#review59425 --- Ship it! Only for the documentation. We abbreviate in code al

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118561/ --- (Updated June 6, 2014, 2:02 p.m.) Review request for KDE Frameworks and C

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 6, 2014, 1:43 p.m.) Review request for KDE Frameworks and J

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 1:37 p.m., Martin Gräßlin wrote: > > This change seems to break the KConfigTest::testMerge() well not really, it depends on the locale whether it breaks. If I switch to en it succeeds. - Martin --- This is an automat

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59416 --- This change seems to break the KConfigTest::testMerge() - Mar

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 6, 2014, 1:33 p.m.) Review request for KDE Frameworks and J

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59415 --- src/core/kconfig.cpp

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

> On June 5, 2014, 10:22 p.m., Christoph Feck wrote: > > src/kiconloader.h, line 209 > > > > > > Are we still allowed to break binary compatibility? If not, please > > create a separate call. > > Martin Klapete

Re: KIO directory listing - CPU slows down SSD

On Fri, Jun 6, 2014 at 11:10 AM, Aaron J. Seigo wrote: > On Monday, June 2, 2014 20:54:11 Mark Gaiser wrote: >> On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: >> > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: >> >> On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo >> But don't you

Re: Review Request 118561: Allow passing custom theme base path together with custom app themes

> On June 5, 2014, 10:22 p.m., Christoph Feck wrote: > > Thanks Martin for looking at the issue. > > > > Just one question: Is plasmashell the only application which needs to > > include the additional search path, or does every application wanting a > > tray icon call the addAppDir() function

Re: KIO directory listing - CPU slows down SSD

On Monday, June 2, 2014 20:54:11 Mark Gaiser wrote: > On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: > > On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: > >> On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo But don't you just move logic to the slave that way? yes and no. sorting an

Re: Review Request 118566: KAcceleratorManager: ignore Designer text fields

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118566/ --- (Updated June 6, 2014, 8:02 a.m.) Status -- This change has been mar

Re: Review Request 118566: KAcceleratorManager: ignore Designer text fields

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118566/#review59379 --- This review has been submitted with commit 7136d783609f4a12ff

Re: Review Request 118458: Fix KDirWatch to act more reliably against various backends.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118458/#review59377 --- Ship it! I guess you used QFile::link wrongly in your attempt

Re: KIO directory listing - CPU slows down SSD

On Tuesday, June 3, 2014 00:11:51 Mark Gaiser wrote: > We should do this as a gsoc project. Since this would be very unless it is a very gifted student, this is almost certainly outside the realm of reason for a GSoC project. -- Aaron J. Seigo signature.asc Description: This is a digitally sig