Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

2014-06-07 Thread John Layt
On June 6, 2014, 12:21 p.m., John Layt wrote: src/core/kconfig.cpp, line 98 https://git.reviewboard.kde.org/r/118564/diff/1/?file=279088#file279088line98 The bcp47Name() is a complicated beast that could add lots of other bits on like script to use, etc. I would stick with

Re: Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/#review59505 --- Ship it! Ship It! - David Faure On June 3, 2014, 4:53

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59506 --- Very nice. The question of why not in Qt hasn't been

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59507 --- Ship it! Ship It! - David Faure On June 6, 2014, 12:39

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-06-07 Thread David Faure
On June 6, 2014, 10:34 p.m., David Faure wrote: Interestingly, I had a benchmark to compare a number of data structures for UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That benchmark is the commented-out newApiPerformance() method in jobtest.cpp. I just extended

Jenkins build became unstable: ktexteditor_master_qt5 #420

2014-06-07 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/420/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-06-07 Thread David Faure
On June 6, 2014, 10:34 p.m., David Faure wrote: Interestingly, I had a benchmark to compare a number of data structures for UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That benchmark is the commented-out newApiPerformance() method in jobtest.cpp. I just extended

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-06-07 Thread David Faure
On June 6, 2014, 10:34 p.m., David Faure wrote: Interestingly, I had a benchmark to compare a number of data structures for UDSEntry (which made me turn the Qt3 QList into the Qt4 QHash). That benchmark is the commented-out newApiPerformance() method in jobtest.cpp. I just extended

Re: Jenkins build became unstable: ktexteditor_master_qt5 #420

2014-06-07 Thread David Faure
On Saturday 07 June 2014 13:51:17 KDE CI System wrote: See http://build.kde.org/job/ktexteditor_master_qt5/420/changes The following tests FAILED: 43 - indenttest (Timeout) Not sure what happened after PASS : IndentTest::testPascal(case6) ... -- David Faure, fa...@kde.org,

Locale Name Primer

2014-06-07 Thread John Layt
Locale Names. A quick primer on Locale Names, seeing as we've had a few issues in the last couple of days. I can't claim perfect knowledge, so feel free to point out where I am wrong :-) TL;DR: * Don't use QLocale::bcp47Name(). * Use QLocale::name(), but may need to modify the results. * You

Re: Jenkins build became unstable: ktexteditor_master_qt5 #420

2014-06-07 Thread Alex Merry
On 07/06/14 15:40, David Faure wrote: On Saturday 07 June 2014 13:51:17 KDE CI System wrote: See http://build.kde.org/job/ktexteditor_master_qt5/420/changes The following tests FAILED: 43 - indenttest (Timeout) Not sure what happened after PASS : IndentTest::testPascal(case6)

Re: Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

2014-06-07 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/ --- (Updated June 7, 2014, 3:04 p.m.) Status -- This change has been

Re: Review Request 118499: Put kparts into a kf5/parts subdirectory of the plugins dir

2014-06-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118499/#review59513 --- This review has been submitted with commit

Re: Jenkins build became unstable: ktexteditor_master_qt5 #420

2014-06-07 Thread Alex Merry
On 07/06/14 16:03, Alex Merry wrote: On 07/06/14 15:40, David Faure wrote: On Saturday 07 June 2014 13:51:17 KDE CI System wrote: See http://build.kde.org/job/ktexteditor_master_qt5/420/changes The following tests FAILED: 43 - indenttest (Timeout) Not sure what happened after PASS

Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/ --- Review request for KDE Frameworks, Kevin Ottens, Michael Pyne, and Stephen

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

2014-06-07 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/#review59515 --- Ship it! Ship It! - Kevin Ottens On June 7, 2014, 3:12

Re: kdesrc-build not honoring

2014-06-07 Thread Mark Gaiser
On Sat, Jun 7, 2014 at 9:40 PM, Mark Gaiser mark...@gmail.com wrote: Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile frameworks. However, every CMakeCache.txt file gets:

Re: kdesrc-build not honoring

2014-06-07 Thread David Faure
On Saturday 07 June 2014 21:40:01 Mark Gaiser wrote: Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile frameworks. However, every CMakeCache.txt file gets:

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/ --- (Updated June 7, 2014, 8:24 p.m.) Status -- This change has been

Re: Review Request 118603: Remove data race on boolean by removing qRegisterMetaType call altogether.

2014-06-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118603/#review59524 --- This review has been submitted with commit

Re: kdesrc-build not honoring

2014-06-07 Thread Mark Gaiser
On Sat, Jun 7, 2014 at 10:23 PM, David Faure fa...@kde.org wrote: On Saturday 07 June 2014 21:40:01 Mark Gaiser wrote: Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile

Review Request 118612: Fix KDirWatch's unit tests on certain file system.

2014-06-07 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description