Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: > > kcms/translations/kcmtranslations.cpp, line 49 > > > > > > Why are you having John's name translated? ;) Because he will be ??? in my language. -

Jenkins build is back to stable : kcoreaddons_master_qt5 #107

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/ --- (Updated June 13, 2014, 9:57 p.m.) Status -- This change has been ma

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/ --- (Updated June 13, 2014, 5:57 p.m.) Review request for KDE Frameworks. C

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/#review60049 --- This review has been submitted with commit ac25d969f92541ad72

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/#review60050 --- This review has been submitted with commit a0c1b1c2b263bc7d0e

Re: Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/ --- (Updated June 13, 2014, 3:29 p.m.) Status -- This change has been ma

Re: Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/#review60020 --- This review has been submitted with commit d6bcd49943e56bd48b

Re: Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/#review60014 --- Ship it! Seems good to me. - Aleix Pol Gonzalez On June 13

Re: Review Request 118680: Reorder Tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118680/ --- (Updated June 13, 2014, 3:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 118680: Reorder Tests

> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote: > > autotests/CMakeLists.txt, line 53 > > > > > > Why did you need to create a separate call to ecm_add_test? > > > > If it's for the target_inclu

Re: Review Request 118698: Use correct type for QDBusReply when calling Activate.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118698/#review59997 --- Ship it! Ship It! - Aurélien Gâteau On June 12, 2014, 7 p.

Re: Review Request 118680: Reorder Tests

> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote: > > autotests/CMakeLists.txt, line 53 > > > > > > Why did you need to create a separate call to ecm_add_test? > > > > If it's for the target_inclu

Re: Review Request 118723: switch to Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/ --- (Updated June 13, 2014, 12:21 p.m.) Status -- This change has been m

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:49 a.m., Martin Gräßlin wrote: > > kcms/translations/CMakeLists.txt, line 13 > > > > > > new code shouldn't use kdelibs4support There doesn't seem to be an equivalent for translation change

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59968 --- kcms/translations/CMakeLists.txt

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Review Request 118725: use renamed .direcory files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118723: switch to Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/#review59962 --- Ship it! Ship It! - Marco Martin On June 13, 2014, 10:44 a

Review Request 118723: switch to Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59954 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59952 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59949 --- +9000 for the ever present comments! kcms/translations/kcmtr

Re: Review Request 118690: Introduce a KLocalizedTranslator

> On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Wher

Re: Review Request 118612: Fix KDirWatch's unit tests on certain file system.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118612/#review59939 --- Ship it! src/lib/io/kdirwatch.cpp

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

> On June 12, 2014, 7:23 p.m., Aleix Pol Gonzalez wrote: > > Would it make sense to backport that change to kdelibs4? Just looked at kdelibs4 code: the bug cannot happen there because finished() is always emitted after okClicked(). (in kdelibs4 all of those were handled by KDialog) - Aurélie

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/ --- (Updated June 13, 2014, 7:41 a.m.) Status -- This change has been ma

Re: Review Request 118639: KCMultiDialog: Fix crash when clicking OK

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118639/#review59933 --- This review has been submitted with commit cc99fac3af737619ea