Re: Review Request 118614: Make KIO thread-safe

On June 8, 2014, 1:20 p.m., Thiago Macieira wrote: QDBusConnection is supposed to be threadsafe. David Faure wrote: It's definitely not... https://bugreports.qt-project.org/browse/QTBUG-39528 Thiago, can we agree on using KDBusConnectionPool for now, until the races described in

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 14, 2014, 8:24 a.m.) Review request for KDE Frameworks,

Re: Review Request 118667: KCrash: call setgroups(0, 0) before calling setgid()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118667/#review60065 --- Ship it! Hopefully we never get into this code as root

Re: Review Request 118716: New Translations KCM

On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: kcms/translations/kcmtranslations.cpp, line 49 https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line49 Why are you having John's name translated? ;) Chusslove Illich wrote: Because he will be ???

Re: Review Request 118716: New Translations KCM

On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: kcms/translations/kcmtranslations.cpp, line 49 https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line49 Why are you having John's name translated? ;) Chusslove Illich wrote: Because he will be ???

Re: Review Request 118716: New Translations KCM

On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: kcms/translations/kcmtranslations.cpp, line 49 https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line49 Why are you having John's name translated? ;) Chusslove Illich wrote: Because he will be ???

Review Request 118739: Make KSharedConfig thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/ --- Review request for KDE Frameworks and Matthew Dawson. Repository:

Re: [extra-cmake-modules] modules: Revert use the NAME_PREFIX only for the test, not for the executable

On 07/06/14 23:31, Alex Merry wrote: OK, since this seems to be what pretty much everyone who has said anything to me about this wants, let's make the name prefix only for the test name, then. I won't have time until Friday. If anyone wants to create an RR for it before then, I'll just say

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60067 --- autotests/kdesktopfiletest.cpp

Re: Review Request 118614: Make KIO thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60074 --- Ship it! Despite my lack of knowledge on the code, it makes

Re: Review Request 118698: Use correct type for QDBusReply when calling Activate.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118698/#review60075 --- Ship it! Ship It! - David Faure On June 12, 2014, 5 p.m.,

Re: Review Request 118614: Make KIO thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60077 --- Ship it! Would have never guessed it required so little

Review Request 118740: Use standard message box icon size in password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/ --- Review request for KDE Frameworks and David Edmundson. Bugs: 336141

Re: Review Request 118698: Use correct type for QDBusReply when calling Activate.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118698/ --- (Updated June 14, 2014, 12:01 p.m.) Status -- This change has been

Re: Review Request 118546: No symlink to common/ directory for documentation common files (broken, now unused, UNIX only)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118546/#review60085 --- Ping? - Luigi Toscano On June 5, 2014, 12:29 a.m., Luigi

Re: Review Request 118614: Make KIO thread-safe

On June 8, 2014, 1:20 p.m., Thiago Macieira wrote: QDBusConnection is supposed to be threadsafe. David Faure wrote: It's definitely not... https://bugreports.qt-project.org/browse/QTBUG-39528 David Faure wrote: Thiago, can we agree on using KDBusConnectionPool for now, until

Re: Review Request 118546: No symlink to common/ directory for documentation common files (broken, now unused, UNIX only)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118546/#review60088 --- Ship it! If you say so :-) - David Faure On June 4, 2014,

Re: Review Request 118614: Make KIO thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/ --- (Updated June 14, 2014, 4:59 p.m.) Status -- This change has been

Jenkins build is back to stable : ktexteditor_master_qt5 #421

See http://build.kde.org/job/ktexteditor_master_qt5/421/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118692: Fix reading of entries for language/country combinations

On June 14, 2014, 9:36 a.m., Oswald Buddenhagen wrote: src/core/kconfigdata.h, line 68 https://git.reviewboard.kde.org/r/118692/diff/2/?file=280489#file280489line68 i didn't bother to re-read the whole code, so maybe that's why i can't claim to understand how that is supposed to

Re: Review Request 118546: No symlink to common/ directory for documentation common files (broken, now unused, UNIX only)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118546/ --- (Updated June 14, 2014, 8:09 p.m.) Status -- This change has been