Build failed in Jenkins: kdelibs4support_master_qt5 #223

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/kdelibs4support_master_qt5/223/changes Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 609 lines...] Automatic moc for target kshortcuttest Scanning dependencies of target ktabwidgettest_automoc

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-17 Thread Vishesh Handa
On June 16, 2014, 7:10 p.m., Martin Gräßlin wrote: I would like to get the opinion from people who designed kglobalaccel. Personally I do not understand what the default shortcuts are for and why they are needed. From reading the documentation my understanding is that your patch is

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #550

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/550/ -- [...truncated 183 lines...] Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR --

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #550

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/550/ -- [...truncated 220 lines...] Generating framesvgitem.moc

KF5 Update Meeting Minutes 2014-w25

2014-06-17 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 25 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: agateau, apol, mgraesslin and myself. * agateau did some kapidox fixes on api.kde.org; * he also fixed a crash in KCMultiDialog; * he also proposed

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #551

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/551/changes Changes: [aleixpol] Ensure that the containment's corona is properly calculated. [aleixpol] Reduce Applet::containment calls [kde] Add icon size tiny

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #551

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/551/changes Changes: [aleixpol] Ensure that the containment's corona is properly calculated. [aleixpol] Reduce Applet::containment calls [kde] Add icon size tiny --

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #552

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/552/changes Changes: [mklapetek] [calendar import]Remove useless function -- [...truncated 174 lines...] * Qt5Test (required version = 5.2.0) Required for tests

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #552

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/552/changes Changes: [mklapetek] [calendar import]Remove useless function -- [...truncated 200 lines...] Scanning dependencies of target

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #553

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/553/changes Changes: [mklapetek] [calendar import]Set 'today' properly [mklapetek] [calendar import]Fix months capitalization -- [...truncated 208 lines...]

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #553

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/553/changes Changes: [mklapetek] [calendar import]Set 'today' properly [mklapetek] [calendar import]Fix months capitalization -- [...truncated 200 lines...] Scanning

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #554

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/554/changes Changes: [mklapetek] Remove bad merge leftovers -- [...truncated 190 lines...] == Commencing the Build Scanning dependencies of target

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #554

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/554/changes Changes: [mklapetek] Remove bad merge leftovers -- [...truncated 209 lines...] Automatic moc for target plasmacomponentsplugin Generating

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-17 Thread Kevin Ottens
On May 28, 2014, 12:56 p.m., Aurélien Gâteau wrote: Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) fails with this error: [ 55%] Building CXX object autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o In file included from

Re: Review Request 117985: frameworks/kjs: add missing man page docbook

2014-06-17 Thread Kevin Ottens
On May 5, 2014, 7:17 a.m., Kevin Ottens wrote: IIRC that was intentional as to not have kjs depend on kdoctools. Alex Merry wrote: Hrm. Distros like Debian aren't going to be super-happy about this. And KJS is officially a porting aid, so I'm not sure bumping it to tier 3 is that

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review60275 --- Patrick, this patch got two ship it, any reason why it's not

Re: Review Request 118162: Make sure to use the absolute file path for test files.

2014-06-17 Thread Kevin Ottens
On May 16, 2014, 11:49 a.m., Alex Merry wrote: This sounds like an issue that needs to be fixed in KArchive... Alex Merry wrote: Where, exactly, were the files appearing? And which files were appearing there? Any update about that patch? - Kevin

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review60277 --- Marco, any chance for a second run of review on that patch?

Re: Review Request 117974: Some more KArchive examples

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review60278 --- Ship it! Ship It! - Kevin Ottens On June 6, 2014, 7:15

Re: Review Request 118725: use renamed .direcory files

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/#review60279 --- Looks fine to me, I'd like David's opinion on it though. -

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Marco Martin
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? i still not like this patch.. - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60282 --- Ship it! Looks fine to me. - Kevin Ottens On June 14,

Re: Review Request 118740: Use standard message box icon size in password dialogs

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/#review60283 --- Ship it! Ship It! - Kevin Ottens On June 14, 2014, 11:11

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review60286 --- Ship it! Independent from the (needed) change for uic -tr

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60285 --- Ship it! Looks fine to me. - Kevin Ottens On June 15,

Re: Review Request 118614: Make KIO thread-safe

2014-06-17 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60288 --- Since there was no problem in QtDBus after all, this patch

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-17 Thread Kevin Ottens
On June 16, 2014, 10:09 a.m., Emmanuel Pescosta wrote: src/core/kcoredirlister_p.h, lines 40-42 https://git.reviewboard.kde.org/r/118775/diff/1/?file=281658#file281658line40 using KFileItem::KFileItem; maybe? Frank Reininghaus wrote: Maybe - I'm always a bit unsure which

Re: Review Request 118780: Disable the xcb flush connection workaround for Qt = 5.3.1

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118780/#review60291 --- Ship it! Ship It! - Kevin Ottens On June 16, 2014, 12:42

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

2014-06-17 Thread Kevin Ottens
On June 16, 2014, 7:10 p.m., Martin Gräßlin wrote: I would like to get the opinion from people who designed kglobalaccel. Personally I do not understand what the default shortcuts are for and why they are needed. From reading the documentation my understanding is that your patch is

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a dead end. I prefer that to open

Re: Review Request 118690: Introduce a KLocalizedTranslator

2014-06-17 Thread Aleix Pol Gonzalez
On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: What's the use case? Didn't we have a different way for translating ui files? Martin Gräßlin wrote: What's the use case? well as explained in the comment for translating dynamically loaded UI files. Where is that

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Marco Martin
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Kevin Ottens wrote: Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-17 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60298 --- LGTM. Just a couple of minor points, but if you prefer to

Re: Review Request 118725: use renamed .direcory files

2014-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/#review60304 --- Ship it! Ship It! - David Faure On June 17, 2014, 4:14

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60306 --- I agree with the others, good temporary solution for the API,

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60309 --- This review has been submitted with commit

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60308 --- This review has been submitted with commit

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- (Updated June 17, 2014, 6:17 p.m.) Status -- This change has been

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

2014-06-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- (Updated June 17, 2014, 6:17 p.m.) Status -- This change has been

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #555

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/555/changes Changes: [notmart] fix tooltip resize in folderview -- [...truncated 190 lines...] == Commencing the Build Scanning dependencies of target

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #555

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/555/changes Changes: [notmart] fix tooltip resize in folderview -- [...truncated 184 lines...] KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Build

Re: Review Request 118740: Use standard message box icon size in password dialogs

2014-06-17 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/ --- (Updated June 17, 2014, 9:16 p.m.) Status -- This change has been

Re: Review Request 118740: Use standard message box icon size in password dialogs

2014-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/#review60332 --- This review has been submitted with commit

Build failed in Jenkins: kwidgetsaddons_master_qt5 #80

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/kwidgetsaddons_master_qt5/80/changes Changes: [christoph] Use standard message box icon size in password dialogs -- [...truncated 164 lines...] Automatic moc for target kwidgetsaddons-kmessagewidgetautotest Automatic moc for

Build failed in Jenkins: kwidgetsaddons_master_qt5 #81

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/kwidgetsaddons_master_qt5/81/changes Changes: [christoph] Fix build -- [...truncated 176 lines...] [ 7%] Generating moc_kdatetimeedittest.cpp Generating moc_kdatecomboboxtest.cpp Scanning dependencies of target

Jenkins build is back to normal : kwidgetsaddons_master_qt5 #82

2014-06-17 Thread KDE CI System
See http://build.kde.org/job/kwidgetsaddons_master_qt5/82/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118692: Fix reading of entries for language/country combinations

2014-06-17 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60336 --- Ship it! LGTM. Just a couple of minor issues, and a couple

Re: Review Request 118264: Switch to PolkitQt5-1

2014-06-17 Thread Hrvoje Senjan
On May 28, 2014, 2:56 p.m., Aurélien Gâteau wrote: Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) fails with this error: [ 55%] Building CXX object autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o In file included from

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Kevin Ottens
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Kevin Ottens wrote: Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a