Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers

2014-07-16 Thread Alex Merry
On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first

Re: Web Shortcuts KCM

2014-07-16 Thread David Faure
On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: (ie at most a widget would be enough for the app related settings, we should talk to the underlying platform for the other ones). I don't want users to have to configure their search engines in 10 KDE apps one after the other by hand. A

Review Request 119316: Fix minor memory leak in Wallpaper interface

2014-07-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119316/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119316: Fix minor memory leak in Wallpaper interface

2014-07-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119316/#review62493 --- Ship it! Ship It! - Marco Martin On July 16, 2014, 11:57

Re: Review Request 119316: Fix minor memory leak in Wallpaper interface

2014-07-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119316/ --- (Updated July 16, 2014, 1:39 p.m.) Status -- This change has been

Call for help: possible race conditions in KAuth

2014-07-16 Thread Luca Beltrame
When submitting KAuth to openSUSE, the SUSE security team found possible race conditions that could lead to security issues[1]- I'm writing here because until these issues are solved, KAuth will not be accepted into openSUSE. The second reason I'm posting this here is because it seems people

Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

2014-07-16 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119321/ --- Review request for KDE Frameworks. Repository: kio-extras Description

Review Request 119323: fix auth race condition

2014-07-16 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- Review request for KDE Frameworks and Martin Bříza. Repository: kauth

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 16, 2014, 4:05 p.m.) Review request for KDE Frameworks,

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62520 --- I ran the (few) autotests, and those also pass. I can't test

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Hrvoje Senjan
On July 16, 2014, 6:06 p.m., Luca Beltrame wrote: I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully. a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =) also polkit reports system-bus-name is used - Hrvoje

Re: Review Request 119321: kio-extras: Install KIO and KDED modules into correct folders

2014-07-16 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119321/#review62522 --- The kioslaves part seems to be more or less like my patch

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Krammer
On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: (ie at most a widget would be enough for the app related settings, we should talk to the underlying platform for the other ones). I don't want users to have to configure their

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Ottens
On Wednesday 16 July 2014 21:12:25 Kevin Krammer wrote: On Wednesday, 2014-07-16, 10:33:43, David Faure wrote: On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: (ie at most a widget would be enough for the app related settings, we should talk to the underlying platform for

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Ottens
On Wednesday 16 July 2014 10:33:43 David Faure wrote: On Tuesday 15 July 2014 15:16:20 Kevin Ottens wrote: (ie at most a widget would be enough for the app related settings, we should talk to the underlying platform for the other ones). I don't want users to have to configure their

Re: Web Shortcuts KCM

2014-07-16 Thread Kevin Ottens
On Tuesday 15 July 2014 16:59:29 Eike Hein wrote: On 07/15/2014 03:16 PM, Kevin Ottens wrote: Well, for a single entry menu, really? :-) Yeah, I do care about every single menu entry not being broken, no matter where users use my app :). Sorry, I was unclear there. I meant having to deal

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62546 --- src/backends/polkit-1/Polkit1Backend.cpp

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62547 --- FYI, this probably needs to go in kdelibs too as the issue is