Re: Review Request 119323: fix auth race condition

2014-07-18 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62631 --- Ship it! I have been using this for 4.x and 5.x for a while

Re: Review Request 119331: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-07-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119331/#review62636 --- Ship it! Ship It! - Alex Merry On July 17, 2014, 11:01

Re: Review Request 119345: Port away from deprecated QUrl API

2014-07-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119345/ --- (Updated July 18, 2014, 9:34 a.m.) Status -- This change has been

Re: Review Request 119349: typo in signal names ( upowermanager )

2014-07-18 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119349/#review62638 --- Hmm, my upower (and also the newer one) has

Re: Review Request 119349: typo in signal names ( upowermanager )

2014-07-18 Thread Ömer Fadıl Usta
On July 18, 2014, 12:50 p.m., Lukáš Tinkl wrote: Hmm, my upower (and also the newer one) has DeviceAdded/Removed signals... how did you come to this conclusion? Have you done any testing? Yes you are right, after making test the result is same. Still getting no such Signal erros in my

Re: Review Request 119349: typo in signal names ( upowermanager )

2014-07-18 Thread Ömer Fadıl Usta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119349/ --- (Updated July 18, 2014, 12:58 p.m.) Status -- This change has been

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

2014-07-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62619 --- src/declarativeimports/core/framesvgitem.cpp

Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

2014-07-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119356/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-07-18 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 18, 2014, 3:34 nachm.) Review request for KDE Frameworks.

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

2014-07-18 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62657 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119331: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

2014-07-18 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119331/ --- (Updated July 18, 2014, 2:51 p.m.) Status -- This change has been