Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Axel Rasmussen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119564/ --- (Updated Aug. 5, 2014, 7:07 a.m.) Status -- This change has been dis

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Kevin Funk
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

2014-08-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated Aug. 5, 2014, 7:50 a.m.) Status -- This change has been mar

Re: KAction Warning

2014-08-05 Thread laurent Montel
Le mardi 5 août 2014 08:19:35 David Faure a écrit : > On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: > > Hi, > > > > perhaps that is a stupid question, but last time I read up in the docs, > > they didn't help me: > > > > KatePart spits out a lot of: > > > > kate(15138)/(default) KX

Re: KAction Warning

2014-08-05 Thread Christoph Cullmann
> On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: > > Hi, > > > > perhaps that is a stupid question, but last time I read up in the docs, > > they > > didn't help me: > > > > KatePart spits out a lot of: > > > > kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties

Re: Review Request 119382: Port kio-mtp to KF5

2014-08-05 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/ --- (Updated Srp. 5, 2014, 12:36 odp.) Status -- This change has been ma

Making KFileMetaData a framework

2014-08-05 Thread Vishesh Handa
Hello people I would like to make KFileMetaData a framework. It's a simple library for extracting file metadata and text. It depends on the i18n and KArchive (can be made optional), along with a number of external dependencies which are optional. The code is of decent quality, and we have a ce

Re: Making KFileMetaData a framework

2014-08-05 Thread David Edmundson
In general that's some of the tidied code I've seen in a long time. Comments below. One major, most not. TypeInfo/PropertyInfo/SimpleExtractionResult need a working &operator= otherwise we shallow copy d. I can cause a crash in dump.cpp Extracting info from a file can take a long time

Re: Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-08-05 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119152/ --- (Updated Aug. 5, 2014, 8:06 p.m.) Status -- This change has been dis

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-08-05 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/ --- (Updated Aug. 5, 2014, 8:21 p.m.) Review request for KDE Frameworks, kwin

Re: Review Request 119588: Remove Qt5 debugfull hack from ECMConfig.cmake

2014-08-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119588/ --- (Updated Aug. 5, 2014, 9:09 p.m.) Review request for Extra Cmake Modules

Re: Making KFileMetaData a framework

2014-08-05 Thread Kevin Ottens
Hello, On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: > I would appreciate it if everyone could review the code once before it gets > into frameworks. metainfo.yaml should have "release: false" until it's part of a KF release. Also it should be integration and not functional (relies on

Re: Review Request 119505: Instance our onw QFileDialog instead of using getExistingDirectoryUrl

2014-08-05 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119505/ --- (Updated ago. 5, 2014, 10:01 p.m.) Review request for KDE Frameworks. R

Re: KDE Frameworks 5.1.0 release

2014-08-05 Thread Martin Klapetek
On Sat, Aug 2, 2014 at 3:48 PM, David Faure wrote: > I just tagged and packed 5.1.0. > Bugzilla versions also need to be updated. Is there some easy batch way to add new versions to bugzilla products? If not, I'll spend the time tomorrow evening adding them to all frameworks-* products. Cheers

Re: KDE Frameworks 5.1.0 release

2014-08-05 Thread Luigi Toscano
Martin Klapetek ha scritto: > On Sat, Aug 2, 2014 at 3:48 PM, David Faure > wrote: > > I just tagged and packed 5.1.0. > > > Bugzilla versions also need to be updated. Is there some easy batch way to add > new versions to bugzilla products? If not, I'll spend the time

Re: Review Request 119588: Remove Qt5 debugfull hack from ECMConfig.cmake

2014-08-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119588/#review63888 --- Ship it! Looks reasonable to me. - Aleix Pol Gonzalez On A

Re: Web Shortcuts KCM

2014-08-05 Thread Eike Hein
On 08/04/2014 10:09 AM, David Faure wrote: So yep, that's not going away any time soon ;) Alright, so that leaves the licensing problem, right? Do I need to rewrite the KCM? Can I even? Do we contact Yves Arrouye for relicensing? Cheers, Eike ___