Re: Review Request 120023: Fix crash in unit test when run with ASAN

2014-09-01 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120023/ --- (Updated Sept. 1, 2014, 7:26 p.m.) Status -- This change has been ma

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/ --- (Updated Sept. 1, 2014, 7:04 p.m.) Status -- This change has been ma

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/#review65661 --- Ship it! Ship It! - David Edmundson On Sept. 1, 2014, 6:37

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread Marco Martin
> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so >

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/ --- (Updated Sept. 1, 2014, 6:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread David Edmundson
> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so >

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/ --- (Updated Sept. 1, 2014, 5:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread Marco Martin
> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? It would usually be the packagestructure setting it, in initPackage(), so setFallbackPackage follows the s

Re: Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/#review65648 --- I need some the concept explaining, why would a developer set

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-01 Thread Martin Klapetek
> On Aug. 31, 2014, 6:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Review Request 120029: introduce the concept of package fallback

2014-09-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120029/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 1, 2014, 1:53 p.m.) Review request for Build System, KDE F

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-01 Thread Aleix Pol Gonzalez
> On Aug. 29, 2014, 9:13 p.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, lines 144-147 > > > > > > Hmm... I wonder what happens if you have multiple calls in the same > > project with differe

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-01 Thread Denis Steckelmacher
> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-01 Thread Aleix Pol Gonzalez
> On Aug. 31, 2014, 4:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-01 Thread Martin Klapetek
> On Aug. 31, 2014, 6:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-09-01 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Sept. 1, 2014, 3:54 p.m.) Review request for Build System and KD

Re: Loss of Jenkins build data

2014-09-01 Thread Marko Käning
Hi Ben, > No binary builds were lost. This only affects the build log > information accessible through the build.kde.org web interface. oh, I see. That's why there are so many half-empty entries in the build log lists... Thanks for the info, Marko ___

Re: Loss of Jenkins build data

2014-09-01 Thread Ben Cooksley
On Mon, Sep 1, 2014 at 9:59 PM, "Marko Käning" wrote: > Hi Ian, Hi Marko, > > did this also the data stored for OSX/CI? No binary builds were lost. This only affects the build log information accessible through the build.kde.org web interface. > > Greets, > Marko Thanks, Ben > __

Re: Loss of Jenkins build data

2014-09-01 Thread Marko Käning
Hi Ian, did this also the data stored for OSX/CI? Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : ktexteditor_master_qt5 #602

2014-09-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kcmutils_master_qt5 #78

2014-09-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktexteditor_master_qt5 #601

2014-09-01 Thread KDE CI System
See Changes: [cullmann] fix compile: fix dependencies + fix syntax file [walch.martin] Fix for bug #333156 "PHP Comment not highlighted correctly" [walch.martin] Do not wrap opening tag in kconfig.xml. [cullmann] add Dockerfile HL

Loss of Jenkins build data

2014-09-01 Thread Ben Cooksley
Hi all, Due to https://issues.jenkins-ci.org/browse/JENKINS-21268 we have lost the past 2 weeks worth of Jenkins builds on the CI system. Hopefully all other changes in the past 2 weeks have remained persistent as it is unclear whether they will survive this bug as well. As the Maven plugin has n

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

2014-09-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/#review65624 --- You wrote: "I have not yet completely grasped the concept of t

Re: Review Request 120023: Fix crash in unit test when run with ASAN

2014-09-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120023/#review65622 --- Ship it! I agree about using C++ style casts or C++ style con