Compression of SVG(Z)s in git repositories

2014-09-02 Thread Elias Probst
I've noticed, that (except of only a very few) nearly all SVG files are committed as SVGZ to our git repositories. This has IMHO several drawbacks: - every change will be stored as a single atomic blob - git's internal packfile compression and deduplication can't be used - no diffs for changes don

Re: What to do with autostart scripts? (kinit / ksmserver problem)

2014-09-02 Thread Luca Beltrame
In data martedì 19 agosto 2014 21:48:04, David Faure ha scritto: > I'd pick option 1 - do it all in ksmserver. I suppose this would mean running all but .desktop files (which are handled by kinit)? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Des

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-02 Thread Ben Cooksley
> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Alexander Volkov
> On Aug. 28, 2014, 9:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-02 Thread Denis Steckelmacher
> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Sebastian Kügler
On Monday, September 01, 2014 12:59:04 Elias Probst wrote: > I've noticed, that (except of only a very few) nearly all SVG files are > committed as SVGZ to our git repositories. > > This has IMHO several drawbacks: > - every change will be stored as a single atomic blob > - git's internal packfile

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Albert Astals Cid
> On ago. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Jonathan Riddell
> On Aug. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Martin Gräßlin
On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: > On Monday, September 01, 2014 12:59:04 Elias Probst wrote: > > I've noticed, that (except of only a very few) nearly all SVG files are > > committed as SVGZ to our git repositories. > > > > This has IMHO several drawbacks: > > - every

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Albert Astals Cid
> On ago. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-02 Thread Ben Cooksley
> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-09-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65702 --- Ship it! I think it looks good, let's get this in. - Aleix P

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Jonathan Riddell
> On Aug. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Alexander Volkov
> On Aug. 28, 2014, 9:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Alexander Volkov
> On Aug. 28, 2014, 9:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-02 Thread Albert Astals Cid
> On ago. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Dominik Haumann
On Tuesday 02 September 2014 12:48:07 Martin Gräßlin wrote: > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: > > On Monday, September 01, 2014 12:59:04 Elias Probst wrote: > > > I've noticed, that (except of only a very few) nearly all SVG files are > > > committed as SVGZ to our git

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Milian Wolff
On Tuesday 02 September 2014 17:00:47 Dominik Haumann wrote: > On Tuesday 02 September 2014 12:48:07 Martin Gräßlin wrote: > > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: > > > On Monday, September 01, 2014 12:59:04 Elias Probst wrote: > > > > I've noticed, that (except of only a

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Aleix Pol
On Mon, Sep 1, 2014 at 12:59 PM, Elias Probst wrote: > I've noticed, that (except of only a very few) nearly all SVG files are > committed as SVGZ to our git repositories. > > This has IMHO several drawbacks: > - every change will be stored as a single atomic blob > - git's internal packfile comp

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Elias Probst
On 09/02/2014 12:48 PM, Martin Gräßlin wrote: > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: >> On Monday, September 01, 2014 12:59:04 Elias Probst wrote: >>> I've noticed, that (except of only a very few) nearly all SVG files are >>> committed as SVGZ to our git repositories. >>>

Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:26 p.m.) Review request for KDE Frameworks and

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks. R

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks. R

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/ --- (Updated Sept. 2, 2014, 6:27 p.m.) Review request for KDE Frameworks and

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65732 --- doesn't actually affect the second bug, if one were to write a

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65734 --- kdesu/CMakeLists.txt

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120040/#review65738 --- >in kde4 kdesu was installed under bin it was actually also i

Re: Review Request 120040: Install kdesu under bin

2014-09-02 Thread Marco Martin
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: > > I'm a bit worried by the multitude of user and distro specific scripts that > > rely on kdesu being present :/ to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be coinstallable so distributio

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65735 --- OK, just some documentation cleanups, then I think we're good

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-09-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65740 --- Ship it! Ship It! - Alex Merry On Sept. 1, 2014, 10:24 a.m

Re: What to do with autostart scripts? (kinit / ksmserver problem)

2014-09-02 Thread Elias Probst
On 08/19/2014 09:48 PM, David Faure wrote: >> What do the gurus say on this? > I'd pick option 1 - do it all in ksmserver. I'd vote against this and vote for: - only *.desktop files The reason: in the long term, we're going to add support for systemd user-sessions. This will bring a huge cleanup

Re: Review Request 120029: introduce the concept of package fallback

2014-09-02 Thread Aaron J. Seigo
> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so >